Re: [PATCH 5/6] staging: ks7010: Fix line over 80 characters.

[Joe Perches]

On Mon, 2018-03-19 at 22:58 -0700, Quytelda Kahja wrote:
> There is no reason for comment describing the BSSID check for loop
> to be spaced so far to the right.  Move it above the for loop.
[]
> diff --git a/drivers/staging/ks7010/ks_hostif.c 
> b/drivers/staging/ks7010/ks_hostif.c
[]
> @@ -844,7 +844,8 @@ void hostif_scan_indication(struct ks_wlan_private *priv)
>   ap_info = (struct ap_info_t *)(priv->rxp);
>  
>   if (priv->scan_ind_count) {
> - for (i = 0; i < priv->aplist.size; i++) {   /* bssid check 
> */
> + /* bssid check */
> + for (i = 0; i < priv->aplist.size; i++) {
>   if (memcmp(ap_info->bssid,
>  priv->aplist.ap[i].bssid, ETH_ALEN) != 0)

this could also use ether_addr_equal

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 5/6] staging: ks7010: Fix line over 80 characters.

[Quytelda Kahja]

There is no reason for comment describing the BSSID check for loop
to be spaced so far to the right.  Move it above the for loop.

Signed-off-by: Quytelda Kahja 
---
 drivers/staging/ks7010/ks_hostif.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/ks7010/ks_hostif.c 
b/drivers/staging/ks7010/ks_hostif.c
index 2de4dbbcd9de..6fc2c3647908 100644
--- a/drivers/staging/ks7010/ks_hostif.c
+++ b/drivers/staging/ks7010/ks_hostif.c
@@ -844,7 +844,8 @@ void hostif_scan_indication(struct ks_wlan_private *priv)
ap_info = (struct ap_info_t *)(priv->rxp);
 
if (priv->scan_ind_count) {
-   for (i = 0; i < priv->aplist.size; i++) {   /* bssid check 
*/
+   /* bssid check */
+   for (i = 0; i < priv->aplist.size; i++) {
if (memcmp(ap_info->bssid,
   priv->aplist.ap[i].bssid, ETH_ALEN) != 0)
continue;
-- 
2.16.2

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 5/6] staging: ks7010: Fix line over 80 characters.

[Quytelda Kahja]

There is no reason for comment describing the BSSID check for loop
to be spaced so far to the right.  Move it above the for loop.

Signed-off-by: Quytelda Kahja 
---
 drivers/staging/ks7010/ks_hostif.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/ks7010/ks_hostif.c 
b/drivers/staging/ks7010/ks_hostif.c
index 2de4dbbcd9de..6fc2c3647908 100644
--- a/drivers/staging/ks7010/ks_hostif.c
+++ b/drivers/staging/ks7010/ks_hostif.c
@@ -844,7 +844,8 @@ void hostif_scan_indication(struct ks_wlan_private *priv)
ap_info = (struct ap_info_t *)(priv->rxp);
 
if (priv->scan_ind_count) {
-   for (i = 0; i < priv->aplist.size; i++) {   /* bssid check 
*/
+   /* bssid check */
+   for (i = 0; i < priv->aplist.size; i++) {
if (memcmp(ap_info->bssid,
   priv->aplist.ap[i].bssid, ETH_ALEN) != 0)
continue;
-- 
2.16.2

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel