Re: [PATCH 8/8] staging: pi433: replace printk calls with dev_dbg

2017-12-13 Thread Valentin Vidic 
On Wed, Dec 13, 2017 at 05:52:36PM +0300, Dan Carpenter wrote:
> On Wed, Dec 13, 2017 at 03:21:56PM +0100, Valentin Vidic wrote:
> >  drivers/staging/pi433/pi433_if.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/staging/pi433/pi433_if.c 
> > b/drivers/staging/pi433/pi433_if.c
> > index 9e558154a143..02a5ba019801 100644
> > --- a/drivers/staging/pi433/pi433_if.c
> > +++ b/drivers/staging/pi433/pi433_if.c
> > @@ -720,7 +720,7 @@ pi433_tx_thread(void *data)
> > retval = 
> > wait_event_interruptible(device->fifo_wait_queue,
> >   device->free_in_fifo 
> > > 0);
> > if (retval) {
> > -   printk("ABORT\n");
> > +   dev_dbg(device->dev, "ABORT\n");
> > goto abort;
> 
> Hm...  The kernel.org version of this driver has never looked like this.
> I wonder what you are working against...

Patch was against staging-testing, in linux-next this printk looks like
this:

   if (retval) { printk("ABORT\n"); goto abort; }

-- 
Valentin
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 8/8] staging: pi433: replace printk calls with dev_dbg

2017-12-13 Thread Dan Carpenter 
On Wed, Dec 13, 2017 at 03:21:56PM +0100, Valentin Vidic wrote:
>  drivers/staging/pi433/pi433_if.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/pi433/pi433_if.c 
> b/drivers/staging/pi433/pi433_if.c
> index 9e558154a143..02a5ba019801 100644
> --- a/drivers/staging/pi433/pi433_if.c
> +++ b/drivers/staging/pi433/pi433_if.c
> @@ -720,7 +720,7 @@ pi433_tx_thread(void *data)
>   retval = 
> wait_event_interruptible(device->fifo_wait_queue,
> device->free_in_fifo 
> > 0);
>   if (retval) {
> - printk("ABORT\n");
> + dev_dbg(device->dev, "ABORT\n");
>   goto abort;

Hm...  The kernel.org version of this driver has never looked like this.
I wonder what you are working against...

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 8/8] staging: pi433: replace printk calls with dev_dbg

2017-12-13 Thread Valentin Vidic 
Fixes checkpatch warning:

  WARNING: printk() should include KERN_ facility level

Signed-off-by: Valentin Vidic 
---
 drivers/staging/pi433/pi433_if.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index 9e558154a143..02a5ba019801 100644
--- a/drivers/staging/pi433/pi433_if.c
+++ b/drivers/staging/pi433/pi433_if.c
@@ -720,7 +720,7 @@ pi433_tx_thread(void *data)
retval = 
wait_event_interruptible(device->fifo_wait_queue,
  device->free_in_fifo 
> 0);
if (retval) {
-   printk("ABORT\n");
+   dev_dbg(device->dev, "ABORT\n");
goto abort;
}
}
@@ -731,7 +731,7 @@ pi433_tx_thread(void *data)
 device->free_in_fifo == FIFO_SIZE ||
 kthread_should_stop());
if (kthread_should_stop())
-   printk("ABORT\n");
+   dev_dbg(device->dev, "ABORT\n");
 
/* STOP_TRANSMISSION */
dev_dbg(device->dev, "thread: Packet sent. Set mode to stby.");
-- 
2.15.0

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel