Re: [PATCH 91/93] Staging: comedi: 8253.h fixed by removing 'return' from generic func

[Dan Carpenter]

Oh, wow.  No.  All these patches are wrong but there are too many to
discuss them individually.

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 91/93] Staging: comedi: 8253.h fixed by removing 'return' from generic func

[Ian Abbott]

On 2014-07-15 04:13, sam-the-6 wrote:

From: Sam Asadi asadi.sam...@gmail.com

Signed-off-by: Sam Asadi asadi.sam...@gmail.com

modified:   drivers/staging/comedi/drivers/8253.h
---
  drivers/staging/comedi/drivers/8253.h |3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/drivers/8253.h 
b/drivers/staging/comedi/drivers/8253.h
index 5829b46..f6b8607 100644
--- a/drivers/staging/comedi/drivers/8253.h
+++ b/drivers/staging/comedi/drivers/8253.h
@@ -55,7 +55,7 @@ static inline void i8253_cascade_ns_to_timer(int 
i8253_osc_base,
/* check for overflow */
divider  div1  divider  div2 
divider * i8253_osc_base  divider 
-   divider * i8253_osc_base  i8253_osc_base) {
+   divider * i8253_osc_base  i8253_osc_base)   {


Keep the space before the '{'.  Don't replace it with a tab.


return;
}

@@ -118,7 +118,6 @@ static inline void i8253_cascade_ns_to_timer(int 
i8253_osc_base,
/*  masking is done since counter maps zero to 0x1 */
*d1 = div1  0x;
*d2 = div2  0x;
-   return;
  }

  #ifndef CMDTEST




--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk)=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587 )=-
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 91/93] Staging: comedi: 8253.h fixed by removing 'return' from generic func

[Greg KH]

On Tue, Jul 15, 2014 at 06:13:19AM +0300, sam-the-6 wrote:
 From: Sam Asadi asadi.sam...@gmail.com
 
 Signed-off-by: Sam Asadi asadi.sam...@gmail.com

Where are the other 90 patches in this series, I only received 91, 92,
93, and 94.  Wait, 94 out of 93  What is going on here?

 
   modified:   drivers/staging/comedi/drivers/8253.h

What is this line for?

Also, please look at your email client's From: line up above, it isn't
matching your From: and Signed-off-by: line in the body of the patch,
why?

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 91/93] Staging: comedi: 8253.h fixed by removing 'return' from generic func

[sam-the-6]

From: Sam Asadi asadi.sam...@gmail.com

Signed-off-by: Sam Asadi asadi.sam...@gmail.com

modified:   drivers/staging/comedi/drivers/8253.h
---
 drivers/staging/comedi/drivers/8253.h |3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/drivers/8253.h 
b/drivers/staging/comedi/drivers/8253.h
index 5829b46..f6b8607 100644
--- a/drivers/staging/comedi/drivers/8253.h
+++ b/drivers/staging/comedi/drivers/8253.h
@@ -55,7 +55,7 @@ static inline void i8253_cascade_ns_to_timer(int 
i8253_osc_base,
/* check for overflow */
divider  div1  divider  div2 
divider * i8253_osc_base  divider 
-   divider * i8253_osc_base  i8253_osc_base) {
+   divider * i8253_osc_base  i8253_osc_base)  {
return;
}
 
@@ -118,7 +118,6 @@ static inline void i8253_cascade_ns_to_timer(int 
i8253_osc_base,
/*  masking is done since counter maps zero to 0x1 */
*d1 = div1  0x;
*d2 = div2  0x;
-   return;
 }
 
 #ifndef CMDTEST
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel