Re: [PATCH net-next,v2] hyperv: Add handling of IP header with option field in netvsc_set_hash()

2014-10-14 Thread David Miller 
From: Haiyang Zhang haiya...@microsoft.com
Date: Tue, 14 Oct 2014 15:16:28 -0700

 In case that the IP header has optional field at the end, this patch will
 get the port numbers after that field, and compute the hash.
 
 Signed-off-by: Haiyang Zhang haiya...@microsoft.com
 Reviewed-by: K. Y. Srinivasan k...@microsoft.com

Instead of adding hack after hack after hack to your internal header
parser, just use the generic flow dissector we already have in the
kernel to fetch out the values you need.

__skb_flow_get_ports() etc.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

RE: [PATCH net-next, v2] hyperv: Add handling of IP header with option field in netvsc_set_hash()

2014-10-14 Thread Haiyang Zhang 


 -Original Message-
 From: Haiyang Zhang [mailto:haiya...@microsoft.com]
 Sent: Tuesday, October 14, 2014 4:05 PM
 To: da...@davemloft.net; net...@vger.kernel.org
 Cc: Haiyang Zhang; KY Srinivasan; o...@aepfle.de; jasow...@redhat.com;
 linux-ker...@vger.kernel.org; driverdev-devel@linuxdriverproject.org
 Subject: [PATCH net-next,v2] hyperv: Add handling of IP header with
 option field in netvsc_set_hash()
 

This is a duplicate of a patch submitted earlier today. Please ignore.


___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

RE: [PATCH net-next, v2] hyperv: Add handling of IP header with option field in netvsc_set_hash()

2014-10-14 Thread Haiyang Zhang 


 -Original Message-
 From: David Miller [mailto:da...@davemloft.net]
 Sent: Tuesday, October 14, 2014 5:37 PM
 To: Haiyang Zhang
 Cc: net...@vger.kernel.org; KY Srinivasan; o...@aepfle.de;
 jasow...@redhat.com; linux-ker...@vger.kernel.org; driverdev-
 de...@linuxdriverproject.org
 Subject: Re: [PATCH net-next,v2] hyperv: Add handling of IP header with option
 field in netvsc_set_hash()
 
 From: Haiyang Zhang haiya...@microsoft.com
 Date: Tue, 14 Oct 2014 15:16:28 -0700
 
  In case that the IP header has optional field at the end, this patch
  will get the port numbers after that field, and compute the hash.
 
  Signed-off-by: Haiyang Zhang haiya...@microsoft.com
  Reviewed-by: K. Y. Srinivasan k...@microsoft.com
 
 Instead of adding hack after hack after hack to your internal header parser, 
 just
 use the generic flow dissector we already have in the kernel to fetch out the
 values you need.
 
 __skb_flow_get_ports() etc.

Thanks. I will update the patch.

- Haiyang

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel