Re: [Outreachy kernel] Re: [PATCH v1] staging: media: Remove unused function atomisp_set_stop_timeout()
On Sun, 12 Mar 2017, SIMRAN SINGHAL wrote: > On Sun, Mar 12, 2017 at 7:24 PM, Greg KHwrote: > > On Fri, Mar 10, 2017 at 07:05:05PM +0530, simran singhal wrote: > >> The function atomisp_set_stop_timeout on being called, simply returns > >> back. The function hasn't been mentioned in the TODO and doesn't have > >> FIXME code around. Hence, atomisp_set_stop_timeout and its calls have been > >> removed. > >> > >> This was done using Coccinelle. > >> > >> @@ > >> identifier f; > >> @@ > >> > >> void f(...) { > >> > >> -return; > >> > >> } > >> > >> Signed-off-by: simran singhal > >> --- > >> v1: > >>-Change Subject to include name of function > >>-change commit message to include the coccinelle script > > > > You should also cc: the developers doing all of the current work on this > > driver, Alan Cox, to get their comment if this really is something that > > can be removed or not. > > > > thanks, > > > Greg I have cc'd all the developers which script get_maintainer.pl showed: > > $ git show HEAD | perl scripts/get_maintainer.pl --separator , > --nokeywords --nogit --nogit-fallback --norolestats Sometimes people do a lot of work on something without being the maintainer. You can see who has done this using git log. Dropping some of the "no" arguments might give you the same information, but in practice the results tend to be an overapproximation... julia > > Mauro Carvalho Chehab ,Greg Kroah-Hartman > , > linux-me...@vger.kernel.org,de...@driverdev.osuosl.org,linux-ker...@vger.kernel.org > > > greg k-h > > -- > You received this message because you are subscribed to the Google Groups > "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to outreachy-kernel+unsubscr...@googlegroups.com. > To post to this group, send email to outreachy-ker...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/outreachy-kernel/CALrZqyOdKmSF10Ba60_00OzzRMnKAt7XwjksmuQfGEKvBY-avg%40mail.gmail.com. > For more options, visit https://groups.google.com/d/optout. > ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v1] staging: media: Remove unused function atomisp_set_stop_timeout()
On Sun, Mar 12, 2017 at 7:24 PM, Greg KHwrote: > On Fri, Mar 10, 2017 at 07:05:05PM +0530, simran singhal wrote: >> The function atomisp_set_stop_timeout on being called, simply returns >> back. The function hasn't been mentioned in the TODO and doesn't have >> FIXME code around. Hence, atomisp_set_stop_timeout and its calls have been >> removed. >> >> This was done using Coccinelle. >> >> @@ >> identifier f; >> @@ >> >> void f(...) { >> >> -return; >> >> } >> >> Signed-off-by: simran singhal >> --- >> v1: >>-Change Subject to include name of function >>-change commit message to include the coccinelle script > > You should also cc: the developers doing all of the current work on this > driver, Alan Cox, to get their comment if this really is something that > can be removed or not. > > thanks, > Greg I have cc'd all the developers which script get_maintainer.pl showed: $ git show HEAD | perl scripts/get_maintainer.pl --separator , --nokeywords --nogit --nogit-fallback --norolestats Mauro Carvalho Chehab ,Greg Kroah-Hartman , linux-me...@vger.kernel.org,de...@driverdev.osuosl.org,linux-ker...@vger.kernel.org > greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v1] staging: media: Remove unused function atomisp_set_stop_timeout()
On Fri, Mar 10, 2017 at 07:05:05PM +0530, simran singhal wrote: > The function atomisp_set_stop_timeout on being called, simply returns > back. The function hasn't been mentioned in the TODO and doesn't have > FIXME code around. Hence, atomisp_set_stop_timeout and its calls have been > removed. > > This was done using Coccinelle. > > @@ > identifier f; > @@ > > void f(...) { > > -return; > > } > > Signed-off-by: simran singhal> --- > v1: >-Change Subject to include name of function >-change commit message to include the coccinelle script You should also cc: the developers doing all of the current work on this driver, Alan Cox, to get their comment if this really is something that can be removed or not. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v1] staging: media: Remove unused function atomisp_set_stop_timeout()
The function atomisp_set_stop_timeout on being called, simply returns back. The function hasn't been mentioned in the TODO and doesn't have FIXME code around. Hence, atomisp_set_stop_timeout and its calls have been removed. This was done using Coccinelle. @@ identifier f; @@ void f(...) { -return; } Signed-off-by: simran singhal--- v1: -Change Subject to include name of function -change commit message to include the coccinelle script drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c | 1 - drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat.h | 1 - drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_css20.c | 5 - 3 files changed, 7 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c index d9a5c24..9720756 100644 --- a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c +++ b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c @@ -1692,7 +1692,6 @@ void atomisp_wdt_work(struct work_struct *work) } } #endif - atomisp_set_stop_timeout(ATOMISP_CSS_STOP_TIMEOUT_US); dev_err(isp->dev, "timeout recovery handling done\n"); atomic_set(>wdt_work_queued, 0); diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat.h b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat.h index e6b0cce..fb8b8fa 100644 --- a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat.h +++ b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat.h @@ -660,7 +660,6 @@ int atomisp_css_set_acc_parameters(struct atomisp_acc_fw *acc_fw); int atomisp_css_isr_thread(struct atomisp_device *isp, bool *frame_done_found, bool *css_pipe_done); -void atomisp_set_stop_timeout(unsigned int timeout); bool atomisp_css_valid_sof(struct atomisp_device *isp); diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_css20.c b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_css20.c index 6697d72..cfa0ad4 100644 --- a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_css20.c +++ b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_css20.c @@ -4699,11 +4699,6 @@ int atomisp_css_isr_thread(struct atomisp_device *isp, return 0; } -void atomisp_set_stop_timeout(unsigned int timeout) -{ - return; -} - bool atomisp_css_valid_sof(struct atomisp_device *isp) { unsigned int i, j; -- 2.7.4 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel