Re: [PATCH v1] staging: most: hdm_usb: Driver registration with module_driver macro

[Andrey Shvetsov]

On Sun, Aug 27, 2017 at 08:22:10AM +0300, Alex Briskin wrote:
> Register with module_driver macro instead of module_init/module_exit.
It must be the module_usb_driver. Also in the subject.

Hint: use the imperative sentence for the subject, like
"staging: most: hdm_usb: use module_usb_driver ..."

/andy

>
> Signed-off-by: Alex Briskin 
> ---
>  drivers/staging/most/hdm-usb/hdm_usb.c | 20 +---
>  1 file changed, 1 insertion(+), 19 deletions(-)
>
> diff --git a/drivers/staging/most/hdm-usb/hdm_usb.c 
> b/drivers/staging/most/hdm-usb/hdm_usb.c
> index a9c3785d19ae..85775da293fb 100644
> --- a/drivers/staging/most/hdm-usb/hdm_usb.c
> +++ b/drivers/staging/most/hdm-usb/hdm_usb.c
> @@ -1301,25 +1301,7 @@ static struct usb_driver hdm_usb = {
>   .disconnect = hdm_disconnect,
>  };
>
> -static int __init hdm_usb_init(void)
> -{
> - pr_info("hdm_usb_init()\n");
> - if (usb_register(_usb)) {
> - pr_err("could not register hdm_usb driver\n");
> - return -EIO;
> - }
> -
> - return 0;
> -}
> -
> -static void __exit hdm_usb_exit(void)
> -{
> - pr_info("hdm_usb_exit()\n");
> - usb_deregister(_usb);
> -}
> -
> -module_init(hdm_usb_init);
> -module_exit(hdm_usb_exit);
> +module_usb_driver(hdm_usb);
>  MODULE_LICENSE("GPL");
>  MODULE_AUTHOR("Christian Gromm ");
>  MODULE_DESCRIPTION("HDM_4_USB");
> --
> 2.11.0
>
> ___
> devel mailing list
> de...@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v1] staging: most: hdm_usb: Driver registration with module_driver macro

[Alex Briskin]

Register with module_driver macro instead of module_init/module_exit.

Signed-off-by: Alex Briskin 
---
 drivers/staging/most/hdm-usb/hdm_usb.c | 20 +---
 1 file changed, 1 insertion(+), 19 deletions(-)

diff --git a/drivers/staging/most/hdm-usb/hdm_usb.c 
b/drivers/staging/most/hdm-usb/hdm_usb.c
index a9c3785d19ae..85775da293fb 100644
--- a/drivers/staging/most/hdm-usb/hdm_usb.c
+++ b/drivers/staging/most/hdm-usb/hdm_usb.c
@@ -1301,25 +1301,7 @@ static struct usb_driver hdm_usb = {
.disconnect = hdm_disconnect,
 };
 
-static int __init hdm_usb_init(void)
-{
-   pr_info("hdm_usb_init()\n");
-   if (usb_register(_usb)) {
-   pr_err("could not register hdm_usb driver\n");
-   return -EIO;
-   }
-
-   return 0;
-}
-
-static void __exit hdm_usb_exit(void)
-{
-   pr_info("hdm_usb_exit()\n");
-   usb_deregister(_usb);
-}
-
-module_init(hdm_usb_init);
-module_exit(hdm_usb_exit);
+module_usb_driver(hdm_usb);
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Christian Gromm ");
 MODULE_DESCRIPTION("HDM_4_USB");
-- 
2.11.0

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel