Re: [PATCH v2] comedi/ni_pcidio: make all defines uppercase
On Thu, Jan 10, 2019 at 12:05:41PM +0100, Marco Ammon wrote: > Hi, > > thank you for your feedback. > > On 18/12/18 12:18 Ian Abbott wrote: > > Minor quibble: There should be a description of the 'v2' changes here > > (after the '---' line). > > > > Also, the patch "Subject:" line is missing the "staging:" tag. The > > usual set of tags for patches to this driver is "staging: comedi: > > ni_pcidio:". > > Should we resend the patch with a changed subject line respecting the > mentioned tags or will this be done on merging? > Please resend. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2] comedi/ni_pcidio: make all defines uppercase
On Thu, Jan 10, 2019 at 12:05:41PM +0100, Marco Ammon wrote: > Hi, > > thank you for your feedback. > > On 18/12/18 12:18 Ian Abbott wrote: > > Minor quibble: There should be a description of the 'v2' changes here > > (after the '---' line). > > > > Also, the patch "Subject:" line is missing the "staging:" tag. The > > usual set of tags for patches to this driver is "staging: comedi: > > ni_pcidio:". > > Should we resend the patch with a changed subject line respecting the > mentioned tags or will this be done on merging? You need to resend it please. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2] comedi/ni_pcidio: make all defines uppercase
Hi, thank you for your feedback. On 18/12/18 12:18 Ian Abbott wrote: > Minor quibble: There should be a description of the 'v2' changes here > (after the '---' line). > > Also, the patch "Subject:" line is missing the "staging:" tag. The > usual set of tags for patches to this driver is "staging: comedi: > ni_pcidio:". Should we resend the patch with a changed subject line respecting the mentioned tags or will this be done on merging? 0xA3072EA6327483B2.asc Description: application/pgp-keys ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2] comedi/ni_pcidio: make all defines uppercase
On 17/12/2018 20:51, Alexander Schroth wrote: According to the Linux coding guidelines, defines should be written in uppercase. This patch converts all define-statements in the ni_pcidio.c file to uppercase, thus matching the coding style of the kernel. Signed-off-by: Alexander Schroth Signed-off-by: Marco Ammon --- Minor quibble: There should be a description of the 'v2' changes here (after the '---' line). Also, the patch "Subject:" line is missing the "staging:" tag. The usual set of tags for patches to this driver is "staging: comedi: ni_pcidio:". Apart from that, the patch seems fine. Reviewed-by: Ian Abbott drivers/staging/comedi/drivers/ni_pcidio.c | 442 +++-- 1 file changed, 222 insertions(+), 220 deletions(-) -- -=( Ian Abbott || Web: www.mev.co.uk )=- -=( MEV Ltd. is a company registered in England & Wales. )=- -=( Registered number: 02862268. Registered address:)=- -=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=- ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2] comedi/ni_pcidio: make all defines uppercase
According to the Linux coding guidelines, defines should be written in uppercase. This patch converts all define-statements in the ni_pcidio.c file to uppercase, thus matching the coding style of the kernel. Signed-off-by: Alexander Schroth Signed-off-by: Marco Ammon --- drivers/staging/comedi/drivers/ni_pcidio.c | 442 +++-- 1 file changed, 222 insertions(+), 220 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_pcidio.c b/drivers/staging/comedi/drivers/ni_pcidio.c index b9a0dc6eac44..407922b096a3 100644 --- a/drivers/staging/comedi/drivers/ni_pcidio.c +++ b/drivers/staging/comedi/drivers/ni_pcidio.c @@ -49,116 +49,117 @@ /* defines for the PCI-DIO-32HS */ -#define Window_Address 4 /* W */ -#define Interrupt_And_Window_Status4 /* R */ -#define IntStatus1 BIT(0) -#define IntStatus2 BIT(1) -#define WindowAddressStatus_mask 0x7c - -#define Master_DMA_And_Interrupt_Control 5 /* W */ -#define InterruptLine(x) ((x) & 3) -#define OpenIntBIT(2) -#define Group_Status 5 /* R */ -#define DataLeft BIT(0) -#define ReqBIT(2) -#define StopTrig BIT(3) - -#define Group_1_Flags 6 /* R */ -#define Group_2_Flags 7 /* R */ -#define TransferReady BIT(0) -#define CountExpired BIT(1) -#define Waited BIT(5) -#define PrimaryTC BIT(6) -#define SecondaryTCBIT(7) +#define WINDOW_ADDRESS 4 /* W */ +#define INTERRUPT_AND_WINDOW_STATUS4 /* R */ +#define INT_STATUS_1 BIT(0) +#define INT_STATUS_2 BIT(1) +#define WINDOW_ADDRESS_STATUS_MASK 0x7c + +#define MASTER_DMA_AND_INTERRUPT_CONTROL 5 /* W */ +#define INTERRUPT_LINE(x) ((x) & 3) +#define OPEN_INT BIT(2) +#define GROUP_STATUS 5 /* R */ +#define DATA_LEFT BIT(0) +#define REQBIT(2) +#define STOP_TRIG BIT(3) + +#define GROUP_1_FLAGS 6 /* R */ +#define GROUP_2_FLAGS 7 /* R */ +#define TRANSFER_READY BIT(0) +#define COUNT_EXPIRED BIT(1) +#define WAITED BIT(5) +#define PRIMARY_TC BIT(6) +#define SECONDARY_TC BIT(7) /* #define SerialRose */ /* #define ReqRose */ /* #define Paused */ -#define Group_1_First_Clear6 /* W */ -#define Group_2_First_Clear7 /* W */ -#define ClearWaitedBIT(3) -#define ClearPrimaryTC BIT(4) -#define ClearSecondaryTC BIT(5) -#define DMAReset BIT(6) -#define FIFOReset BIT(7) -#define ClearAll 0xf8 - -#define Group_1_FIFO 8 /* W */ -#define Group_2_FIFO 12 /* W */ - -#define Transfer_Count 20 -#define Chip_ID_D 24 -#define Chip_ID_I 25 -#define Chip_ID_O 26 -#define Chip_Version 27 -#define Port_IO(x) (28 + (x)) -#define Port_Pin_Directions(x) (32 + (x)) -#define Port_Pin_Mask(x) (36 + (x)) -#define Port_Pin_Polarities(x) (40 + (x)) - -#define Master_Clock_Routing 45 -#define RTSIClocking(x)(((x) & 3) << 4) - -#define Group_1_Second_Clear 46 /* W */ -#define Group_2_Second_Clear 47 /* W */ -#define ClearExpired BIT(0) - -#define Port_Pattern(x)(48 + (x)) - -#define Data_Path 64 -#define FIFOEnableABIT(0) -#define FIFOEnableBBIT(1) -#define FIFOEnableCBIT(2) -#define FIFOEnableDBIT(3) -#define Funneling(x) (((x) & 3) << 4) -#define GroupDirection BIT(7) - -#define Protocol_Register_165 -#define OpMode Protocol_Register_1 -#define RunMode(x) ((x) & 7) -#define Numbered BIT(3) - -#define Protocol_Register_266 -#define ClockReg Protocol_Register_2 -#define ClockLine(x) (((x) & 3) << 5) -#define InvertStopTrig BIT(7) -#define DataLatching(x) (((x) & 3) << 5) - -#define Protocol_Register_367 -#define Sequence
