Re: [PATCH v2] staging: greybus: Fix a commit coding style issue.

[Greg KH]

On Fri, Sep 23, 2016 at 07:58:13PM +0530, Sidhant Gupta wrote:
> Fixes a comment coding style warning by adding 2 blank lines. Issue found by 
> checkpatch.
>

Please wrap your changelog text at 72 columns like git is trying to get
you to do...

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v2] staging: greybus: Fix a commit coding style issue.

[Sidhant Gupta]

Fixes a comment coding style warning by adding 2 blank lines. Issue found by 
checkpatch.

Signed-off-by: Sidhant Gupta 
---

Changes since v1:
* Corrected name in `From: ` and `Signed-off-by: ` sections.
* Cc-ed mailing list.
* Made commit message more clear.

 drivers/staging/greybus/arche-apb-ctrl.c | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/greybus/arche-apb-ctrl.c 
b/drivers/staging/greybus/arche-apb-ctrl.c
index 59d9d42..d811158 100644
--- a/drivers/staging/greybus/arche-apb-ctrl.c
+++ b/drivers/staging/greybus/arche-apb-ctrl.c
@@ -285,8 +285,10 @@ static ssize_t state_store(struct device *dev,
if (apb->state == ARCHE_PLATFORM_STATE_FW_FLASHING)
return count;
 
-   /* First we want to make sure we power off everything
-* and then enter FW flashing state */
+   /* 
+* First we want to make sure we power off everything
+* and then enter FW flashing state
+*/
poweroff_seq(pdev);
ret = fw_flashing_seq(pdev);
} else {
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel