Re: [PATCH v2 -next] staging: fieldbus: Fix build error without CONFIG_REGMAP_MMIO
On Mon, Jun 10, 2019 at 08:51:10AM -0400, Sven Van Asbroeck wrote: > Hello Greg, just a friendly ping regarding this patch. It got my Reviewed-by > tag > two weeks ago, no further feedback from anyone. Is there anything you would > like us to do before queuing this? > > Link to v2 that got the Reviewed-by: > https://lkml.org/lkml/2019/5/28/609 > > On Tue, May 28, 2019 at 1:31 PM Sven Van Asbroeck wrote: > > For the v2 patch: > > Reviewed-by: Sven Van Asbroeck Odd, sorry, must have fell through the cracks, I'll pick it up now. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 -next] staging: fieldbus: Fix build error without CONFIG_REGMAP_MMIO
Hello Greg, just a friendly ping regarding this patch. It got my Reviewed-by tag two weeks ago, no further feedback from anyone. Is there anything you would like us to do before queuing this? Link to v2 that got the Reviewed-by: https://lkml.org/lkml/2019/5/28/609 On Tue, May 28, 2019 at 1:31 PM Sven Van Asbroeck wrote: > For the v2 patch: > Reviewed-by: Sven Van Asbroeck > ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 -next] staging: fieldbus: Fix build error without CONFIG_REGMAP_MMIO
On Tue, May 28, 2019 at 12:00 PM Greg KH wrote: > > You all need a better email client, mutt handles this just fine, it's > not a problem on my system with my workflow at all :) Argh, my bad. I use Google Mail -> Download Message, which does appear to mess up the endings. Luckily, dos2unix fixes it up just fine. For the v2 patch: Reviewed-by: Sven Van Asbroeck Thank you YueHaibing. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 -next] staging: fieldbus: Fix build error without CONFIG_REGMAP_MMIO
On Tue, May 28, 2019 at 11:41:57PM +0800, YueHaibing wrote: > On 2019/5/28 22:35, Sven Van Asbroeck wrote: > > On Tue, May 28, 2019 at 10:31 AM YueHaibing wrote: > >> > >> Fix gcc build error while CONFIG_REGMAP_MMIO is not set > >> > > > > checkpatch.pl errors remain: > > > > $ ./scripts/checkpatch.pl < ~/Downloads/YueHaibing.eml > > ERROR: DOS line endings > > #92: FILE: drivers/staging/fieldbus/anybuss/Kconfig:17: > > +^Iselect REGMAP_MMIO^M$ > > This seems text/plain messages have crlf set when saved as .eml file, > > I do check my v2 patch is not crlf ending, but when save as eml file in > > my thunderbird, it becomes crlf ending. You all need a better email client, mutt handles this just fine, it's not a problem on my system with my workflow at all :) So this patch looks fine to me from a formatting point of view. But does it do what it says it does, that's up to Sven... thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 -next] staging: fieldbus: Fix build error without CONFIG_REGMAP_MMIO
On 2019/5/28 22:35, Sven Van Asbroeck wrote: > On Tue, May 28, 2019 at 10:31 AM YueHaibing wrote: >> >> Fix gcc build error while CONFIG_REGMAP_MMIO is not set >> > > checkpatch.pl errors remain: > > $ ./scripts/checkpatch.pl < ~/Downloads/YueHaibing.eml > ERROR: DOS line endings > #92: FILE: drivers/staging/fieldbus/anybuss/Kconfig:17: > +^Iselect REGMAP_MMIO^M$ This seems text/plain messages have crlf set when saved as .eml file, I do check my v2 patch is not crlf ending, but when save as eml file in my thunderbird, it becomes crlf ending. > > total: 1 errors, 0 warnings, 0 checks, 7 lines checked > > ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 -next] staging: fieldbus: Fix build error without CONFIG_REGMAP_MMIO
Sorry, this is broken, Pls igore this.
On 2019/5/28 22:29, YueHaibing wrote:
> Fix gcc build error while CONFIG_REGMAP_MMIO is not set
>
> drivers/staging/fieldbus/anybuss/arcx-anybus.o: In function
> `controller_probe':
> arcx-anybus.c: undefined reference to `__devm_regmap_init_mmio_clk'
>
> Select REGMAP_MMIO to fix it.
>
> Reported-by: Hulk Robot
> Fixes: 2411a336c8ce ("staging: fieldbus: arcx-anybus: change custom -> mmio
> regmap")
> Signed-off-by: YueHaibing
> ---
> v2: fix patch style warning
> ---
> drivers/staging/fieldbus/anybuss/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/fieldbus/anybuss/Kconfig
> b/drivers/staging/fieldbus/anybuss/Kconfig
> index 8bc3d9a..635a0a7 100644
> --- a/drivers/staging/fieldbus/anybuss/Kconfig
> +++ b/drivers/staging/fieldbus/anybuss/Kconfig
> @@ -14,6 +14,7 @@ if HMS_ANYBUSS_BUS
> config ARCX_ANYBUS_CONTROLLER
> tristate "Arcx Anybus-S Controller"
> depends on OF && GPIOLIB && HAS_IOMEM && REGULATOR
> + select REGMAP_MMIO
> help
> Select this to get support for the Arcx Anybus controller.
> It connects to the SoC via a parallel memory bus, and
>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 -next] staging: fieldbus: Fix build error without CONFIG_REGMAP_MMIO
On Tue, May 28, 2019 at 10:31 AM YueHaibing wrote: > > Fix gcc build error while CONFIG_REGMAP_MMIO is not set > checkpatch.pl errors remain: $ ./scripts/checkpatch.pl < ~/Downloads/YueHaibing.eml ERROR: DOS line endings #92: FILE: drivers/staging/fieldbus/anybuss/Kconfig:17: +^Iselect REGMAP_MMIO^M$ total: 1 errors, 0 warnings, 0 checks, 7 lines checked ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 -next] staging: fieldbus: Fix build error without CONFIG_REGMAP_MMIO
Fix gcc build error while CONFIG_REGMAP_MMIO is not set
drivers/staging/fieldbus/anybuss/arcx-anybus.o: In function `controller_probe':
arcx-anybus.c: undefined reference to `__devm_regmap_init_mmio_clk'
Select REGMAP_MMIO to fix it.
Reported-by: Hulk Robot
Fixes: 2411a336c8ce ("staging: fieldbus: arcx-anybus: change custom -> mmio
regmap")
Signed-off-by: YueHaibing
---
v2: fix patch style warning
---
drivers/staging/fieldbus/anybuss/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/fieldbus/anybuss/Kconfig
b/drivers/staging/fieldbus/anybuss/Kconfig
index 8bc3d9a..635a0a7 100644
--- a/drivers/staging/fieldbus/anybuss/Kconfig
+++ b/drivers/staging/fieldbus/anybuss/Kconfig
@@ -14,6 +14,7 @@ if HMS_ANYBUSS_BUS
config ARCX_ANYBUS_CONTROLLER
tristate "Arcx Anybus-S Controller"
depends on OF && GPIOLIB && HAS_IOMEM && REGULATOR
+ select REGMAP_MMIO
help
Select this to get support for the Arcx Anybus controller.
It connects to the SoC via a parallel memory bus, and
--
2.7.4
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
