Re: [PATCH v2 59/60] staging: ced1401: ced_ioc.c fix checkpatch warnings

2014-07-11 Thread Luca Ellero

On 11/07/2014 00:12, Greg KH wrote:

On Thu, Jul 10, 2014 at 11:04:15AM +0200, Luca Ellero wrote:

Signed-off-by: Luca Ellero luca.ell...@brickedbrain.com
---
  drivers/staging/ced1401/ced_ioc.c |  212 +++--
  1 file changed, 131 insertions(+), 81 deletions(-)


That's a lot of changes all in one patch.  Please take these last 4
patches and rework them to be more specific, and to only do one thing
per patch (logical thing, like fixing comments in a file, etc.)  I've
applied all of the other ones in the series, so this should give you an
easier base to work off of.

thanks,

greg k-h



OK, I will rework the patches and resend
regards
Luca


___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel


Re: [PATCH v2 59/60] staging: ced1401: ced_ioc.c fix checkpatch warnings

2014-07-10 Thread Greg KH
On Thu, Jul 10, 2014 at 11:04:15AM +0200, Luca Ellero wrote:
 Signed-off-by: Luca Ellero luca.ell...@brickedbrain.com
 ---
  drivers/staging/ced1401/ced_ioc.c |  212 
 +++--
  1 file changed, 131 insertions(+), 81 deletions(-)

That's a lot of changes all in one patch.  Please take these last 4
patches and rework them to be more specific, and to only do one thing
per patch (logical thing, like fixing comments in a file, etc.)  I've
applied all of the other ones in the series, so this should give you an
easier base to work off of.

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel