Re: [PATCH v3 3/6] imx-drm: imx-ldb: Fix array length

2014-02-26 Thread Russell King - ARM Linux 
On Wed, Feb 26, 2014 at 07:44:33PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam 
> 
> Fix the following static checker warning:
> 
> drivers/staging/imx-drm/imx-ldb.c:340 imx_ldb_get_clk() error: format string 
> overflow. buf_size: 16 length: 18
> probably 18 is theory and not real life, but 16 is based on
> theory as well.

I should've pointed out that there's also:

sprintf(clkname, "di%d_pll", chno);

just below which needs the same treatment.  Sorry.

-- 
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v3 3/6] imx-drm: imx-ldb: Fix array length

2014-02-26 Thread Fabio Estevam 
On Wed, Feb 26, 2014 at 7:44 PM, Fabio Estevam  wrote:
> From: Fabio Estevam 
>
> Fix the following static checker warning:
>
> drivers/staging/imx-drm/imx-ldb.c:340 imx_ldb_get_clk() error: format string 
> overflow. buf_size: 16 length: 18
> probably 18 is theory and not real life, but 16 is based on
> theory as well.
>
> Reported-by: Dan Carpenter 
> Signed-off-by: Fabio Estevam 

Ops, I should have changed the Subject.

Will send a v4 tomorrow.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v3 3/6] imx-drm: imx-ldb: Fix array length

2014-02-26 Thread Fabio Estevam 
From: Fabio Estevam 

Fix the following static checker warning:

drivers/staging/imx-drm/imx-ldb.c:340 imx_ldb_get_clk() error: format string 
overflow. buf_size: 16 length: 18
probably 18 is theory and not real life, but 16 is based on
theory as well.

Reported-by: Dan Carpenter 
Signed-off-by: Fabio Estevam 
---
Changes since v2:
- Use snprintf as suggested by Russell
Changes since v1:
- None

 drivers/staging/imx-drm/imx-ldb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/imx-drm/imx-ldb.c 
b/drivers/staging/imx-drm/imx-ldb.c
index abf8517..195c425 100644
--- a/drivers/staging/imx-drm/imx-ldb.c
+++ b/drivers/staging/imx-drm/imx-ldb.c
@@ -334,7 +334,7 @@ static int imx_ldb_get_clk(struct imx_ldb *ldb, int chno)
 {
char clkname[16];
 
-   sprintf(clkname, "di%d", chno);
+   snprintf(clkname, sizeof(clkname), "di%d", chno);
ldb->clk[chno] = devm_clk_get(ldb->dev, clkname);
if (IS_ERR(ldb->clk[chno]))
return PTR_ERR(ldb->clk[chno]);
-- 
1.8.1.2

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel