Adding led support for phy causes namespace conflicts for some
phy drivers.

The marvel skge driver declared an enum for representing the states of
Link LED Register. The enum contained constant LED_OFF which conflicted
with declartation found in linux/leds.h.
LED_OFF changed to LED_REG_OFF

Signed-off-by: Zach Brown <zach.br...@ni.com>
---
 drivers/net/ethernet/marvell/skge.c | 4 ++--
 drivers/net/ethernet/marvell/skge.h | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/marvell/skge.c 
b/drivers/net/ethernet/marvell/skge.c
index 7173836..ff5a087 100644
--- a/drivers/net/ethernet/marvell/skge.c
+++ b/drivers/net/ethernet/marvell/skge.c
@@ -1062,7 +1062,7 @@ static void skge_link_up(struct skge_port *skge)
 
 static void skge_link_down(struct skge_port *skge)
 {
-       skge_write8(skge->hw, SK_REG(skge->port, LNK_LED_REG), LED_OFF);
+       skge_write8(skge->hw, SK_REG(skge->port, LNK_LED_REG), LED_REG_OFF);
        netif_carrier_off(skge->netdev);
        netif_stop_queue(skge->netdev);
 
@@ -2668,7 +2668,7 @@ static int skge_down(struct net_device *dev)
        if (hw->ports == 1)
                free_irq(hw->pdev->irq, hw);
 
-       skge_write8(skge->hw, SK_REG(skge->port, LNK_LED_REG), LED_OFF);
+       skge_write8(skge->hw, SK_REG(skge->port, LNK_LED_REG), LED_REG_OFF);
        if (is_genesis(hw))
                genesis_stop(skge);
        else
diff --git a/drivers/net/ethernet/marvell/skge.h 
b/drivers/net/ethernet/marvell/skge.h
index a2eb341..ec054d3 100644
--- a/drivers/net/ethernet/marvell/skge.h
+++ b/drivers/net/ethernet/marvell/skge.h
@@ -663,7 +663,7 @@ enum {
        LED_SYNC_ON     = 1<<3, /* Use Sync Wire to switch LED */
        LED_SYNC_OFF    = 1<<2, /* Disable Sync Wire Input */
        LED_ON  = 1<<1, /* switch LED on */
-       LED_OFF = 1<<0, /* switch LED off */
+       LED_REG_OFF     = 1<<0, /* switch LED off */
 };
 
 /* Receive GMAC FIFO (YUKON) */
-- 
2.7.4

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to