Re: Question about patches for bcm
On Thu, Jun 26, 2014 at 04:42:11PM +0200, Matthias Beyer wrote: Hi, I have a question related to some patches I send in. (I send them to de...@driverdev.osuosl.org, but they show up in the archives of this list... so I'm asking here) I send 6 patch sets since the beginning of the month. Some of them where reviewed, some not. None of them is upstream by now. Did something got stuck? If there is no comment that means everyone else approves and Greg has not gotten to them. Normally I review patches when they are sent to the list and comment on some. I have been away so I haven't reviewed all your patches yet. I did some research and found a message in the archives[0] related to the bcm driver. It seems that there is still work in progress on this driver, so I guess my patches are not obsolete, right? I think most places in the world are not using wi-max so this driver is going to be obsolete in 3-5 years but not yet entirely. My second iteration would contain some refactoring of the type / member names, moving headers around, maybe splitting files, etc. Is this okay for you? Yes, that is fine. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: Question about patches for bcm
Argh, I forgot to send the patches. Sorry about that... a lot of stuff is going on here atm. I think it would be best if I start CCing you for all new patchsets I send. So I don't have to resend them all which would probably confuse people ... Hope you're fine with this? -- Mit freundlichen Grüßen, Kind regards, Matthias Beyer Proudly sent with mutt. Happily signed with gnupg. pgpPkdrX5SLuW.pgp Description: PGP signature ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: Question about patches for bcm
On 26-06-2014 10:58:20, Kevin McKinney wrote: On Thu, Jun 26, 2014 at 10:42 AM, Matthias Beyer m...@beyermatthias.de wrote: Hi, I have a question related to some patches I send in. (I send them to de...@driverdev.osuosl.org, but they show up in the archives of this list... so I'm asking here) I send 6 patch sets since the beginning of the month. Some of them where reviewed, some not. None of them is upstream by now. Did something got stuck? I did some research and found a message in the archives[0] related to the bcm driver. It seems that there is still work in progress on this driver, so I guess my patches are not obsolete, right? I have more cleanup patchsets for this driver lying around (about 70 patches overall, ca 1/4 already submitted but not yet applied). I don't want to send all of them at once, as this just leads to confusion (as they are split up into 13 branches/patchsets). I almost patched all files in the driver. My second iteration would contain some refactoring of the type / member names, moving headers around, maybe splitting files, etc. Is this okay for you? Is there someone out there who actively works on the driver? Maybe I could send my patches to this person instead to the ML, so we can sync up our workflow to get this stuff done faster? Hi Matthias, I have been working on this driver for a while now. I am currently fixing a 64 bit casting bug; and I think I have a fix but I trying to get the hardware so I can test. A I believe it has to do with the ntohl function only accepting 32 bit values, and not 64 bit. But I need the hardware in order to test this theory. A We can work together to get this driver completed faster if you like. A I can review your patches? Can you resend your last iteration of patches? A I hope to have the hardware soon, and we can really get some good testing going on. A Hi Kevin, I can send the patches, sure. Shall I send them directly to you or with this ML in CC? Should I send the 6 already submitted patchsets or should I submit all patches I have done so far? I guess you do just reviewing, greg k-h still applies them, right? I do not have the hardware, I do my patches, compile them and run them through checkpatch.pl, but I have no hardware to test. All my patches are just cleanup patches (line shortening, code simplifications, oursourcing of code chunks into functions and the like), I just got into kernel stuff (and I love doing it :-) ). -- Mit freundlichen Grüßen, Kind regards, Matthias Beyer Proudly sent with mutt. Happily signed with gnupg. pgpXcqzXE0oy5.pgp Description: PGP signature ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: Question about patches for bcm
Hi, your email client sends HTML-Emails. Can you switch this off? Maybe that's also the reason why your emails don't show up in the archives[0]! I will send my patches tomorrow, no time now. Regards, Matthias [0]: http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2014-June/thread.html On 26-06-2014 11:11:40, Kevin McKinney wrote: On Thu, Jun 26, 2014 at 11:02 AM, Matthias Beyer m...@beyermatthias.de wrote: On 26-06-2014 10:58:20, Kevin McKinney wrote: A A On Thu, Jun 26, 2014 at 10:42 AM, Matthias Beyer m...@beyermatthias.de A A wrote: A A A Hi, A A A I have a question related to some patches I send in. A A A (I send them to de...@driverdev.osuosl.org, but they show up in the A A A archives of this list... so I'm asking here) A A A I send 6 patch sets since the beginning of the month. Some of them A A A where reviewed, some not. None of them is upstream by now. Did A A A something got stuck? A A A I did some research and found a message in the archives[0] related to A A A the bcm driver. It seems that there is still work in progress on this A A A driver, so I guess my patches are not obsolete, right? A A A I have more cleanup patchsets for this driver lying around (about 70 A A A patches overall, ca 1/4 already submitted but not yet applied). A A A I don't want to send all of them at once, as this just leads to A A A confusion (as they are split up into 13 branches/patchsets). A A A I almost patched all files in the driver. My second iteration would A A A contain some refactoring of the type / member names, moving headers A A A around, maybe splitting files, etc. Is this okay for you? A A A Is there someone out there who actively works on the driver? Maybe I A A A could send my patches to this person instead to the ML, so we can A A A sync up our workflow to get this stuff done faster? A A Hi Matthias, A A I have been working on this driver for a while now. I am currently fixing A A a 64 bit casting bug; and I think I have a fix but I trying to get the A A hardware so I can test. A I believe it has to do with the ntohl function A A only accepting 32 bit values, and not 64 bit. But I need the hardware in A A order to test this theory. A We can work together to get this driver A A completed faster if you like. A I can review your patches? Can you resend A A your last iteration of patches? A I hope to have the hardware soon, and we A A can really get some good testing going on. A A A Hi Kevin, I can send the patches, sure. Shall I send them directly to you or with this ML in CC? Should I send the 6 already submitted patchsets or should I submit all patches I have done so far? Yes, please send to ML and CC me. A I guess you do just reviewing, greg k-h still applies them, right? Yes, Greg always reviews and applies patches. A There are also other reviewers with a lot more experience than me :) A I do not have the hardware, I do my patches, compile them and run them through checkpatch.pl, but I have no hardware to test. All my patches are just cleanup patches (line shortening, code simplifications, oursourcing of code chunks into functions and the like), I just got into kernel stuff (and I love doing it :-) ). That's okay about not having the hardware. A -- Mit freundlichen GrA 1/4A*en, Kind regards, Matthias Beyer Proudly sent with mutt. Happily signed with gnupg. -- Mit freundlichen Grüßen, Kind regards, Matthias Beyer Proudly sent with mutt. Happily signed with gnupg. pgpP1enWdS2Mc.pgp Description: PGP signature ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: Question about patches for bcm
On Thu, Jun 26, 2014 at 11:14 AM, Matthias Beyer m...@beyermatthias.de wrote: Hi, your email client sends HTML-Emails. Can you switch this off? Maybe that's also the reason why your emails don't show up in the archives[0]! Yeh, sorry about that. During the day I use gmail instead of mutt and I forget to turn off HTML emails. I will send my patches tomorrow, no time now. No problem, I typically work in the evenings EST. Regards, Matthias [0]: http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2014-June/thread.html On 26-06-2014 11:11:40, Kevin McKinney wrote: On Thu, Jun 26, 2014 at 11:02 AM, Matthias Beyer m...@beyermatthias.de wrote: On 26-06-2014 10:58:20, Kevin McKinney wrote: A A On Thu, Jun 26, 2014 at 10:42 AM, Matthias Beyer m...@beyermatthias.de A A wrote: A A A Hi, A A A I have a question related to some patches I send in. A A A (I send them to de...@driverdev.osuosl.org, but they show up in the A A A archives of this list... so I'm asking here) A A A I send 6 patch sets since the beginning of the month. Some of them A A A where reviewed, some not. None of them is upstream by now. Did A A A something got stuck? A A A I did some research and found a message in the archives[0] related to A A A the bcm driver. It seems that there is still work in progress on this A A A driver, so I guess my patches are not obsolete, right? A A A I have more cleanup patchsets for this driver lying around (about 70 A A A patches overall, ca 1/4 already submitted but not yet applied). A A A I don't want to send all of them at once, as this just leads to A A A confusion (as they are split up into 13 branches/patchsets). A A A I almost patched all files in the driver. My second iteration would A A A contain some refactoring of the type / member names, moving headers A A A around, maybe splitting files, etc. Is this okay for you? A A A Is there someone out there who actively works on the driver? Maybe I A A A could send my patches to this person instead to the ML, so we can A A A sync up our workflow to get this stuff done faster? A A Hi Matthias, A A I have been working on this driver for a while now. I am currently fixing A A a 64 bit casting bug; and I think I have a fix but I trying to get the A A hardware so I can test. A I believe it has to do with the ntohl function A A only accepting 32 bit values, and not 64 bit. But I need the hardware in A A order to test this theory. A We can work together to get this driver A A completed faster if you like. A I can review your patches? Can you resend A A your last iteration of patches? A I hope to have the hardware soon, and we A A can really get some good testing going on. A A A Hi Kevin, I can send the patches, sure. Shall I send them directly to you or with this ML in CC? Should I send the 6 already submitted patchsets or should I submit all patches I have done so far? Yes, please send to ML and CC me. A I guess you do just reviewing, greg k-h still applies them, right? Yes, Greg always reviews and applies patches. A There are also other reviewers with a lot more experience than me :) A I do not have the hardware, I do my patches, compile them and run them through checkpatch.pl, but I have no hardware to test. All my patches are just cleanup patches (line shortening, code simplifications, oursourcing of code chunks into functions and the like), I just got into kernel stuff (and I love doing it :-) ). That's okay about not having the hardware. A -- Mit freundlichen GrA 1/4A*en, Kind regards, Matthias Beyer Proudly sent with mutt. Happily signed with gnupg. -- Mit freundlichen Grüßen, Kind regards, Matthias Beyer Proudly sent with mutt. Happily signed with gnupg. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
