Re: [PATCH V2 1/7] Drivers: hv: vmbus: Export the vmbus_sendpacket_pagebuffer_ctl()
On Tue, Mar 10, 2015 at 03:05:26PM +, KY Srinivasan wrote: -Original Message- From: Greg KH [mailto:gre...@linuxfoundation.org] Sent: Tuesday, March 10, 2015 12:42 AM To: KY Srinivasan Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; vkuzn...@redhat.com Subject: Re: [PATCH V2 1/7] Drivers: hv: vmbus: Export the vmbus_sendpacket_pagebuffer_ctl() On Fri, Mar 06, 2015 at 11:04:28PM -0800, K. Y. Srinivasan wrote: Export the vmbus_sendpacket_pagebuffer_ctl() interface. Why? Nothing in this patch needs it. Please include this in the patch that needs the symbol, or at least give a hint as to what is going on. As it is, this just looks like a random export for no reason at all :( This will be used by Hyper-V networking driver to optimize signaling on the send path. I wanted these patches committed before I sent the networking patch to David Miller. I implemented the two vmbus APIs for sending messages: 1) vmbus_sendpacket_ctl() 2) vmbus_sendpacket_pagebuffer_ctl() and I forgot to export the second form of the send API in an earlier patch-set that you have already committed. I need both to be exported to for the netvsc patch I have. Then just send it as part of the netvsc patches please. On a different note, upstream Linux is currently broken on Hyper-V and a patch in this set Fixes it: 0002-Drivers-hv-vmbus-Perform-device-register-in-the-per-.patch That should have been pointed out somewhere :) Do you want me to resend this set? Yes, please do. Break it up into two different sets, one for 4.0-final, and one for 4.1-rc1. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
RE: [PATCH V2 1/7] Drivers: hv: vmbus: Export the vmbus_sendpacket_pagebuffer_ctl()
-Original Message- From: Greg KH [mailto:gre...@linuxfoundation.org] Sent: Tuesday, March 10, 2015 12:42 AM To: KY Srinivasan Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; vkuzn...@redhat.com Subject: Re: [PATCH V2 1/7] Drivers: hv: vmbus: Export the vmbus_sendpacket_pagebuffer_ctl() On Fri, Mar 06, 2015 at 11:04:28PM -0800, K. Y. Srinivasan wrote: Export the vmbus_sendpacket_pagebuffer_ctl() interface. Why? Nothing in this patch needs it. Please include this in the patch that needs the symbol, or at least give a hint as to what is going on. As it is, this just looks like a random export for no reason at all :( This will be used by Hyper-V networking driver to optimize signaling on the send path. I wanted these patches committed before I sent the networking patch to David Miller. I implemented the two vmbus APIs for sending messages: 1) vmbus_sendpacket_ctl() 2) vmbus_sendpacket_pagebuffer_ctl() and I forgot to export the second form of the send API in an earlier patch-set that you have already committed. I need both to be exported to for the netvsc patch I have. On a different note, upstream Linux is currently broken on Hyper-V and a patch in this set Fixes it: 0002-Drivers-hv-vmbus-Perform-device-register-in-the-per-.patch Do you want me to resend this set? Regards, K. Y greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
RE: [PATCH V2 1/7] Drivers: hv: vmbus: Export the vmbus_sendpacket_pagebuffer_ctl()
-Original Message- From: Greg KH [mailto:gre...@linuxfoundation.org] Sent: Tuesday, March 10, 2015 8:15 AM To: KY Srinivasan Cc: a...@canonical.com; de...@linuxdriverproject.org; o...@aepfle.de; linux-ker...@vger.kernel.org Subject: Re: [PATCH V2 1/7] Drivers: hv: vmbus: Export the vmbus_sendpacket_pagebuffer_ctl() On Tue, Mar 10, 2015 at 03:05:26PM +, KY Srinivasan wrote: -Original Message- From: Greg KH [mailto:gre...@linuxfoundation.org] Sent: Tuesday, March 10, 2015 12:42 AM To: KY Srinivasan Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; vkuzn...@redhat.com Subject: Re: [PATCH V2 1/7] Drivers: hv: vmbus: Export the vmbus_sendpacket_pagebuffer_ctl() On Fri, Mar 06, 2015 at 11:04:28PM -0800, K. Y. Srinivasan wrote: Export the vmbus_sendpacket_pagebuffer_ctl() interface. Why? Nothing in this patch needs it. Please include this in the patch that needs the symbol, or at least give a hint as to what is going on. As it is, this just looks like a random export for no reason at all :( This will be used by Hyper-V networking driver to optimize signaling on the send path. I wanted these patches committed before I sent the networking patch to David Miller. I implemented the two vmbus APIs for sending messages: 1) vmbus_sendpacket_ctl() 2) vmbus_sendpacket_pagebuffer_ctl() and I forgot to export the second form of the send API in an earlier patch-set that you have already committed. I need both to be exported to for the netvsc patch I have. Then just send it as part of the netvsc patches please. Done. On a different note, upstream Linux is currently broken on Hyper-V and a patch in this set Fixes it: 0002-Drivers-hv-vmbus-Perform-device-register-in-the-per-.patch That should have been pointed out somewhere :) Do you want me to resend this set? Yes, please do. Break it up into two different sets, one for 4.0-final, and one for 4.1-rc1. The upstream issue I noted is only on linux-next being queued up for 4.1-rc1. I will just resubmit the patch-set for your char-misc tree. Thanks, K. Y thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH V2 1/7] Drivers: hv: vmbus: Export the vmbus_sendpacket_pagebuffer_ctl()
On Fri, Mar 06, 2015 at 11:04:28PM -0800, K. Y. Srinivasan wrote: Export the vmbus_sendpacket_pagebuffer_ctl() interface. Why? Nothing in this patch needs it. Please include this in the patch that needs the symbol, or at least give a hint as to what is going on. As it is, this just looks like a random export for no reason at all :( greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
