Re: [PATCH v4] staging: gdm724x: Fix DMA from stack
On Thu, Feb 11, 2021 at 01:28:41PM +, David Laight wrote: > > Stack allocated buffers cannot be used for DMA > > on all architectures so allocate hci_packet buffer > > using kmalloc. > > I wonder if the usb stack ought/could support a short bounce > buffer within the memory is already has to allocate? No. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
RE: [PATCH v4] staging: gdm724x: Fix DMA from stack
> Stack allocated buffers cannot be used for DMA > on all architectures so allocate hci_packet buffer > using kmalloc. I wonder if the usb stack ought/could support a short bounce buffer within the memory is already has to allocate? For hci and lengths less than 8 the immediate data can be placed directly in the ring structure replacing the data pointer itself. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales) ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v4] staging: gdm724x: Fix DMA from stack
On Thu, Feb 11, 2021 at 11:08:19AM +0530, Amey Narkhede wrote: > Stack allocated buffers cannot be used for DMA > on all architectures so allocate hci_packet buffer > using kmalloc. > > Signed-off-by: Amey Narkhede Looks good. Reviewed-by: Dan Carpenter regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
