Re: [lustre-devel] [PATCH] staging: lustre: export cfs_str2mask

[Drokin, Oleg]

On Nov 8, 2015, at 11:34 AM, James Simmons wrote:

> We need cfs_str2mask exported for our server code.
> Even with the server code not available upstream
> it would be nice to use the upstream code on Lustre
> servers.
> 
> Signed-off-by: James Simmons 
> ---
> .../staging/lustre/lustre/libcfs/libcfs_string.c   |1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/libcfs/libcfs_string.c 
> b/drivers/staging/lustre/lustre/libcfs/libcfs_string.c
> index d40be53..05630f8 100644
> --- a/drivers/staging/lustre/lustre/libcfs/libcfs_string.c
> +++ b/drivers/staging/lustre/lustre/libcfs/libcfs_string.c
> @@ -111,6 +111,7 @@ int cfs_str2mask(const char *str, const char 
> *(*bit2str)(int bit),
>   *oldmask = newmask;
>   return 0;
> }
> +EXPORT_SYMBOL(cfs_str2mask);

If this is the case of it being used out of tree, I suspect a comment here to 
that effect would be
useful, otherwise next person running a script to eliminate unused 
EXPORT_SYMBOLs would kill it again.

> 
> /* get the first string out of @str */
> char *cfs_firststr(char *str, size_t size)
> -- 
> 1.7.1
> 
> ___
> lustre-devel mailing list
> lustre-de...@lists.lustre.org
> http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

RE: [lustre-devel] [PATCH] staging: lustre: export cfs_str2mask

[Simmons, James A.]

>> We need cfs_str2mask exported for our server code.
>> Even with the server code not available upstream
>> it would be nice to use the upstream code on Lustre
>> servers.
>> 
>> Signed-off-by: James Simmons 
>> ---
>> .../staging/lustre/lustre/libcfs/libcfs_string.c   |1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>> 
>> diff --git a/drivers/staging/lustre/lustre/libcfs/libcfs_string.c 
>> b/drivers/staging/lustre/lustre/libcfs/libcfs_string.c
>> index d40be53..05630f8 100644
>> --- a/drivers/staging/lustre/lustre/libcfs/libcfs_string.c
>> +++ b/drivers/staging/lustre/lustre/libcfs/libcfs_string.c
>> @@ -111,6 +111,7 @@ int cfs_str2mask(const char *str, const char 
>> *(*bit2str)(int bit),
>>  *oldmask = newmask;
>>  return 0;
>> }
>> +EXPORT_SYMBOL(cfs_str2mask);
>
>If this is the case of it being used out of tree, I suspect a comment here to 
>that effect would be
>useful, otherwise next person running a script to eliminate unused 
>EXPORT_SYMBOLs would kill it again.

I will send another patch with comments not to remove the new code.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel