Re: [Outreachy kernel] [PATCH] staging: vc04_services: fix line over 80 characters checks warning

2019-10-16 Thread Jules Irenge 



On Wed, 16 Oct 2019, Julia Lawall wrote:

> >  #ifndef VCHI_BULK_GRANULARITY
> >  #   if __VCCOREVER__ >= 0x0400
> > -#   define VCHI_BULK_GRANULARITY 32 // Allows for the need to do cache 
> > cleans
> > +#  define VCHI_BULK_GRANULARITY 32 // Allows for the need of cache cleans
> >  #   else
> >  #   define VCHI_BULK_GRANULARITY 16
> >  #   endif
> 
> The branches should be indented to the same degree.
> 
> julia
> 
> -- 

Thanks, I have just  updated. 
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [Outreachy kernel] [PATCH] staging: vc04_services: fix line over 80 characters checks warning

2019-10-15 Thread Julia Lawall 
>  #ifndef VCHI_BULK_GRANULARITY
>  #   if __VCCOREVER__ >= 0x0400
> -#   define VCHI_BULK_GRANULARITY 32 // Allows for the need to do cache 
> cleans
> +#define VCHI_BULK_GRANULARITY 32 // Allows for the need of cache cleans
>  #   else
>  #   define VCHI_BULK_GRANULARITY 16
>  #   endif

The branches should be indented to the same degree.

julia
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel