Re: [PATCH][next] staging: rts5208: Use array_size() helper in vmalloc()

2020-06-16 Thread Gustavo A. R. Silva
On Tue, Jun 16, 2020 at 01:13:12PM +0300, Dan Carpenter wrote:
> On Mon, Jun 15, 2020 at 06:08:11PM -0500, Gustavo A. R. Silva wrote:
> > and memset()
> 
> Please don't start the commit message in the middle of a sentence.  It's
> 

That was, certainly, unintentional. Thanks for letting me know.

--
Gustavo
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel


Re: [PATCH][next] staging: rts5208: Use array_size() helper in vmalloc()

2020-06-16 Thread Dan Carpenter
On Mon, Jun 15, 2020 at 06:08:11PM -0500, Gustavo A. R. Silva wrote:
> and memset()

Please don't start the commit message in the middle of a sentence.  It's
a completely different thing from the title.  When you're reading the
full email then the title is hidden in the headers and the Date: and
Message-ID: field go in between the title and the message body.

https://lore.kernel.org/lkml/20200615230811.GA18818@embeddedor/

I normally read either the title or the body but seldom read both when
I'm reviewing patches.

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel