Re: [PATCH] Staging: comedi: comedi.h Fixed multiple coding style issues

[Ian Abbott]

On 18/11/15 19:23, Daniel H. Hemmingsen wrote:

Fixed multiple comments and spacing coding style issues.

Signed-off-by: Daniel H. Hemmingsen 
---
  drivers/staging/comedi/comedi.h | 307 +++-
  1 file changed, 177 insertions(+), 130 deletions(-)


Thanks!  Although you missed a couple of wrongly formatted comments for 
INSN_CONFIG_GET_HARDWARE_BUFFER_SIZE and INSN_CONFIG_PWM_SET_H_BRIDGE, 
it's a great improvement.


Reviewed-by: Ian Abbott 

--
-=( Ian Abbott @ MEV Ltd.E-mail:  )=-
-=(  Web: http://www.mev.co.uk/  )=-
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

RE: [PATCH] Staging: comedi: comedi.h Fixed multiple coding style issues

[Hartley Sweeten]

On Thursday, November 19, 2015 3:21 AM, Ian Abbott wrote:
> On 18/11/15 19:23, Daniel H. Hemmingsen wrote:
>> Fixed multiple comments and spacing coding style issues.
>>
>> Signed-off-by: Daniel H. Hemmingsen 
>> ---
>>   drivers/staging/comedi/comedi.h | 307 
>> +++-
>>   1 file changed, 177 insertions(+), 130 deletions(-)
>
> Thanks!  Although you missed a couple of wrongly formatted comments for 
> INSN_CONFIG_GET_HARDWARE_BUFFER_SIZE and INSN_CONFIG_PWM_SET_H_BRIDGE, 
> it's a great improvement.
>
> Reviewed-by: Ian Abbott 

There are still a couple block comments that don't follow the kernel
CodingStyle and some minor alignment issues but these can be fixed
later. Overall it looks a lot better and removes most of the checkpatch.pl
issues.

Thanks for the patch.

Reviewed-by: H Hartley Sweeten 

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel