Re: [PATCH] Staging: rtl8192e: dot11d: Fixed coding style issues

[Greg KH]

On Tue, Jun 10, 2014 at 10:33:51PM +0530, Raghavendra wrote:
 Replaced 'printk' with 'netdev_info' and 'netdev_err' wherever necessary.
 Also fixed the coding issue cooresponding to line gap after the declarations.

Please don't do multiple things in the same patch, a single patch should
only do 1 thing.  So break this up into multiple patches.

 Signed-off-by: Raghavendra ar...@cdac.in

I need full name for a signed-off-by: line, please read
Documentation/SubmittingPatches for the details.

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Staging: rtl8192e: dot11d: Fixed coding style issues

[Greg KH]

On Wed, Jun 11, 2014 at 09:25:47AM +0530, A Raghavendra Rao wrote:
 From: Raghavendra ar...@cdac.in
 
 Fixed coding style issues

Which specific coding style issue?  Be exact please.

And don't try to fix more than one type of coding style issue at a
time...

 
 Signed-off-by: A Raghavendra Rao ar...@cdac.in

This name doesn't match the From: line :(

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel