Re: [PATCH] staging: rt8192u: fix sparse warnings in r8192U_core.c

2014-12-02 Thread Greg KH 
On Mon, Dec 01, 2014 at 09:54:45AM +0800, Fred wrote:
 Fixed the following warnings in sparse:
 drivers/staging/rtl8192u/r8192U_core.c:670:6: warning:
   symbol 'dump_eprom' was not declared.
   Should it be static?
 drivers/staging/rtl8192u/r8192U_core.c:1489:5: warning:
   symbol 'ComputeTxTime' was not declared.
   Should it be static?
 drivers/staging/rtl8192u/r8192U_core.c:1556:14: warning:
   symbol 'txqueue2outpipe' was not declared.
   Should it be static?
 drivers/staging/rtl8192u/r8192U_core.c:4876:5: warning:
   symbol 'GetRxPacketShiftBytes819xUsb' was not declared.
   Should it be static?
 
 Signed-off-by: Fred Chou fred.chou...@gmail.com
 ---
  drivers/staging/rtl8192u/r8192U_core.c | 10 ++
  1 file changed, 6 insertions(+), 4 deletions(-)

Your From: line does not match your Signed-off-by: line, so I can't
take this :(

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: rt8192u: fix sparse warnings in r8192U_core.c

2014-12-02 Thread Greg KH 
On Wed, Dec 03, 2014 at 10:31:55AM +0800, Fred Chou wrote:
 From: Fred fred.chou...@gmail.com

One word name, and then:

 Signed-off-by: Fred Chou fred.chou...@gmail.com

Two word name.

Unacceptable, you know this...
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: rt8192u: fix sparse warnings in r8192U_core.c

2014-12-02 Thread Sudip Mukherjee 
On Wed, Dec 03, 2014 at 10:38:27AM +0800, Fred Chou wrote:
 From: Fred Chou fred.chou...@gmail.com
 
 Fixed the following warnings in sparse:
 drivers/staging/rtl8192u/r8192U_core.c:670:6: warning:
   symbol 'dump_eprom' was not declared.
   Should it be static?
 drivers/staging/rtl8192u/r8192U_core.c:1489:5: warning:
   symbol 'ComputeTxTime' was not declared.
   Should it be static?
 drivers/staging/rtl8192u/r8192U_core.c:1556:14: warning:
   symbol 'txqueue2outpipe' was not declared.
   Should it be static?
 drivers/staging/rtl8192u/r8192U_core.c:4876:5: warning:
   symbol 'GetRxPacketShiftBytes819xUsb' was not declared.
   Should it be static?
 
 Signed-off-by: Fred Chou fred.chou...@gmail.com
 ---
  drivers/staging/rtl8192u/r8192U_core.c | 10 ++
  1 file changed, 6 insertions(+), 4 deletions(-)
 
 diff --git a/drivers/staging/rtl8192u/r8192U_core.c 
 b/drivers/staging/rtl8192u/r8192U_core.c
 index 7640386..6b647ad 100644
 --- a/drivers/staging/rtl8192u/r8192U_core.c
 +++ b/drivers/staging/rtl8192u/r8192U_core.c
 @@ -667,7 +667,7 @@ static void tx_timeout(struct net_device *dev)
  
  
  /* this is only for debug */
 -void dump_eprom(struct net_device *dev)
 +static void dump_eprom(struct net_device *dev)
  {
   int i;
   for (i = 0; i  63; i++)
 @@ -1486,7 +1486,7 @@ inline u8 rtl8192_IsWirelessBMode(u16 rate)
  
  u16 N_DBPSOfRate(u16 DataRate);
  
 -u16 ComputeTxTime(u16 FrameLength, u16 DataRate, u8 bManagementFrame,
 +static u16 ComputeTxTime(u16 FrameLength, u16 DataRate, u8 bManagementFrame,
 u8 bShortPreamble)
Alignment should match open parenthesis
  {
   u16 FrameTime;
 @@ -1553,7 +1553,8 @@ u16 N_DBPSOfRate(u16 DataRate)
   return N_DBPS;
  }
  
 -unsigned int txqueue2outpipe(struct r8192_priv *priv, unsigned int tx_queue)
 +static unsigned int txqueue2outpipe(struct r8192_priv *priv,
 + unsigned int tx_queue)
same here also

  {
   if (tx_queue = 9) {
   RT_TRACE(COMP_ERR, %s():Unknown queue ID!!!\n, __func__);
 @@ -4873,7 +4874,8 @@ static void query_rxdesc_status(struct sk_buff *skb,
  
  }
  
 -u32 GetRxPacketShiftBytes819xUsb(struct ieee80211_rx_stats  *Status, bool 
 bIsRxAggrSubframe)
 +static u32 GetRxPacketShiftBytes819xUsb(struct ieee80211_rx_stats  *Status,
 + bool bIsRxAggrSubframe)
and here

thanks
sudip
  {
  #ifdef USB_RX_AGGREGATION_SUPPORT
   if (bIsRxAggrSubframe)
 -- 
 1.9.1
 
 --
 To unsubscribe from this list: send the line unsubscribe linux-kernel in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html
 Please read the FAQ at  http://www.tux.org/lkml/
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel