Re: [PATCH] Staging: rtl8192u: fix sparse warnings in r8192U_core.c

2014-08-07 Thread Antoine Schweitzer-Chaput 
On Thu, Aug 07, 2014 at 10:10:47AM +0530, A Raghavendra Rao wrote:
 Signed-off-by: A Raghavendra Rao ar...@cdac.in

This looks very similar to what I submitted on July 31st.
At this time Greg had additional comments which led to a quite different
patchset (though its review is not completed yet), you may find interesting
to review this whole thread.

Antoine
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: rtl8192u: fix sparse warnings in r8192U_core.c

2014-08-06 Thread Greg KH 
On Wed, Aug 06, 2014 at 02:14:16PM +0530, A Raghavendra Rao wrote:
 Fix the following sparse warnings:
 drivers/staging/rtl8192u/r8192U_core.c:670:6: warning: symbol 'dump_eprom'
 was not declared. Should it be static?
 drivers/staging/rtl8192u/r8192U_core.c:1556:14: warning: symbol
 'txqueue2outpipe' was not declared. Should it be static?
 drivers/staging/rtl8192u/r8192U_core.c:4876:5: warning: symbol
 'GetRxPacketShiftBytes819xUsb' was not declared. Should it be static?
 
 Signed-off-by: A Raghavendra Rao ar...@cdac.in
 ---
  drivers/staging/rtl8192u/r8192U_core.c |8 +---
  1 file changed, 5 insertions(+), 3 deletions(-)

This patch causes warnings to be added to the build, don't do that :(
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel