Re: [PATCH 01/11] staging: greybus: add SPDX identifiers to all greybus driver files
On Tue, Nov 07, 2017 at 02:49:44PM -0700, Mark Greer wrote: > On Tue, Nov 07, 2017 at 02:58:41PM +0100, Greg Kroah-Hartman wrote: > > It's good to have SPDX identifiers in all files to make it easier to > > audit the kernel tree for correct licenses. > > > > Update the drivers/staging/greybus files files with the correct SPDX > > license identifier based on the license text in the file itself. The > > SPDX identifier is a legally binding shorthand, which can be used > > instead of the full boiler plate text. > > > > This work is based on a script and data from Thomas Gleixner, Philippe > > Ombredanne, and Kate Stewart. > > > > Cc: Johan Hovold> > Cc: Alex Elder > > Cc: Greg Kroah-Hartman > > Cc: Vaibhav Hiremath > > Cc: Vaibhav Agarwal > > Cc: Mark Greer > > Cc: Viresh Kumar > > Cc: Rui Miguel Silva > > Cc: David Lin > > Cc: "Bryan O'Donoghue" > > Cc: Thomas Gleixner > > Cc: Kate Stewart > > Cc: Philippe Ombredanne > > Signed-off-by: Greg Kroah-Hartman > > Acked-by: Mark Greer Thanks for the acks. greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 01/11] staging: greybus: add SPDX identifiers to all greybus driver files
On Wed, Nov 08, 2017 at 09:43:01AM +0530, Viresh Kumar wrote: > On 07-11-17, 14:58, Greg Kroah-Hartman wrote: > > It's good to have SPDX identifiers in all files to make it easier to > > audit the kernel tree for correct licenses. > > > > Update the drivers/staging/greybus files files with the correct SPDX > > license identifier based on the license text in the file itself. The > > SPDX identifier is a legally binding shorthand, which can be used > > instead of the full boiler plate text. > > > > This work is based on a script and data from Thomas Gleixner, Philippe > > Ombredanne, and Kate Stewart. > > > > Cc: Johan Hovold> > Cc: Alex Elder > > Cc: Greg Kroah-Hartman > > Cc: Vaibhav Hiremath > > Cc: Vaibhav Agarwal > > Cc: Mark Greer > > Cc: Viresh Kumar > > Cc: Rui Miguel Silva > > Cc: David Lin > > Cc: "Bryan O'Donoghue" > > Cc: Thomas Gleixner > > Cc: Kate Stewart > > Cc: Philippe Ombredanne > > Signed-off-by: Greg Kroah-Hartman > > Acked-by: Viresh Kumar Thanks for the acks. greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 01/11] staging: greybus: add SPDX identifiers to all greybus driver files
On Tue, Nov 07, 2017 at 04:37:06PM +0100, Johan Hovold wrote: > On Tue, Nov 07, 2017 at 02:58:41PM +0100, Greg Kroah-Hartman wrote: > > It's good to have SPDX identifiers in all files to make it easier to > > audit the kernel tree for correct licenses. > > > > Update the drivers/staging/greybus files files with the correct SPDX > > license identifier based on the license text in the file itself. The > > SPDX identifier is a legally binding shorthand, which can be used > > instead of the full boiler plate text. > > > > This work is based on a script and data from Thomas Gleixner, Philippe > > Ombredanne, and Kate Stewart. > > > > Cc: Johan Hovold> > Cc: Alex Elder > > Cc: Greg Kroah-Hartman > > Cc: Vaibhav Hiremath > > Cc: Vaibhav Agarwal > > Cc: Mark Greer > > Cc: Viresh Kumar > > Cc: Rui Miguel Silva > > Cc: David Lin > > Cc: "Bryan O'Donoghue" > > Cc: Thomas Gleixner > > Cc: Kate Stewart > > Cc: Philippe Ombredanne > > Signed-off-by: Greg Kroah-Hartman > > Acked-by: Johan Hovold Thanks for the acks. greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 01/11] staging: greybus: add SPDX identifiers to all greybus driver files
On Tue, Nov 07, 2017 at 08:51:37PM -0800, David Lin wrote: > On Tue, Nov 7, 2017 at 5:58 AM, Greg Kroah-Hartman >wrote: > > It's good to have SPDX identifiers in all files to make it easier to > > audit the kernel tree for correct licenses. > > > > Update the drivers/staging/greybus files files with the correct SPDX > > license identifier based on the license text in the file itself. The > > SPDX identifier is a legally binding shorthand, which can be used > > instead of the full boiler plate text. > > > > This work is based on a script and data from Thomas Gleixner, Philippe > > Ombredanne, and Kate Stewart. > > > > Cc: Johan Hovold > > Cc: Alex Elder > > Cc: Greg Kroah-Hartman > > Cc: Vaibhav Hiremath > > Cc: Vaibhav Agarwal > > Cc: Mark Greer > > Cc: Viresh Kumar > > Cc: Rui Miguel Silva > > Cc: David Lin > > Cc: "Bryan O'Donoghue" > > Cc: Thomas Gleixner > > Cc: Kate Stewart > > Cc: Philippe Ombredanne > > Signed-off-by: Greg Kroah-Hartman > > Acked-by: David Lin Thanks for the acks. greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 01/11] staging: greybus: add SPDX identifiers to all greybus driver files
On Tue, Nov 7, 2017 at 7:28 PM, Greg Kroah-Hartmanwrote: > It's good to have SPDX identifiers in all files to make it easier to > audit the kernel tree for correct licenses. > > Update the drivers/staging/greybus files files with the correct SPDX > license identifier based on the license text in the file itself. The > SPDX identifier is a legally binding shorthand, which can be used > instead of the full boiler plate text. > > This work is based on a script and data from Thomas Gleixner, Philippe > Ombredanne, and Kate Stewart. > > Cc: Johan Hovold > Cc: Alex Elder > Cc: Greg Kroah-Hartman > Cc: Vaibhav Hiremath > Cc: Vaibhav Agarwal > Cc: Mark Greer > Cc: Viresh Kumar > Cc: Rui Miguel Silva > Cc: David Lin > Cc: "Bryan O'Donoghue" > Cc: Thomas Gleixner > Cc: Kate Stewart > Cc: Philippe Ombredanne > Signed-off-by: Greg Kroah-Hartman > --- Acked-by: Vaibhav Agarwal -- vaibhav ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 01/11] staging: greybus: add SPDX identifiers to all greybus driver files
On Tue, Nov 7, 2017 at 5:58 AM, Greg Kroah-Hartmanwrote: > It's good to have SPDX identifiers in all files to make it easier to > audit the kernel tree for correct licenses. > > Update the drivers/staging/greybus files files with the correct SPDX > license identifier based on the license text in the file itself. The > SPDX identifier is a legally binding shorthand, which can be used > instead of the full boiler plate text. > > This work is based on a script and data from Thomas Gleixner, Philippe > Ombredanne, and Kate Stewart. > > Cc: Johan Hovold > Cc: Alex Elder > Cc: Greg Kroah-Hartman > Cc: Vaibhav Hiremath > Cc: Vaibhav Agarwal > Cc: Mark Greer > Cc: Viresh Kumar > Cc: Rui Miguel Silva > Cc: David Lin > Cc: "Bryan O'Donoghue" > Cc: Thomas Gleixner > Cc: Kate Stewart > Cc: Philippe Ombredanne > Signed-off-by: Greg Kroah-Hartman Acked-by: David Lin ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 01/11] staging: greybus: add SPDX identifiers to all greybus driver files
On 07-11-17, 14:58, Greg Kroah-Hartman wrote: > It's good to have SPDX identifiers in all files to make it easier to > audit the kernel tree for correct licenses. > > Update the drivers/staging/greybus files files with the correct SPDX > license identifier based on the license text in the file itself. The > SPDX identifier is a legally binding shorthand, which can be used > instead of the full boiler plate text. > > This work is based on a script and data from Thomas Gleixner, Philippe > Ombredanne, and Kate Stewart. > > Cc: Johan Hovold> Cc: Alex Elder > Cc: Greg Kroah-Hartman > Cc: Vaibhav Hiremath > Cc: Vaibhav Agarwal > Cc: Mark Greer > Cc: Viresh Kumar > Cc: Rui Miguel Silva > Cc: David Lin > Cc: "Bryan O'Donoghue" > Cc: Thomas Gleixner > Cc: Kate Stewart > Cc: Philippe Ombredanne > Signed-off-by: Greg Kroah-Hartman Acked-by: Viresh Kumar -- viresh ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 01/11] staging: greybus: add SPDX identifiers to all greybus driver files
On Tue, Nov 07, 2017 at 02:58:41PM +0100, Greg Kroah-Hartman wrote: > It's good to have SPDX identifiers in all files to make it easier to > audit the kernel tree for correct licenses. > > Update the drivers/staging/greybus files files with the correct SPDX > license identifier based on the license text in the file itself. The > SPDX identifier is a legally binding shorthand, which can be used > instead of the full boiler plate text. > > This work is based on a script and data from Thomas Gleixner, Philippe > Ombredanne, and Kate Stewart. > > Cc: Johan Hovold> Cc: Alex Elder > Cc: Greg Kroah-Hartman > Cc: Vaibhav Hiremath > Cc: Vaibhav Agarwal > Cc: Mark Greer > Cc: Viresh Kumar > Cc: Rui Miguel Silva > Cc: David Lin > Cc: "Bryan O'Donoghue" > Cc: Thomas Gleixner > Cc: Kate Stewart > Cc: Philippe Ombredanne > Signed-off-by: Greg Kroah-Hartman Acked-by: Mark Greer ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 01/11] staging: greybus: add SPDX identifiers to all greybus driver files
On Tue, Nov 07, 2017 at 02:58:41PM +0100, Greg Kroah-Hartman wrote: > It's good to have SPDX identifiers in all files to make it easier to > audit the kernel tree for correct licenses. > > Update the drivers/staging/greybus files files with the correct SPDX > license identifier based on the license text in the file itself. The > SPDX identifier is a legally binding shorthand, which can be used > instead of the full boiler plate text. > > This work is based on a script and data from Thomas Gleixner, Philippe > Ombredanne, and Kate Stewart. > > Cc: Johan Hovold> Cc: Alex Elder > Cc: Greg Kroah-Hartman > Cc: Vaibhav Hiremath > Cc: Vaibhav Agarwal > Cc: Mark Greer > Cc: Viresh Kumar > Cc: Rui Miguel Silva > Cc: David Lin > Cc: "Bryan O'Donoghue" > Cc: Thomas Gleixner > Cc: Kate Stewart > Cc: Philippe Ombredanne > Signed-off-by: Greg Kroah-Hartman Acked-by: Johan Hovold ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 01/11] staging: greybus: add SPDX identifiers to all greybus driver files
Hi Greg, On Tue 07 Nov 2017 at 13:58, Greg Kroah-Hartmanwrote: > It's good to have SPDX identifiers in all files to make it easier to > audit the kernel tree for correct licenses. > > Update the drivers/staging/greybus files files with the correct SPDX > license identifier based on the license text in the file itself. The > SPDX identifier is a legally binding shorthand, which can be used > instead of the full boiler plate text. > > This work is based on a script and data from Thomas Gleixner, Philippe > Ombredanne, and Kate Stewart. > > Cc: Johan Hovold > Cc: Alex Elder > Cc: Greg Kroah-Hartman > Cc: Vaibhav Hiremath > Cc: Vaibhav Agarwal > Cc: Mark Greer > Cc: Viresh Kumar > Cc: Rui Miguel Silva > Cc: David Lin > Cc: "Bryan O'Donoghue" > Cc: Thomas Gleixner > Cc: Kate Stewart > Cc: Philippe Ombredanne > Signed-off-by: Greg Kroah-Hartman > --- Acked-by: Rui Miguel Silva Cheers, Rui > drivers/staging/greybus/Documentation/firmware/authenticate.c | 1 + > drivers/staging/greybus/Documentation/firmware/firmware.c | 1 + > drivers/staging/greybus/arche-apb-ctrl.c | 1 + > drivers/staging/greybus/arche-platform.c | 1 + > drivers/staging/greybus/arche_platform.h | 1 + > drivers/staging/greybus/arpc.h| 1 + > drivers/staging/greybus/audio_apbridgea.c | 1 + > drivers/staging/greybus/audio_apbridgea.h | 1 + > drivers/staging/greybus/audio_codec.c | 1 + > drivers/staging/greybus/audio_codec.h | 1 + > drivers/staging/greybus/audio_gb.c| 1 + > drivers/staging/greybus/audio_manager.c | 1 + > drivers/staging/greybus/audio_manager.h | 1 + > drivers/staging/greybus/audio_manager_module.c| 1 + > drivers/staging/greybus/audio_manager_private.h | 1 + > drivers/staging/greybus/audio_manager_sysfs.c | 1 + > drivers/staging/greybus/audio_module.c| 1 + > drivers/staging/greybus/audio_topology.c | 1 + > drivers/staging/greybus/authentication.c | 1 + > drivers/staging/greybus/bootrom.c | 1 + > drivers/staging/greybus/bundle.c | 1 + > drivers/staging/greybus/bundle.h | 1 + > drivers/staging/greybus/camera.c | 1 + > drivers/staging/greybus/connection.c | 1 + > drivers/staging/greybus/connection.h | 1 + > drivers/staging/greybus/control.c | 1 + > drivers/staging/greybus/control.h | 1 + > drivers/staging/greybus/core.c| 1 + > drivers/staging/greybus/debugfs.c | 1 + > drivers/staging/greybus/es2.c | 1 + > drivers/staging/greybus/firmware.h| 1 + > drivers/staging/greybus/fw-core.c | 1 + > drivers/staging/greybus/fw-download.c | 1 + > drivers/staging/greybus/fw-management.c | 1 + > drivers/staging/greybus/gb-camera.h | 1 + > drivers/staging/greybus/gbphy.c | 1 + > drivers/staging/greybus/gbphy.h | 1 + > drivers/staging/greybus/gpio.c| 1 + > drivers/staging/greybus/greybus.h | 1 + > drivers/staging/greybus/greybus_authentication.h | 1 + > drivers/staging/greybus/greybus_firmware.h| 1 + > drivers/staging/greybus/greybus_manifest.h| 1 + > drivers/staging/greybus/greybus_protocols.h | 1 + > drivers/staging/greybus/greybus_trace.h | 1 + > drivers/staging/greybus/hd.c | 1 + > drivers/staging/greybus/hd.h | 1 + > drivers/staging/greybus/hid.c | 1 + > drivers/staging/greybus/i2c.c | 1 + > drivers/staging/greybus/interface.c | 1 + > drivers/staging/greybus/interface.h | 1 + > drivers/staging/greybus/light.c | 1 + > drivers/staging/greybus/log.c | 1 + >
Re: [PATCH 01/11] staging: greybus: add SPDX identifiers to all greybus driver files
On 11/07/2017 08:47 AM, Greg Kroah-Hartman wrote: > On Tue, Nov 07, 2017 at 08:42:07AM -0600, Alex Elder wrote: >> On 11/07/2017 07:58 AM, Greg Kroah-Hartman wrote: >>> It's good to have SPDX identifiers in all files to make it easier to >>> audit the kernel tree for correct licenses. >>> >>> Update the drivers/staging/greybus files files with the correct SPDX >>> license identifier based on the license text in the file itself. The >>> SPDX identifier is a legally binding shorthand, which can be used >>> instead of the full boiler plate text. >>> >>> This work is based on a script and data from Thomas Gleixner, Philippe >>> Ombredanne, and Kate Stewart. >> >> Looks good. Except... Why the C++ style comment? (Use /* */ not //?) > > That's the "style" that Linus wanted, it stands out, right? :) Yes it does. I'm very happy to see SPDX getting deployed. -Alex > > thanks for the review. > > greg k-h > ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 01/11] staging: greybus: add SPDX identifiers to all greybus driver files
On 11/07/2017 07:58 AM, Greg Kroah-Hartman wrote: > It's good to have SPDX identifiers in all files to make it easier to > audit the kernel tree for correct licenses. > > Update the drivers/staging/greybus files files with the correct SPDX > license identifier based on the license text in the file itself. The > SPDX identifier is a legally binding shorthand, which can be used > instead of the full boiler plate text. > > This work is based on a script and data from Thomas Gleixner, Philippe > Ombredanne, and Kate Stewart. Looks good. Except... Why the C++ style comment? (Use /* */ not //?) Otherwise: Reviewed-by: Alex Elder> > Cc: Johan Hovold > Cc: Alex Elder > Cc: Greg Kroah-Hartman > Cc: Vaibhav Hiremath > Cc: Vaibhav Agarwal > Cc: Mark Greer > Cc: Viresh Kumar > Cc: Rui Miguel Silva > Cc: David Lin > Cc: "Bryan O'Donoghue" > Cc: Thomas Gleixner > Cc: Kate Stewart > Cc: Philippe Ombredanne > Signed-off-by: Greg Kroah-Hartman > --- > drivers/staging/greybus/Documentation/firmware/authenticate.c | 1 + > drivers/staging/greybus/Documentation/firmware/firmware.c | 1 + > drivers/staging/greybus/arche-apb-ctrl.c | 1 + > drivers/staging/greybus/arche-platform.c | 1 + > drivers/staging/greybus/arche_platform.h | 1 + > drivers/staging/greybus/arpc.h| 1 + > drivers/staging/greybus/audio_apbridgea.c | 1 + > drivers/staging/greybus/audio_apbridgea.h | 1 + > drivers/staging/greybus/audio_codec.c | 1 + > drivers/staging/greybus/audio_codec.h | 1 + > drivers/staging/greybus/audio_gb.c| 1 + > drivers/staging/greybus/audio_manager.c | 1 + > drivers/staging/greybus/audio_manager.h | 1 + > drivers/staging/greybus/audio_manager_module.c| 1 + > drivers/staging/greybus/audio_manager_private.h | 1 + > drivers/staging/greybus/audio_manager_sysfs.c | 1 + > drivers/staging/greybus/audio_module.c| 1 + > drivers/staging/greybus/audio_topology.c | 1 + > drivers/staging/greybus/authentication.c | 1 + > drivers/staging/greybus/bootrom.c | 1 + > drivers/staging/greybus/bundle.c | 1 + > drivers/staging/greybus/bundle.h | 1 + > drivers/staging/greybus/camera.c | 1 + > drivers/staging/greybus/connection.c | 1 + > drivers/staging/greybus/connection.h | 1 + > drivers/staging/greybus/control.c | 1 + > drivers/staging/greybus/control.h | 1 + > drivers/staging/greybus/core.c| 1 + > drivers/staging/greybus/debugfs.c | 1 + > drivers/staging/greybus/es2.c | 1 + > drivers/staging/greybus/firmware.h| 1 + > drivers/staging/greybus/fw-core.c | 1 + > drivers/staging/greybus/fw-download.c | 1 + > drivers/staging/greybus/fw-management.c | 1 + > drivers/staging/greybus/gb-camera.h | 1 + > drivers/staging/greybus/gbphy.c | 1 + > drivers/staging/greybus/gbphy.h | 1 + > drivers/staging/greybus/gpio.c| 1 + > drivers/staging/greybus/greybus.h | 1 + > drivers/staging/greybus/greybus_authentication.h | 1 + > drivers/staging/greybus/greybus_firmware.h| 1 + > drivers/staging/greybus/greybus_manifest.h| 1 + > drivers/staging/greybus/greybus_protocols.h | 1 + > drivers/staging/greybus/greybus_trace.h | 1 + > drivers/staging/greybus/hd.c | 1 + > drivers/staging/greybus/hd.h | 1 + > drivers/staging/greybus/hid.c | 1 + > drivers/staging/greybus/i2c.c | 1 + > drivers/staging/greybus/interface.c | 1 + > drivers/staging/greybus/interface.h | 1 + > drivers/staging/greybus/light.c | 1 + > drivers/staging/greybus/log.c
Re: [PATCH 01/11] staging: greybus: add SPDX identifiers to all greybus driver files
On Tue, Nov 07, 2017 at 08:42:07AM -0600, Alex Elder wrote: > On 11/07/2017 07:58 AM, Greg Kroah-Hartman wrote: > > It's good to have SPDX identifiers in all files to make it easier to > > audit the kernel tree for correct licenses. > > > > Update the drivers/staging/greybus files files with the correct SPDX > > license identifier based on the license text in the file itself. The > > SPDX identifier is a legally binding shorthand, which can be used > > instead of the full boiler plate text. > > > > This work is based on a script and data from Thomas Gleixner, Philippe > > Ombredanne, and Kate Stewart. > > Looks good. Except... Why the C++ style comment? (Use /* */ not //?) That's the "style" that Linus wanted, it stands out, right? :) thanks for the review. greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel