Re: [PATCH 08/44] kernel: Move pm_power_off to common code

2014-10-13 Thread Hirokazu TAKATA 
From: Guenter Roeck li...@roeck-us.net
  arch/m32r/kernel/process.c |  8 

Acked-by: Hirokazu Takata tak...@linux-m32r.org

Thank you.

-- takata
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 08/44] kernel: Move pm_power_off to common code

2014-10-10 Thread Guenter Roeck 

On 10/09/2014 01:24 PM, Pavel Machek wrote:

Hi!


@@ -184,6 +179,8 @@ machine_halt(void)
  void
  machine_power_off(void)
  {
+   do_kernel_poweroff();
+


poweroff - power_off for consistency.


Dunno; matter of personal preference. I started with that, but ultimately went
with poweroff to distinguish poweroff handler functions from existing code,
specifically kernel_power_off().


That works for you, but once it is merged, it is ugly/confusing typo.
Pavel



Ok, no problem, I'll change it.

Guenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 08/44] kernel: Move pm_power_off to common code

2014-10-09 Thread Vineet Gupta 
On Tuesday 07 October 2014 11:01 AM, Guenter Roeck wrote:

diff --git a/arch/arc/kernel/reset.c b/arch/arc/kernel/reset.c
index 2768fa1..8a4fc47 100644
--- a/arch/arc/kernel/reset.c
+++ b/arch/arc/kernel/reset.c
@@ -26,9 +26,6 @@ void machine_restart(char *__unused)

 void machine_power_off(void)
 {
-   /* FIXME ::  power off ??? */
+   do_kernel_poweroff();
machine_halt();
 }
-
-void (*pm_power_off) (void) = NULL;
-EXPORT_SYMBOL(pm_power_off);

Acked-by: Vineet Gupta vgu...@synopsys.commailto:vgu...@synopsys.com

Thx,
-Vineet
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 08/44] kernel: Move pm_power_off to common code

2014-10-09 Thread Catalin Marinas 
On Tue, Oct 07, 2014 at 06:28:10AM +0100, Guenter Roeck wrote:
 diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c
 index e0ef8ba..db396bb 100644
 --- a/arch/arm64/kernel/process.c
 +++ b/arch/arm64/kernel/process.c
 @@ -94,8 +94,6 @@ void soft_restart(unsigned long addr)
  /*
   * Function pointers to optional machine specific functions
   */
 -void (*pm_power_off)(void);
 -EXPORT_SYMBOL_GPL(pm_power_off);
 
  void (*arm_pm_restart)(enum reboot_mode reboot_mode, const char *cmd);
 
 @@ -155,8 +153,7 @@ void machine_power_off(void)
  {
 local_irq_disable();
 smp_send_stop();
 -   if (pm_power_off)
 -   pm_power_off();
 +   do_kernel_poweroff();
  }

Acked-by: Catalin Marinas catalin.mari...@arm.com
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 08/44] kernel: Move pm_power_off to common code

2014-10-09 Thread Pavel Machek 
Hi!

 @@ -184,6 +179,8 @@ machine_halt(void)
  void
  machine_power_off(void)
  {
 + do_kernel_poweroff();
 +

poweroff - power_off for consistency.


 index c4f50a3..1da27d1 100644
 --- a/arch/blackfin/kernel/reboot.c
 +++ b/arch/blackfin/kernel/reboot.c
 @@ -106,6 +107,7 @@ void machine_halt(void)
  __attribute__((weak))
  void native_machine_power_off(void)
  {
 + do_kernel_poweroff();
   idle_with_irq_disabled();
  }


So here we handle do_kernel_poweroff() returning,

 diff --git a/arch/cris/kernel/process.c b/arch/cris/kernel/process.c
 index b78498e..eaafad0 100644
 --- a/arch/cris/kernel/process.c
 +++ b/arch/cris/kernel/process.c
 @@ -60,6 +57,7 @@ void machine_halt(void)
  
  void machine_power_off(void)
  {
 + do_kernel_poweroff();
  }



Here we don't.

 diff --git a/arch/frv/kernel/process.c b/arch/frv/kernel/process.c
 index 5d40aeb77..a673725 100644
 --- a/arch/frv/kernel/process.c
 +++ b/arch/frv/kernel/process.c
 @@ -107,6 +104,8 @@ void machine_power_off(void)
   gdbstub_exit(0);
  #endif
  
 + do_kernel_poweroff();
 +
   for (;;);
  }
  

And here we do.

What is right?
Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) 
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 08/44] kernel: Move pm_power_off to common code

2014-10-09 Thread Guenter Roeck 

On 10/09/2014 03:38 AM, Pavel Machek wrote:

Hi!


@@ -184,6 +179,8 @@ machine_halt(void)
  void
  machine_power_off(void)
  {
+   do_kernel_poweroff();
+


poweroff - power_off for consistency.


Dunno; matter of personal preference. I started with that, but ultimately went
with poweroff to distinguish poweroff handler functions from existing code,
specifically kernel_power_off().

Does anyone else have an opinion ?




index c4f50a3..1da27d1 100644
--- a/arch/blackfin/kernel/reboot.c
+++ b/arch/blackfin/kernel/reboot.c
@@ -106,6 +107,7 @@ void machine_halt(void)
  __attribute__((weak))
  void native_machine_power_off(void)
  {
+   do_kernel_poweroff();
idle_with_irq_disabled();
  }



So here we handle do_kernel_poweroff() returning,


diff --git a/arch/cris/kernel/process.c b/arch/cris/kernel/process.c
index b78498e..eaafad0 100644
--- a/arch/cris/kernel/process.c
+++ b/arch/cris/kernel/process.c
@@ -60,6 +57,7 @@ void machine_halt(void)

  void machine_power_off(void)
  {
+   do_kernel_poweroff();
  }




Here we don't.


diff --git a/arch/frv/kernel/process.c b/arch/frv/kernel/process.c
index 5d40aeb77..a673725 100644
--- a/arch/frv/kernel/process.c
+++ b/arch/frv/kernel/process.c
@@ -107,6 +104,8 @@ void machine_power_off(void)
gdbstub_exit(0);
  #endif

+   do_kernel_poweroff();
+
for (;;);
  }



And here we do.

What is right?
Pavel


Up to the architecture maintainer to decide. My goal was to not change
existing behavior if no poweroff handler is registered.

Guenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 08/44] kernel: Move pm_power_off to common code

2014-10-09 Thread Pavel Machek 
Hi!

 @@ -184,6 +179,8 @@ machine_halt(void)
   void
   machine_power_off(void)
   {
 +   do_kernel_poweroff();
 +
 
 poweroff - power_off for consistency.
 
 Dunno; matter of personal preference. I started with that, but ultimately went
 with poweroff to distinguish poweroff handler functions from existing code,
 specifically kernel_power_off().

That works for you, but once it is merged, it is ugly/confusing typo.
Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) 
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 08/44] kernel: Move pm_power_off to common code

2014-10-08 Thread Jesper Nilsson 
On Tue, Oct 07, 2014 at 07:28:10AM +0200, Guenter Roeck wrote:
 pm_power_off is defined for all architectures. Move it to common code.
 
 Have all architectures call do_kernel_poweroff instead of pm_power_off.
 Some architectures point pm_power_off to machine_power_off. For those,
 call do_kernel_poweroff from machine_power_off instead.

For the CRIS parts:

  arch/cris/kernel/process.c |  4 +---

Acked-by: Jesper Nilsson jesper.nils...@axis.com


/^JN - Jesper Nilsson
-- 
   Jesper Nilsson -- jesper.nils...@axis.com
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 08/44] kernel: Move pm_power_off to common code

2014-10-07 Thread Geert Uytterhoeven 
On Tue, Oct 7, 2014 at 7:28 AM, Guenter Roeck li...@roeck-us.net wrote:
 pm_power_off is defined for all architectures. Move it to common code.

 Have all architectures call do_kernel_poweroff instead of pm_power_off.
 Some architectures point pm_power_off to machine_power_off. For those,
 call do_kernel_poweroff from machine_power_off instead.

  arch/m68k/kernel/process.c |  6 +-

Acked-by: Geert Uytterhoeven ge...@linux-m68k.org

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say programmer or something like that.
-- Linus Torvalds
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 08/44] kernel: Move pm_power_off to common code

2014-10-07 Thread Richard Weinberger 
Am 07.10.2014 07:28, schrieb Guenter Roeck:
  arch/um/kernel/reboot.c|  2 --

Acked-by: Richard Weinberger rich...@nod.at

Thanks,
//richard
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel