Re: [PATCH 1/1] staging: imx-drm: Remove unused variable
On 26 May 2014 23:03, Greg KH gre...@linuxfoundation.org wrote: On Mon, May 26, 2014 at 02:28:44PM +0530, Sachin Kamat wrote: 'ret' is not used in the function. Remove it. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/staging/imx-drm/imx-tve.c |1 - 1 file changed, 1 deletion(-) This doesn't apply properly to my tree, can you refresh it against the latest staging-next branch of my staging.git tree and resend it? Seems like this patch is no longer required on the latest staging-next and could be dropped. Sorry for the noise. -- With warm regards, Sachin ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 1/1] staging: imx-drm: Remove unused variable
On Mon, May 26, 2014 at 02:28:44PM +0530, Sachin Kamat wrote: 'ret' is not used in the function. Remove it. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/staging/imx-drm/imx-tve.c |1 - 1 file changed, 1 deletion(-) This doesn't apply properly to my tree, can you refresh it against the latest staging-next branch of my staging.git tree and resend it? thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 1/1] staging: imx-drm: remove unused variable
On Wed, Feb 12, 2014 at 02:47:39PM +0530, Sachin Kamat wrote: Silences the following warning: drivers/staging/imx-drm/imx-drm-core.c: In function ‘imx_drm_driver_unload’: drivers/staging/imx-drm/imx-drm-core.c:87:25: warning: unused variable ‘imxdrm’ [-Wunused-variable] Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Sascha Hauer s.ha...@pengutronix.de --- drivers/staging/imx-drm/imx-drm-core.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/imx-drm/imx-drm-core.c b/drivers/staging/imx-drm/imx-drm-core.c index 236ed66..573fe88 100644 --- a/drivers/staging/imx-drm/imx-drm-core.c +++ b/drivers/staging/imx-drm/imx-drm-core.c @@ -84,8 +84,6 @@ static void imx_drm_driver_lastclose(struct drm_device *drm) static int imx_drm_driver_unload(struct drm_device *drm) { - struct imx_drm_device *imxdrm = drm-dev_private; - Please see the mailing list archives for why this patch has already been rejected 3-4 times by now... thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel