Re: [PATCH 10/10] added kernel build, configuration, and TODO files
On Mon, Nov 03, 2014 at 01:24:04PM -0800, Greg KH wrote: On Mon, Nov 03, 2014 at 12:42:57PM -0800, Stephanie Wallick wrote: --- /dev/null +++ b/drivers/staging/mausb/TODO @@ -0,0 +1,14 @@ +TODO: +- checkpatch.pl cleanups Is this still true? checkpatch.pl reports: total: 7 errors, 208 warnings, 10489 lines checked And why does this need to be a staging driver? What's wrong with making it a real driver now? The short answer is: We don't think it's ready to be real. We didn't want to release it as a real driver because: - It's not stable enough yet. - It doesn't implement all the features required by the MA USB spec. - The MA USB spec isn't standalone. It requires a supplemental spec to define media-specific behavior, like how MA USB packets are encapsulated, how to discover MA USB devices on a network, etc. So far, no media-specific specifications have been published. - There are no commercially-available Media Agnostic USB devices. We wanted to release it to staging now because: - We have received requests from multiple companies for our host MA USB driver. Putting it in staging seemed the best way to distribute it. - We feel that releasing what we have to staging now could promote collaboration on one driver help prevent duplicate work. +- address miscellaneous TODO statements in code +- add support for multiple media agnostic (MA) devices +- add/improve support for unimplemented packet types +- handle errors and failure with more grace and less crash + +Please send patches to Greg Kroah-Hartman g...@kroah.com and cc: You didn't use this email address... +Sean Stalley sean.stal...@intel.com +Stephanie Wallick stephanie.s.wall...@intel.com + Just make a MAINTAINERS entry please for this info. We will include a MAINTAINERS entry in our next patch in lieu of emails (especially incorrect emails) in the TODO. Thanks, Sean ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 10/10] added kernel build, configuration, and TODO files
On Tue, Nov 04, 2014 at 09:55:19AM -0800, sostalle wrote: On Mon, Nov 03, 2014 at 01:24:04PM -0800, Greg KH wrote: On Mon, Nov 03, 2014 at 12:42:57PM -0800, Stephanie Wallick wrote: --- /dev/null +++ b/drivers/staging/mausb/TODO @@ -0,0 +1,14 @@ +TODO: + - checkpatch.pl cleanups Is this still true? checkpatch.pl reports: total: 7 errors, 208 warnings, 10489 lines checked Ok, fair enough. And why does this need to be a staging driver? What's wrong with making it a real driver now? The short answer is: We don't think it's ready to be real. We didn't want to release it as a real driver because: - It's not stable enough yet. - It doesn't implement all the features required by the MA USB spec. - The MA USB spec isn't standalone. It requires a supplemental spec to define media-specific behavior, like how MA USB packets are encapsulated, how to discover MA USB devices on a network, etc. So far, no media-specific specifications have been published. - There are no commercially-available Media Agnostic USB devices. We wanted to release it to staging now because: - We have received requests from multiple companies for our host MA USB driver. Putting it in staging seemed the best way to distribute it. - We feel that releasing what we have to staging now could promote collaboration on one driver help prevent duplicate work. Ok, please include that information in the first email, it's much more helpful :) Can you resend this series, and cc: the linux-usb mailing list, and address the what about usbip? questions as well? thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 10/10] added kernel build, configuration, and TODO files
On Mon, Nov 03, 2014 at 12:42:57PM -0800, Stephanie Wallick wrote: --- /dev/null +++ b/drivers/staging/mausb/drivers/Makefile @@ -0,0 +1,20 @@ +#MY_CFLAGS =-g -O0 -DEBUG_OUTPUT Please remove that line, it's not ever to be used. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 10/10] added kernel build, configuration, and TODO files
On Mon, Nov 03, 2014 at 12:42:57PM -0800, Stephanie Wallick wrote: --- /dev/null +++ b/drivers/staging/mausb/TODO @@ -0,0 +1,14 @@ +TODO: + - checkpatch.pl cleanups Is this still true? And why does this need to be a staging driver? What's wrong with making it a real driver now? + - address miscellaneous TODO statements in code + - add support for multiple media agnostic (MA) devices + - add/improve support for unimplemented packet types + - handle errors and failure with more grace and less crash + +Please send patches to Greg Kroah-Hartman g...@kroah.com and cc: You didn't use this email address... + Sean Stalley sean.stal...@intel.com + Stephanie Wallick stephanie.s.wall...@intel.com + Just make a MAINTAINERS entry please for this info. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
