Re: [PATCH RFC 02/17] staging: dgap: Merge dgap_fep5.h into dgap_driver.h
On Wed, Feb 12, 2014 at 02:29:55PM -0500, Mark Hounschell wrote: > On 02/12/2014 02:15 PM, Greg Kroah-Hartman wrote: > > On Wed, Feb 12, 2014 at 02:00:01PM -0500, Mark Hounschell wrote: > >> On 02/12/2014 01:40 PM, Greg Kroah-Hartman wrote: > >>> On Wed, Feb 12, 2014 at 12:46:31PM -0500, Mark Hounschell wrote: > Merge dgap_fep5.h into dgap_driver.h > > Signed-off-by: Mark Hounschell > Cc: Greg Kroah-Hartman > >>> > >>> Same here, why merge these files? > >>> > >> > >> There is a lot of cleanup work to do on these digi drivers and it will > >> make it easier. I also notice that many merged drivers are single source > >> and header. I thought it was the right thing to do. > > > > Ok, that's great, but say that in the changelog comment :) > > > > Care to redo the series, with a bit better changelog comments so I can > > apply them to the tree? > > > > OK, I will redo the series. Should I go ahead and fix the trailing space > issue for patch 04? Should I wait for more comments also? Go ahead and fix that and redo the series, I wouldn't wait for any more comments just yet. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH RFC 02/17] staging: dgap: Merge dgap_fep5.h into dgap_driver.h
On 02/12/2014 02:15 PM, Greg Kroah-Hartman wrote: > On Wed, Feb 12, 2014 at 02:00:01PM -0500, Mark Hounschell wrote: >> On 02/12/2014 01:40 PM, Greg Kroah-Hartman wrote: >>> On Wed, Feb 12, 2014 at 12:46:31PM -0500, Mark Hounschell wrote: Merge dgap_fep5.h into dgap_driver.h Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman >>> >>> Same here, why merge these files? >>> >> >> There is a lot of cleanup work to do on these digi drivers and it will >> make it easier. I also notice that many merged drivers are single source >> and header. I thought it was the right thing to do. > > Ok, that's great, but say that in the changelog comment :) > > Care to redo the series, with a bit better changelog comments so I can > apply them to the tree? > OK, I will redo the series. Should I go ahead and fix the trailing space issue for patch 04? Should I wait for more comments also? Thanks Mark ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH RFC 02/17] staging: dgap: Merge dgap_fep5.h into dgap_driver.h
On Wed, Feb 12, 2014 at 02:00:01PM -0500, Mark Hounschell wrote: > On 02/12/2014 01:40 PM, Greg Kroah-Hartman wrote: > > On Wed, Feb 12, 2014 at 12:46:31PM -0500, Mark Hounschell wrote: > >> Merge dgap_fep5.h into dgap_driver.h > >> > >> Signed-off-by: Mark Hounschell > >> Cc: Greg Kroah-Hartman > > > > Same here, why merge these files? > > > > There is a lot of cleanup work to do on these digi drivers and it will > make it easier. I also notice that many merged drivers are single source > and header. I thought it was the right thing to do. Ok, that's great, but say that in the changelog comment :) Care to redo the series, with a bit better changelog comments so I can apply them to the tree? thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH RFC 02/17] staging: dgap: Merge dgap_fep5.h into dgap_driver.h
On 02/12/2014 01:40 PM, Greg Kroah-Hartman wrote: > On Wed, Feb 12, 2014 at 12:46:31PM -0500, Mark Hounschell wrote: >> Merge dgap_fep5.h into dgap_driver.h >> >> Signed-off-by: Mark Hounschell >> Cc: Greg Kroah-Hartman > > Same here, why merge these files? > There is a lot of cleanup work to do on these digi drivers and it will make it easier. I also notice that many merged drivers are single source and header. I thought it was the right thing to do. Regards Mark ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH RFC 02/17] staging: dgap: Merge dgap_fep5.h into dgap_driver.h
On Wed, Feb 12, 2014 at 12:46:31PM -0500, Mark Hounschell wrote: > Merge dgap_fep5.h into dgap_driver.h > > Signed-off-by: Mark Hounschell > Cc: Greg Kroah-Hartman Same here, why merge these files? thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
