Re: [PATCH v1] staging: rts5208: Change fixed function names with "%s: ", __func__

[Greg KH]

On Mon, Jul 17, 2017 at 08:19:45PM +0530, Gaurav Pathak wrote:
> staging: rts5208: Fix coding style issue caught by checkpatch.pl related to
> function name in debug print and shorten few lines over 80 char

No, only do one-type-of-thing per patch.  It would make sense to maybe
fix an 80 char line issue for a line you are fixing up for the function
name, but not for any other random line.

Please break this up into individual patches.

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v1] staging: rts5208: Change fixed function names with "%s: ", __func__

[Greg KH]

On Fri, Jul 14, 2017 at 07:38:43PM +0530, Gaurav Pathak wrote:
> staging: rts5208: Refactored code to avoid few defects.

That's the subject line, why repeat it here?

Please put a "real" description of the patch here.

> 
> Signed-off-by: Gaurav Pathak 
> ---
> Hi, Gaurav hope this text appaers in the email, and i put it at the right 
> place in patch.

You did, but why are you writing to yourself?

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel