Re: [PATCH v2] Staging: fbtft: Fix GPIO handling

[Nicolas Saenz Julienne]

On Thu, 2019-07-25 at 09:21 +0200, Greg KH wrote:
> On Wed, Jul 17, 2019 at 11:41:37PM +0900, Jan Sebastian Götte wrote:
> > Commit c440eee1a7a1 ("Staging: fbtft: Switch to the gpio descriptor
> > interface") breaks GPIO handling. In several places, checks to only set
> > a GPIO if it was configured ended up backwards.
> > I have tested this fix. The fixed driver works with a ili9486
> > display connected to a raspberry pi via SPI.
> > 
> > Fixes: commit c440eee1a7a1d ("Staging: fbtft: Switch to the gpio descriptor
> > interface")
> > Tested-by: Jan Sebastian Götte 
> > Reviewed-by: Nicolas Saenz Julienne 
> > Signed-off-by: Jan Sebastian Götte 
> > ---
> 
> Can this go on top of Phil's patches?  Or does it replace it?

This is needed on top of Phil patches.

Regards,
Nicolas



signature.asc
Description: This is a digitally signed message part
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2] Staging: fbtft: Fix GPIO handling

[Greg KH]

On Wed, Jul 17, 2019 at 11:41:37PM +0900, Jan Sebastian Götte wrote:
> Commit c440eee1a7a1 ("Staging: fbtft: Switch to the gpio descriptor
> interface") breaks GPIO handling. In several places, checks to only set
> a GPIO if it was configured ended up backwards.
> I have tested this fix. The fixed driver works with a ili9486
> display connected to a raspberry pi via SPI.
> 
> Fixes: commit c440eee1a7a1d ("Staging: fbtft: Switch to the gpio descriptor 
> interface")
> Tested-by: Jan Sebastian Götte 
> Reviewed-by: Nicolas Saenz Julienne 
> Signed-off-by: Jan Sebastian Götte 
> ---

Can this go on top of Phil's patches?  Or does it replace it?

I can't figure out what to do here, sorry.

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel