Re: [PATCH v2 1/2] staging: dgnc: driver.c: fixes warning about assigning pointer

2013-08-20 Thread Greg KH
On Tue, Aug 20, 2013 at 02:15:35PM -0400, Lidza Louina wrote:
 This patch fixes a warning associated with assigining
 a pointer in the dgnc_mbuf function.
 
 Signed-off-by: Lidza Louina lidza.lou...@gmail.com
 ---
  drivers/staging/dgnc/dgnc_driver.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

As we can't build this driver yet, can you also send in the patch adding
the driver to the build, so that we can verify patches like this, and so
that the build system can kick in and start notifying you of any
potential problems it finds?

Otherwise, you might miss the 3.12 merge window to have this driver
enabled, and I don't want to have a driver in Linus's tree that can't be
built at all, that doesn't make sense.

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel


Re: [PATCH v2 1/2] staging: dgnc: driver.c: fixes warning about assigning pointer

2013-08-20 Thread Lidza Louina
Ok, I'm sending it now.

On Tue, Aug 20, 2013 at 7:27 PM, Greg KH gre...@linuxfoundation.org wrote:
 On Tue, Aug 20, 2013 at 02:15:35PM -0400, Lidza Louina wrote:
 This patch fixes a warning associated with assigining
 a pointer in the dgnc_mbuf function.

 Signed-off-by: Lidza Louina lidza.lou...@gmail.com
 ---
  drivers/staging/dgnc/dgnc_driver.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

 As we can't build this driver yet, can you also send in the patch adding
 the driver to the build, so that we can verify patches like this, and so
 that the build system can kick in and start notifying you of any
 potential problems it finds?

 Otherwise, you might miss the 3.12 merge window to have this driver
 enabled, and I don't want to have a driver in Linus's tree that can't be
 built at all, that doesn't make sense.

 thanks,

 greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel