Re: [RESEND PATCH v5] drivers: most: add USB adapter driver
On Wed, 2020-07-29 at 16:27 +0200, Greg KH wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > On Mon, Jul 27, 2020 at 10:30:46AM +0200, Christian Gromm wrote: > > This patch adds the usb driver source file most_usb.c and > > modifies the Makefile and Kconfig accordingly. > > > > Signed-off-by: Christian Gromm > > Sorry for the long delay in getting to this. > > This looks good to me, but I tried to apply it to my usb tree, and of > course I get the following build error: > error: the following would cause module name conflict: > drivers/staging/most/usb/most_usb.ko > drivers/most/most_usb.ko > > So, can you just send a "rename the file" patch that I can apply > against > my staging-next branch and I will take it through there so that there > are no conflicts like this? Are you talking about (1) a patch that just renames the most_usb.ko file located at drivers/staging/most/usb/ or (2) a patch for the Makefile in the staging tree, so the Kbuild system creates a new kernel object in this branch with a different name? thank, Chris ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [RESEND PATCH v5] drivers: most: add USB adapter driver
On Wed, Jul 29, 2020 at 02:53:29PM +, christian.gr...@microchip.com wrote: > On Wed, 2020-07-29 at 16:27 +0200, Greg KH wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you > > know the content is safe > > > > On Mon, Jul 27, 2020 at 10:30:46AM +0200, Christian Gromm wrote: > > > This patch adds the usb driver source file most_usb.c and > > > modifies the Makefile and Kconfig accordingly. > > > > > > Signed-off-by: Christian Gromm > > > > Sorry for the long delay in getting to this. > > > > This looks good to me, but I tried to apply it to my usb tree, and of > > course I get the following build error: > > error: the following would cause module name conflict: > > drivers/staging/most/usb/most_usb.ko > > drivers/most/most_usb.ko > > > > So, can you just send a "rename the file" patch that I can apply > > against > > my staging-next branch and I will take it through there so that there > > are no conflicts like this? > > Are you talking about (1) a patch that just renames the most_usb.ko > file located at drivers/staging/most/usb/ or (2) a patch for the > Makefile in the staging tree, so the Kbuild system creates a new > kernel object in this branch with a different name? (1) is easiest, do it all at once :) thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [RESEND PATCH v5] drivers: most: add USB adapter driver
On Mon, Jul 27, 2020 at 10:30:46AM +0200, Christian Gromm wrote: > This patch adds the usb driver source file most_usb.c and > modifies the Makefile and Kconfig accordingly. > > Signed-off-by: Christian Gromm Sorry for the long delay in getting to this. This looks good to me, but I tried to apply it to my usb tree, and of course I get the following build error: error: the following would cause module name conflict: drivers/staging/most/usb/most_usb.ko drivers/most/most_usb.ko So, can you just send a "rename the file" patch that I can apply against my staging-next branch and I will take it through there so that there are no conflicts like this? thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [RESEND PATCH v5] drivers: most: add USB adapter driver
On Mon, 2020-07-27 at 07:59 -0700, Randy Dunlap wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > Hi-- > > On 7/27/20 1:30 AM, Christian Gromm wrote: > > This patch adds the usb driver source file most_usb.c and > > modifies the Makefile and Kconfig accordingly. > > > > Signed-off-by: Christian Gromm > > --- > > > > drivers/most/Kconfig| 12 + > > drivers/most/Makefile |2 + > > drivers/most/most_usb.c | 1170 > > +++ > > 3 files changed, 1184 insertions(+) > > create mode 100644 drivers/most/most_usb.c > > > > diff --git a/drivers/most/Kconfig b/drivers/most/Kconfig > > index 58d7999..7b65320 100644 > > --- a/drivers/most/Kconfig > > +++ b/drivers/most/Kconfig > > @@ -13,3 +13,15 @@ menuconfig MOST > > module will be called most_core. > > > > If in doubt, say N here. > > + > > +if MOST > > +config MOST_USB_HDM > > + tristate "USB" > > + depends on USB && NET > > + help > > + Say Y here if you want to connect via USB to network > > transceiver. > > + This device depends on the networking AIM. > > What does that last sentence above mean? Nothing. This dependency is obsolete and needs to be removed. I'll fix this up. thanks, Chris ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [RESEND PATCH v5] drivers: most: add USB adapter driver
Hi-- On 7/27/20 1:30 AM, Christian Gromm wrote: > This patch adds the usb driver source file most_usb.c and > modifies the Makefile and Kconfig accordingly. > > Signed-off-by: Christian Gromm > --- > > drivers/most/Kconfig| 12 + > drivers/most/Makefile |2 + > drivers/most/most_usb.c | 1170 > +++ > 3 files changed, 1184 insertions(+) > create mode 100644 drivers/most/most_usb.c > > diff --git a/drivers/most/Kconfig b/drivers/most/Kconfig > index 58d7999..7b65320 100644 > --- a/drivers/most/Kconfig > +++ b/drivers/most/Kconfig > @@ -13,3 +13,15 @@ menuconfig MOST > module will be called most_core. > > If in doubt, say N here. > + > +if MOST > +config MOST_USB_HDM > + tristate "USB" > + depends on USB && NET > + help > + Say Y here if you want to connect via USB to network transceiver. > + This device driver depends on the networking AIM. What does that last sentence above mean? > + > + To compile this driver as a module, choose M here: the > + module will be called most_usb. > +endif thanks. -- ~Randy ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
