Re: Send a large patch right now or is it better to do it later?
On Fri, Jul 28, 2017 at 05:16:56PM +0200, Marcus Wolf wrote: > Hi Greg, > > according to the proposals of Walter Harms, I revised the rf69.c: I replaced > some macros with inline functions and removed some obsolete ifdefs. According > to > walter this will improve the resource situation. In addition the readybility > is > enhanced, since lines got shorter. It's a quite big change, that touched > nearly > every function in that file. > I was testing the new code for a while now and did not observer a problem so > far. But I don't have a kind of unit test, so my tests for sure didn't cover > everything. > > Is it a good time, to submit such a change in these days, or is it prefrable > to > submit it later? > In adition, I am a bit afraid of my current mailtool doing something > unexpected... You can send patches anytime, don't worry about timing, I can handle putting them in the correct patch queue. > P.S. Can you process diffs fom SVN, too, or is it mandatory to create the diff > with git? As long as it is in normal patch format, I can apply it. Personally, I use quilt to generate patche, which uses 'diff', and that works just fine. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: Send a large patch right now or is it better to do it later?
On Fri, Jul 28, 2017 at 05:16:56PM +0200, Marcus Wolf wrote: > Hi Greg, > > according to the proposals of Walter Harms, I revised the rf69.c: I replaced > some macros with inline functions and removed some obsolete ifdefs. According > to > walter this will improve the resource situation. In addition the readybility > is > enhanced, since lines got shorter. It's a quite big change, that touched > nearly > every function in that file. Just send your patches, we can't discuss them without seeing them. > I was testing the new code for a while now and did not observer a problem so > far. But I don't have a kind of unit test, so my tests for sure didn't cover > everything. Any sort of testing is probably better than 70% of staging patches. :P > > Is it a good time, to submit such a change in these days, or is it prefrable > to > submit it later? It doesn't matter when you send patches. > In adition, I am a bit afraid of my current mailtool doing something > unexpected... > > If you like, I can give it a try! > > Cheers, > > Marcus > P.S. Can you process diffs fom SVN, too, or is it mandatory to create the diff > with git? The patches have to be able to be applied with `cat email.txt | git am`. If you're renaming or moving files, then use git diff. Otherwise it's all fine. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Send a large patch right now or is it better to do it later?
Hi Greg, according to the proposals of Walter Harms, I revised the rf69.c: I replaced some macros with inline functions and removed some obsolete ifdefs. According to walter this will improve the resource situation. In addition the readybility is enhanced, since lines got shorter. It's a quite big change, that touched nearly every function in that file. I was testing the new code for a while now and did not observer a problem so far. But I don't have a kind of unit test, so my tests for sure didn't cover everything. Is it a good time, to submit such a change in these days, or is it prefrable to submit it later? In adition, I am a bit afraid of my current mailtool doing something unexpected... If you like, I can give it a try! Cheers, Marcus P.S. Can you process diffs fom SVN, too, or is it mandatory to create the diff with git? ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
