Re: TODO advice for octeon-usb?

[Greg Kroah-Hartman]

On Tue, May 21, 2019 at 02:05:32AM +0300, Aaro Koskinen wrote:
> Hi,
> 
> I'm looking for input what should be done next to get
> drivers/staging/octeon-usb out of staging.
> 
> Thousands of checkpatch errors/warnings have been fixed (starting point
> was ),
> also the size of the driver has shrunken considerably.
> 
> If there are still some other bigger issues with this driver, please
> let me know.

Submit it as a patch that just adds the files to the drivers/usb/host/
directory so we can review it on linux-usb@vger and if it gets accepted,
I can then drop it from the staging directory, or just move it over if
no changes are needed.

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: TODO advice for octeon-usb?

[Felipe Balbi]

Hi,

Aaro Koskinen  writes:
> I'm looking for input what should be done next to get
> drivers/staging/octeon-usb out of staging.
>
> Thousands of checkpatch errors/warnings have been fixed (starting point
> was ),
> also the size of the driver has shrunken considerably.
>
> If there are still some other bigger issues with this driver, please
> let me know.

Looks pretty clean to me. I would simply break that single file into
smaller files if possible (see xhci/ehci for example).

my 2 cents

-- 
balbi


signature.asc
Description: PGP signature
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

TODO advice for octeon-usb?

[Aaro Koskinen]

Hi,

I'm looking for input what should be done next to get
drivers/staging/octeon-usb out of staging.

Thousands of checkpatch errors/warnings have been fixed (starting point
was ),
also the size of the driver has shrunken considerably.

If there are still some other bigger issues with this driver, please
let me know.

Thanks,

A.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel