RE: [PATCH 8/8] staging: fsl-mc: Convert documentation to rst format
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Tuesday, January 16, 2018 5:14 PM > To: Bogdan Purcareata <bogdan.purcare...@nxp.com> > Cc: Laurentiu Tudor <laurentiu.tu...@nxp.com>; Ruxandra Ioana Ciocoi > Radulescu <ruxandra.radule...@nxp.com>; de...@driverdev.osuosl.org; > r...@kernel.org; stuyo...@gmail.com; a...@arndb.de; > marc.zyng...@arm.com; Roy Pledge <roy.ple...@nxp.com>; Ioana Ciornei > <ioana.cior...@nxp.com>; linux-ker...@vger.kernel.org; Horia Geantă > <horia.gea...@nxp.com>; Nipun Gupta <nipun.gu...@nxp.com>; > t...@linutronix.de; linux-arm-ker...@lists.infradead.org; > ja...@lakedaemon.net > Subject: Re: [PATCH 8/8] staging: fsl-mc: Convert documentation to rst > format > > On Tue, Jan 16, 2018 at 03:19:10PM +0200, Bogdan Purcareata wrote: > > From: Ioana Radulescu <ruxandra.radule...@nxp.com> > > > > Update the doc file to comply with the rst format. > > > > It's not integrated into the documentation build structure yet, > > since it's still located in drivers/staging. > > > > Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com> > > Reviewed-by: Laurentiu Tudor <laurentiu.tu...@nxp.com> > > --- > > drivers/staging/fsl-mc/README.txt | 387 > > -- > > drivers/staging/fsl-mc/overview.rst | 404 > > > 2 files changed, 404 insertions(+), 387 deletions(-) > > delete mode 100644 drivers/staging/fsl-mc/README.txt > > create mode 100644 drivers/staging/fsl-mc/overview.rst > > Please generate patches with the -M option to git format-patch, so we > can see the file move, not just get removed and added as a brand new > one. Sure, I can do this. Even with -M, the diff is rather large since the indenting changes for most of the lines in the file. Would it be better to make two patches, with the first changing just line indenting and the second one, where the file is moved, only updating rst specific markups? Thanks, Ioana ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
RE: [PATCH 5/5] staging: fsl-mc/dpio: Remove dead code
> -Original Message- > From: Ruxandra Ioana Ciocoi Radulescu > Sent: Tuesday, March 6, 2018 7:44 PM > To: gre...@linuxfoundation.org > Cc: de...@driverdev.osuosl.org; linux-ker...@vger.kernel.org; Roy Pledge > <roy.ple...@nxp.com>; Laurentiu Tudor <laurentiu.tu...@nxp.com> > Subject: [PATCH 5/5] staging: fsl-mc/dpio: Remove dead code > > Function qbman_pull_desc_set_token() is not used at all, so remove it. > > Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com> > --- > drivers/staging/fsl-mc/bus/dpio/qbman-portal.c | 5 - > 1 file changed, 5 deletions(-) Hi Greg, Please ignore this patch, I've just noticed you already applied another patch with the same content a couple of hours ago. Thanks, Ioana ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
RE: [PATCH 2/9] staging: fsl-dpaa2/eth: Move print message
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Friday, March 23, 2018 5:01 PM > To: Ruxandra Ioana Ciocoi Radulescu <ruxandra.radule...@nxp.com> > Cc: de...@driverdev.osuosl.org; linux-ker...@vger.kernel.org > Subject: Re: [PATCH 2/9] staging: fsl-dpaa2/eth: Move print message > > On Fri, Mar 23, 2018 at 08:44:06AM -0500, Ioana Radulescu wrote: > > Let the driver remove() function print an informative message > > after it finishes removing the network interface, not at an > > arbitrary point during cleanup. > > > > Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com> > > --- > > drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c > b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c > > index beb5959..9fb88f2 100644 > > --- a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c > > +++ b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c > > @@ -2550,7 +2550,6 @@ static int dpaa2_eth_remove(struct > fsl_mc_device *ls_dev) > > priv = netdev_priv(net_dev); > > > > unregister_netdev(net_dev); > > - dev_info(net_dev->dev.parent, "Removed interface %s\n", > net_dev->name); > > > > if (priv->do_link_poll) > > kthread_stop(priv->poll_thread); > > @@ -2571,6 +2570,8 @@ static int dpaa2_eth_remove(struct > fsl_mc_device *ls_dev) > > dev_set_drvdata(dev, NULL); > > free_netdev(net_dev); > > > > + dev_info(net_dev->dev.parent, "Removed interface %s\n", > net_dev->name); > > Why is this even needed? I'll take it but spamming kernel logs for no > reason is not a good idea :) Fair point, should I make it dev_dbg instead? Thanks, Ioana ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
RE: [PATCH 4/4] staging: fsl-dpaa2/eth: allow the driver to compile multi-arch
-Original Message- From: Greg KH [mailto:gre...@linuxfoundation.org] Sent: Thursday, March 1, 2018 6:32 PM To: Ruxandra Ioana Ciocoi Radulescu <ruxandra.radule...@nxp.com> Cc: de...@driverdev.osuosl.org; Roy Pledge <roy.ple...@nxp.com>; Bogdan Purcareata <bogdan.purcare...@nxp.com>; linux-ker...@vger.kernel.org; Laurentiu Tudor <laurentiu.tu...@nxp.com> Subject: Re: [PATCH 4/4] staging: fsl-dpaa2/eth: allow the driver to compile multi-arch On Mon, Feb 26, 2018 at 10:28:07AM -0600, Ioana Radulescu wrote: > Drop dependency on ARCH_LAYERSCAPE (which in turn depends on ARM64), > thus allowing this driver to compile on all architectures supported by > the fsl-mc bus driver. > > This was compile tested on: > - powerpc (corenet_basic_defconfig, ppc64_defconfig) > - x86 (i386_defconfig, x86_64_defconfig, needs CONFIG_OF) > - arm64 (defconfig) Seems you need to compile it on more things, based on the kbuild warnings :( Yes I do, sorry for the slip :( I've added allmodconfig and the sparse endianness flag to my list of tests. Will send a v2 early next week. Thanks, Ioana ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
