[Dspace-devel] [DSJ] Commented: (DS-691) file size math in the mets:file template in General-Handler.xsl (XMLUI) is incorrect
[ http://jira.dspace.org/jira/browse/DS-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=11751#action_11751 ] Tim Donohue commented on DS-691: +1 to the patch, and to keeping the KB/MB/GB suffixes. I worry that other suffixes would just be confusing as they are not used frequently at all -- and, for example, Windows uses KB for 2^10 bytes, rather than KiB. Not to say that Windows always does things correctly, but it's probably best to try to avoid to much confusion :) file size math in the mets:file template in General-Handler.xsl (XMLUI) is incorrect Key: DS-691 URL: http://jira.dspace.org/jira/browse/DS-691 Project: DSpace 1.x Issue Type: Bug Components: XMLUI Affects Versions: 1.6.2 Environment: all environments Reporter: Hardy Pottinger Assignee: Kim Shepherd Priority: Minor Attachments: corrected_file_size_math.patch Original Estimate: 1 minute Remaining Estimate: 1 minute This is a little nit-picky, but every time I open up the General-Handler.xsl, to look for code to copy/paste to my theme, the math error has bugged me, so, here's a patch to fix it. There are 1024 bytes in a KB, 1048576 bytes in a MB, and 1073741824 bytes in a GB. The current metric numbers are incorrect, and inflate the file sizes displayed by the XMLUI. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.dspace.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira -- Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today. http://p.sf.net/sfu/beautyoftheweb ___ Dspace-devel mailing list Dspace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dspace-devel
[Dspace-devel] [DSJ] Commented: (DS-691) file size math in the mets:file template in General-Handler.xsl (XMLUI) is incorrect
[ http://jira.dspace.org/jira/browse/DS-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=11747#action_11747 ] Kim Shepherd commented on DS-691: - I've talked to a few people about the suffixes, and the general conclusion seems to be this will just confuse users, as a standard it hasn't really caught on with the general Internet population, so keep KB/MB/GB in the default i18n messages and individual repositories can customise as per their requirements. We should document this change somehow/somewhere, so that repository managers aren't confused by all their files suddenly looking slightly smaller. It's going to take a while for this to come up in a JIRA review, and the patch looks good to me and has had +3 votes already... if there aren't any objections in the next 24 hours, I'll commit Hardy's patch as is on the weekend. If the suffix issue becomes controversial, we can commit that as a separate change to the language packs. Sound good? file size math in the mets:file template in General-Handler.xsl (XMLUI) is incorrect Key: DS-691 URL: http://jira.dspace.org/jira/browse/DS-691 Project: DSpace 1.x Issue Type: Bug Components: XMLUI Affects Versions: 1.6.2 Environment: all environments Reporter: Hardy Pottinger Assignee: Kim Shepherd Priority: Minor Attachments: corrected_file_size_math.patch Original Estimate: 1 minute Remaining Estimate: 1 minute This is a little nit-picky, but every time I open up the General-Handler.xsl, to look for code to copy/paste to my theme, the math error has bugged me, so, here's a patch to fix it. There are 1024 bytes in a KB, 1048576 bytes in a MB, and 1073741824 bytes in a GB. The current metric numbers are incorrect, and inflate the file sizes displayed by the XMLUI. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.dspace.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira -- Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today. http://p.sf.net/sfu/beautyoftheweb ___ Dspace-devel mailing list Dspace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dspace-devel
[Dspace-devel] [DSJ] Commented: (DS-691) file size math in the mets:file template in General-Handler.xsl (XMLUI) is incorrect
[ http://jira.dspace.org/jira/browse/DS-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=11732#action_11732 ] Tim Donohue commented on DS-691: +1 as well. Thanks for the patch, Hardy. file size math in the mets:file template in General-Handler.xsl (XMLUI) is incorrect Key: DS-691 URL: http://jira.dspace.org/jira/browse/DS-691 Project: DSpace 1.x Issue Type: Bug Components: XMLUI Affects Versions: 1.6.2 Environment: all environments Reporter: Hardy Pottinger Assignee: Kim Shepherd Priority: Minor Attachments: corrected_file_size_math.patch Original Estimate: 1 minute Remaining Estimate: 1 minute This is a little nit-picky, but every time I open up the General-Handler.xsl, to look for code to copy/paste to my theme, the math error has bugged me, so, here's a patch to fix it. There are 1024 bytes in a KB, 1048576 bytes in a MB, and 1073741824 bytes in a GB. The current metric numbers are incorrect, and inflate the file sizes displayed by the XMLUI. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.dspace.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira -- Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today. http://p.sf.net/sfu/beautyoftheweb ___ Dspace-devel mailing list Dspace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dspace-devel
[Dspace-devel] [DSJ] Commented: (DS-691) file size math in the mets:file template in General-Handler.xsl (XMLUI) is incorrect
[ http://jira.dspace.org/jira/browse/DS-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=11736#action_11736 ] Hardy Pottinger commented on DS-691: I wouldn't have a problem with the default messages.xml changing to follow IEC specs. Though, I would be very likely to override that in our institution's repository, as kilo, mega and giga are still common usage to describe 2^10, 2^20 and 2^30 bytes, Mac OSX 1.6 notwithstanding. :-) file size math in the mets:file template in General-Handler.xsl (XMLUI) is incorrect Key: DS-691 URL: http://jira.dspace.org/jira/browse/DS-691 Project: DSpace 1.x Issue Type: Bug Components: XMLUI Affects Versions: 1.6.2 Environment: all environments Reporter: Hardy Pottinger Assignee: Kim Shepherd Priority: Minor Attachments: corrected_file_size_math.patch Original Estimate: 1 minute Remaining Estimate: 1 minute This is a little nit-picky, but every time I open up the General-Handler.xsl, to look for code to copy/paste to my theme, the math error has bugged me, so, here's a patch to fix it. There are 1024 bytes in a KB, 1048576 bytes in a MB, and 1073741824 bytes in a GB. The current metric numbers are incorrect, and inflate the file sizes displayed by the XMLUI. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.dspace.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira -- Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today. http://p.sf.net/sfu/beautyoftheweb ___ Dspace-devel mailing list Dspace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dspace-devel
