Re: [dwm] Cycle urgent windows patch for dwm-4.9

2008-04-05 Thread Martin Oppegaard 
On Tue, Apr 01, 2008 at 08:22:27PM -0400, Jeremy O'Brien wrote:
 On Sun, Mar 30, 2008 at 03:01:15PM +0200, Martin Oppegaard wrote:
  Have updated the patch for mercurial tip.
  I also add a patch which implements one layout per tag. Haven't looked
  at the old one, so I can't say if it's an update or not.
  
 
 Hi there. I tried your cycleurgent patch, and I like it alot. Only one
 minor problem. It won't cycle if you are on an empty tag. Not sure if
 that was intended or not, and I understand people won't typically be on
 a blank tag, but I figured you'd want to know for robustness and
 whatnot. Thank you.
 
Indeed it is a design feature. Not hard to change, tho, which I will do
while I fix a real bug I found with having mutiple tags selected.

Re: [dwm] Monocle question

2008-04-05 Thread Anselm R. Garbe 
On Fri, Apr 04, 2008 at 11:40:32PM +0200, Matthias-Christian Ott wrote:
 Szabolcs Nagy [EMAIL PROTECTED] wrote:
 
  On 4/4/08, Matthias-Christian Ott [EMAIL PROTECTED] wrote:
   In other words you would propose the attached patch.
 
  nice, i like it
  (except an unnecessary space)
 
 I noticed that two after sending the patch ;). Copy  Paste in VIM
 sucks sometimes.

Thanks, I applied this patch to hg tip, I considered a similiar
solution, but I delay this thought for now. It was about having
a nextclient() function which works on lt-isfloating and which
replaces nexttiled()...

Kind regards,
-- 
 Anselm R. Garbe  http://www.suckless.org/  GPG key: 0D73F361

Re: [dwm] Monocle question

2008-04-05 Thread Matthias-Christian Ott 
Anselm R. Garbe [EMAIL PROTECTED] wrote:

 On Fri, Apr 04, 2008 at 11:40:32PM +0200, Matthias-Christian Ott wrote:
  Szabolcs Nagy [EMAIL PROTECTED] wrote:
  
   On 4/4/08, Matthias-Christian Ott [EMAIL PROTECTED] wrote:
In other words you would propose the attached patch.
  
   nice, i like it
   (except an unnecessary space)
  
  I noticed that two after sending the patch ;). Copy  Paste in VIM
  sucks sometimes.

 Thanks, I applied this patch to hg tip, I considered a similiar
 solution, but I delay this thought for now. It was about having
 a nextclient() function which works on lt-isfloating and which
 replaces nexttiled()...

There's something we overlooked (I noticed it already yesterday, but
thought someone will notice it). I attached a fixing patch.
Maybe you should add a hook to compile dwm before committing.

Regards
Matthias-Christian
diff -r f7a24c410801 dwm.c
--- a/dwm.c Sat Apr 05 19:53:25 2008 +0200
+++ b/dwm.c Sat Apr 05 19:54:11 2008 +0200
@@ -1076,7 +1076,7 @@
Client *c;
 
for(c = clients; c; c = c-next)
-   if((lt-isfloating || !c-floating)   isvisible(c))
+   if((lt-isfloating || !c-isfloating)   isvisible(c))
resize(c, mox, moy, mow - 2 * c-bw, moh - 2 * c-bw, 
RESIZEHINTS);
 }