[Dx-packages] [Bug 1363630] Re: Since revision 446.1.3, Zenity backend is broken
This bug was fixed in the package indicator-session - 12.10.5+14.04.20150404-0ubuntu1 --- indicator-session (12.10.5+14.04.20150404-0ubuntu1) trusty; urgency=medium [ Dmitry Shachnev ] * Make Cancel button in Zenity backend work again. (LP: #1363630) -- CI Train Bot ci-train-...@canonical.com Sat, 04 Apr 2015 09:29:37 + ** Changed in: indicator-session (Ubuntu Trusty) Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of DX Packages, which is subscribed to indicator-session in Ubuntu. Matching subscriptions: dx-packages https://bugs.launchpad.net/bugs/1363630 Title: Since revision 446.1.3, Zenity backend is broken Status in Ubuntu GNOME Flashback: Fix Released Status in indicator-session package in Ubuntu: Fix Released Status in indicator-session source package in Trusty: Fix Released Bug description: Currently the code in zenity_question() looks like: if (!g_spawn_check_exit_status (exit_status, error)) confirmed = TRUE; else confirmed = exit_status == 0; However !g_spawn_check_exit_status() call is mostly equivalent to exit_status != 0. Thus, confirmed will be *always* set to TRUE, even if the user cancelled the dialog. I have prepared a branch to fix this. == Impact == The Cancel buttons in shutdown/end session dialogs are not working, and do the same as OK buttons. This may lead to data loss due to unsaved documents/etc. == Test Case == * Log in to GNOME Flashback session. * Select Shutdown from indicator-session menu. * In the popped up dialog select Cancel. Expected result: the dialog will close, the machine won't shut down. == Development / Stable Fix == Please see the attached branches. == Regression Potential == The fix is part of 14.10 release and was confirmed to work fine. So no regression potential. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome-flashback/+bug/1363630/+subscriptions -- Mailing list: https://launchpad.net/~dx-packages Post to : dx-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~dx-packages More help : https://help.launchpad.net/ListHelp
[Dx-packages] [Bug 1363630] Re: Since revision 446.1.3, Zenity backend is broken
Installed the fix works now needed a reboot first Thanks -- You received this bug notification because you are a member of DX Packages, which is subscribed to indicator-session in Ubuntu. Matching subscriptions: dx-packages https://bugs.launchpad.net/bugs/1363630 Title: Since revision 446.1.3, Zenity backend is broken Status in Ubuntu GNOME Flashback: Fix Released Status in indicator-session package in Ubuntu: Fix Released Status in indicator-session source package in Trusty: Fix Committed Bug description: Currently the code in zenity_question() looks like: if (!g_spawn_check_exit_status (exit_status, error)) confirmed = TRUE; else confirmed = exit_status == 0; However !g_spawn_check_exit_status() call is mostly equivalent to exit_status != 0. Thus, confirmed will be *always* set to TRUE, even if the user cancelled the dialog. I have prepared a branch to fix this. == Impact == The Cancel buttons in shutdown/end session dialogs are not working, and do the same as OK buttons. This may lead to data loss due to unsaved documents/etc. == Test Case == * Log in to GNOME Flashback session. * Select Shutdown from indicator-session menu. * In the popped up dialog select Cancel. Expected result: the dialog will close, the machine won't shut down. == Development / Stable Fix == Please see the attached branches. == Regression Potential == The fix is part of 14.10 release and was confirmed to work fine. So no regression potential. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome-flashback/+bug/1363630/+subscriptions -- Mailing list: https://launchpad.net/~dx-packages Post to : dx-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~dx-packages More help : https://help.launchpad.net/ListHelp
[Dx-packages] [Bug 1363630] Re: Since revision 446.1.3, Zenity backend is broken
I can reproduce this bug using gnome-flashback-compiz on up-to-date ubuntu 14.04.2 64 bit, Linux i7 3.13.0-49-generic (latest at this moment) -- You received this bug notification because you are a member of DX Packages, which is subscribed to indicator-session in Ubuntu. Matching subscriptions: dx-packages https://bugs.launchpad.net/bugs/1363630 Title: Since revision 446.1.3, Zenity backend is broken Status in Ubuntu GNOME Flashback: Fix Released Status in indicator-session package in Ubuntu: Fix Released Status in indicator-session source package in Trusty: Fix Committed Bug description: Currently the code in zenity_question() looks like: if (!g_spawn_check_exit_status (exit_status, error)) confirmed = TRUE; else confirmed = exit_status == 0; However !g_spawn_check_exit_status() call is mostly equivalent to exit_status != 0. Thus, confirmed will be *always* set to TRUE, even if the user cancelled the dialog. I have prepared a branch to fix this. == Impact == The Cancel buttons in shutdown/end session dialogs are not working, and do the same as OK buttons. This may lead to data loss due to unsaved documents/etc. == Test Case == * Log in to GNOME Flashback session. * Select Shutdown from indicator-session menu. * In the popped up dialog select Cancel. Expected result: the dialog will close, the machine won't shut down. == Development / Stable Fix == Please see the attached branches. == Regression Potential == The fix is part of 14.10 release and was confirmed to work fine. So no regression potential. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome-flashback/+bug/1363630/+subscriptions -- Mailing list: https://launchpad.net/~dx-packages Post to : dx-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~dx-packages More help : https://help.launchpad.net/ListHelp
[Dx-packages] [Bug 1363630] Re: Since revision 446.1.3, Zenity backend is broken
Post output of (from terminal): apt-cache policy indicator-session -- You received this bug notification because you are a member of DX Packages, which is subscribed to indicator-session in Ubuntu. Matching subscriptions: dx-packages https://bugs.launchpad.net/bugs/1363630 Title: Since revision 446.1.3, Zenity backend is broken Status in Ubuntu GNOME Flashback: Fix Released Status in indicator-session package in Ubuntu: Fix Released Status in indicator-session source package in Trusty: Fix Committed Bug description: Currently the code in zenity_question() looks like: if (!g_spawn_check_exit_status (exit_status, error)) confirmed = TRUE; else confirmed = exit_status == 0; However !g_spawn_check_exit_status() call is mostly equivalent to exit_status != 0. Thus, confirmed will be *always* set to TRUE, even if the user cancelled the dialog. I have prepared a branch to fix this. == Impact == The Cancel buttons in shutdown/end session dialogs are not working, and do the same as OK buttons. This may lead to data loss due to unsaved documents/etc. == Test Case == * Log in to GNOME Flashback session. * Select Shutdown from indicator-session menu. * In the popped up dialog select Cancel. Expected result: the dialog will close, the machine won't shut down. == Development / Stable Fix == Please see the attached branches. == Regression Potential == The fix is part of 14.10 release and was confirmed to work fine. So no regression potential. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome-flashback/+bug/1363630/+subscriptions -- Mailing list: https://launchpad.net/~dx-packages Post to : dx-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~dx-packages More help : https://help.launchpad.net/ListHelp
[Dx-packages] [Bug 1363630] Re: Since revision 446.1.3, Zenity backend is broken
Thank you! Interestingly, the response is that I already have that package installed... tadiv@tadiv-desktop:~$ sudo apt-get install indicator-session [sudo] password for tadiv: Reading package lists... Done Building dependency tree Reading state information... Done indicator-session is already the newest version. The following packages were automatically installed and are no longer required: gir1.2-nautilus-3.0 linux-image-generic python-nautilus Use 'apt-get autoremove' to remove them. 0 upgraded, 0 newly installed, 0 to remove and 36 not upgraded. -- You received this bug notification because you are a member of DX Packages, which is subscribed to indicator-session in Ubuntu. Matching subscriptions: dx-packages https://bugs.launchpad.net/bugs/1363630 Title: Since revision 446.1.3, Zenity backend is broken Status in Ubuntu GNOME Flashback: Fix Released Status in indicator-session package in Ubuntu: Fix Released Status in indicator-session source package in Trusty: Fix Committed Bug description: Currently the code in zenity_question() looks like: if (!g_spawn_check_exit_status (exit_status, error)) confirmed = TRUE; else confirmed = exit_status == 0; However !g_spawn_check_exit_status() call is mostly equivalent to exit_status != 0. Thus, confirmed will be *always* set to TRUE, even if the user cancelled the dialog. I have prepared a branch to fix this. == Impact == The Cancel buttons in shutdown/end session dialogs are not working, and do the same as OK buttons. This may lead to data loss due to unsaved documents/etc. == Test Case == * Log in to GNOME Flashback session. * Select Shutdown from indicator-session menu. * In the popped up dialog select Cancel. Expected result: the dialog will close, the machine won't shut down. == Development / Stable Fix == Please see the attached branches. == Regression Potential == The fix is part of 14.10 release and was confirmed to work fine. So no regression potential. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome-flashback/+bug/1363630/+subscriptions -- Mailing list: https://launchpad.net/~dx-packages Post to : dx-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~dx-packages More help : https://help.launchpad.net/ListHelp
[Dx-packages] [Bug 1363630] Re: Since revision 446.1.3, Zenity backend is broken
The fix is either not actually installed, or it is not working for me. -- You received this bug notification because you are a member of DX Packages, which is subscribed to indicator-session in Ubuntu. Matching subscriptions: dx-packages https://bugs.launchpad.net/bugs/1363630 Title: Since revision 446.1.3, Zenity backend is broken Status in Ubuntu GNOME Flashback: Fix Released Status in indicator-session package in Ubuntu: Fix Released Status in indicator-session source package in Trusty: Fix Committed Bug description: Currently the code in zenity_question() looks like: if (!g_spawn_check_exit_status (exit_status, error)) confirmed = TRUE; else confirmed = exit_status == 0; However !g_spawn_check_exit_status() call is mostly equivalent to exit_status != 0. Thus, confirmed will be *always* set to TRUE, even if the user cancelled the dialog. I have prepared a branch to fix this. == Impact == The Cancel buttons in shutdown/end session dialogs are not working, and do the same as OK buttons. This may lead to data loss due to unsaved documents/etc. == Test Case == * Log in to GNOME Flashback session. * Select Shutdown from indicator-session menu. * In the popped up dialog select Cancel. Expected result: the dialog will close, the machine won't shut down. == Development / Stable Fix == Please see the attached branches. == Regression Potential == The fix is part of 14.10 release and was confirmed to work fine. So no regression potential. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome-flashback/+bug/1363630/+subscriptions -- Mailing list: https://launchpad.net/~dx-packages Post to : dx-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~dx-packages More help : https://help.launchpad.net/ListHelp
[Dx-packages] [Bug 1363630] Re: Since revision 446.1.3, Zenity backend is broken
** Branch linked: lp:ubuntu/trusty-proposed/indicator-session -- You received this bug notification because you are a member of DX Packages, which is subscribed to indicator-session in Ubuntu. Matching subscriptions: dx-packages https://bugs.launchpad.net/bugs/1363630 Title: Since revision 446.1.3, Zenity backend is broken Status in Ubuntu GNOME Flashback: Fix Released Status in indicator-session package in Ubuntu: Fix Released Status in indicator-session source package in Trusty: Fix Committed Bug description: Currently the code in zenity_question() looks like: if (!g_spawn_check_exit_status (exit_status, error)) confirmed = TRUE; else confirmed = exit_status == 0; However !g_spawn_check_exit_status() call is mostly equivalent to exit_status != 0. Thus, confirmed will be *always* set to TRUE, even if the user cancelled the dialog. I have prepared a branch to fix this. == Impact == The Cancel buttons in shutdown/end session dialogs are not working, and do the same as OK buttons. This may lead to data loss due to unsaved documents/etc. == Test Case == * Log in to GNOME Flashback session. * Select Shutdown from indicator-session menu. * In the popped up dialog select Cancel. Expected result: the dialog will close, the machine won't shut down. == Development / Stable Fix == Please see the attached branches. == Regression Potential == The fix is part of 14.10 release and was confirmed to work fine. So no regression potential. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome-flashback/+bug/1363630/+subscriptions -- Mailing list: https://launchpad.net/~dx-packages Post to : dx-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~dx-packages More help : https://help.launchpad.net/ListHelp
[Dx-packages] [Bug 1363630] Re: Since revision 446.1.3, Zenity backend is broken
Hello Dmitry, or anyone else affected, Accepted indicator-session into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/indicator- session/12.10.5+14.04.20150404-0ubuntu1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance! ** Changed in: indicator-session (Ubuntu Trusty) Status: In Progress = Fix Committed ** Tags added: verification-needed -- You received this bug notification because you are a member of DX Packages, which is subscribed to indicator-session in Ubuntu. Matching subscriptions: dx-packages https://bugs.launchpad.net/bugs/1363630 Title: Since revision 446.1.3, Zenity backend is broken Status in Ubuntu GNOME Flashback: Fix Released Status in indicator-session package in Ubuntu: Fix Released Status in indicator-session source package in Trusty: Fix Committed Bug description: Currently the code in zenity_question() looks like: if (!g_spawn_check_exit_status (exit_status, error)) confirmed = TRUE; else confirmed = exit_status == 0; However !g_spawn_check_exit_status() call is mostly equivalent to exit_status != 0. Thus, confirmed will be *always* set to TRUE, even if the user cancelled the dialog. I have prepared a branch to fix this. == Impact == The Cancel buttons in shutdown/end session dialogs are not working, and do the same as OK buttons. This may lead to data loss due to unsaved documents/etc. == Test Case == * Log in to GNOME Flashback session. * Select Shutdown from indicator-session menu. * In the popped up dialog select Cancel. Expected result: the dialog will close, the machine won't shut down. == Development / Stable Fix == Please see the attached branches. == Regression Potential == The fix is part of 14.10 release and was confirmed to work fine. So no regression potential. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome-flashback/+bug/1363630/+subscriptions -- Mailing list: https://launchpad.net/~dx-packages Post to : dx-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~dx-packages More help : https://help.launchpad.net/ListHelp
[Dx-packages] [Bug 1363630] Re: Since revision 446.1.3, Zenity backend is broken
Hello, Works for me on Ubuntu 14.04 i386. It allows me to cancel Shutdown, Reboot and Close session. FYI, close the session then log in allows this change to take effect. -- You received this bug notification because you are a member of DX Packages, which is subscribed to indicator-session in Ubuntu. Matching subscriptions: dx-packages https://bugs.launchpad.net/bugs/1363630 Title: Since revision 446.1.3, Zenity backend is broken Status in Ubuntu GNOME Flashback: Fix Released Status in indicator-session package in Ubuntu: Fix Released Status in indicator-session source package in Trusty: Fix Committed Bug description: Currently the code in zenity_question() looks like: if (!g_spawn_check_exit_status (exit_status, error)) confirmed = TRUE; else confirmed = exit_status == 0; However !g_spawn_check_exit_status() call is mostly equivalent to exit_status != 0. Thus, confirmed will be *always* set to TRUE, even if the user cancelled the dialog. I have prepared a branch to fix this. == Impact == The Cancel buttons in shutdown/end session dialogs are not working, and do the same as OK buttons. This may lead to data loss due to unsaved documents/etc. == Test Case == * Log in to GNOME Flashback session. * Select Shutdown from indicator-session menu. * In the popped up dialog select Cancel. Expected result: the dialog will close, the machine won't shut down. == Development / Stable Fix == Please see the attached branches. == Regression Potential == The fix is part of 14.10 release and was confirmed to work fine. So no regression potential. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome-flashback/+bug/1363630/+subscriptions -- Mailing list: https://launchpad.net/~dx-packages Post to : dx-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~dx-packages More help : https://help.launchpad.net/ListHelp
[Dx-packages] [Bug 1363630] Re: Since revision 446.1.3, Zenity backend is broken
@ Dmitry Shachnev, I performed verification testing and all is fine with one minor caveat. An initial restart is required before the change takes effect, so should we add a System restart required warning after 'indicator-session' upgrades? Otherwise all is fine, and I also cross-tested with the shutdown and restart buttons displayed by the main menu button. So other than the above mentioned caveat this could be marked verification-done. -- You received this bug notification because you are a member of DX Packages, which is subscribed to indicator-session in Ubuntu. Matching subscriptions: dx-packages https://bugs.launchpad.net/bugs/1363630 Title: Since revision 446.1.3, Zenity backend is broken Status in Ubuntu GNOME Flashback: Fix Released Status in indicator-session package in Ubuntu: Fix Released Status in indicator-session source package in Trusty: Fix Committed Bug description: Currently the code in zenity_question() looks like: if (!g_spawn_check_exit_status (exit_status, error)) confirmed = TRUE; else confirmed = exit_status == 0; However !g_spawn_check_exit_status() call is mostly equivalent to exit_status != 0. Thus, confirmed will be *always* set to TRUE, even if the user cancelled the dialog. I have prepared a branch to fix this. == Impact == The Cancel buttons in shutdown/end session dialogs are not working, and do the same as OK buttons. This may lead to data loss due to unsaved documents/etc. == Test Case == * Log in to GNOME Flashback session. * Select Shutdown from indicator-session menu. * In the popped up dialog select Cancel. Expected result: the dialog will close, the machine won't shut down. == Development / Stable Fix == Please see the attached branches. == Regression Potential == The fix is part of 14.10 release and was confirmed to work fine. So no regression potential. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome-flashback/+bug/1363630/+subscriptions -- Mailing list: https://launchpad.net/~dx-packages Post to : dx-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~dx-packages More help : https://help.launchpad.net/ListHelp
[Dx-packages] [Bug 1363630] Re: Since revision 446.1.3, Zenity backend is broken
OK - so I was able to add the proposed item to my .list file, but 1) the sudo apt-get upgrade -s listed a boatload of items (so I guess there is an issue with the /etc/apt/preferences.d/proposed-updates file I created and 2) even if that file was correct, I'm clueless as to how to install this patch to test it... A little help, please... Tom -- You received this bug notification because you are a member of DX Packages, which is subscribed to indicator-session in Ubuntu. Matching subscriptions: dx-packages https://bugs.launchpad.net/bugs/1363630 Title: Since revision 446.1.3, Zenity backend is broken Status in Ubuntu GNOME Flashback: Fix Released Status in indicator-session package in Ubuntu: Fix Released Status in indicator-session source package in Trusty: Fix Committed Bug description: Currently the code in zenity_question() looks like: if (!g_spawn_check_exit_status (exit_status, error)) confirmed = TRUE; else confirmed = exit_status == 0; However !g_spawn_check_exit_status() call is mostly equivalent to exit_status != 0. Thus, confirmed will be *always* set to TRUE, even if the user cancelled the dialog. I have prepared a branch to fix this. == Impact == The Cancel buttons in shutdown/end session dialogs are not working, and do the same as OK buttons. This may lead to data loss due to unsaved documents/etc. == Test Case == * Log in to GNOME Flashback session. * Select Shutdown from indicator-session menu. * In the popped up dialog select Cancel. Expected result: the dialog will close, the machine won't shut down. == Development / Stable Fix == Please see the attached branches. == Regression Potential == The fix is part of 14.10 release and was confirmed to work fine. So no regression potential. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome-flashback/+bug/1363630/+subscriptions -- Mailing list: https://launchpad.net/~dx-packages Post to : dx-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~dx-packages More help : https://help.launchpad.net/ListHelp
[Dx-packages] [Bug 1363630] Re: Since revision 446.1.3, Zenity backend is broken
Run 'sudo apt-get install indicator-session' to update only the indicator-session package. -- You received this bug notification because you are a member of DX Packages, which is subscribed to indicator-session in Ubuntu. Matching subscriptions: dx-packages https://bugs.launchpad.net/bugs/1363630 Title: Since revision 446.1.3, Zenity backend is broken Status in Ubuntu GNOME Flashback: Fix Released Status in indicator-session package in Ubuntu: Fix Released Status in indicator-session source package in Trusty: Fix Committed Bug description: Currently the code in zenity_question() looks like: if (!g_spawn_check_exit_status (exit_status, error)) confirmed = TRUE; else confirmed = exit_status == 0; However !g_spawn_check_exit_status() call is mostly equivalent to exit_status != 0. Thus, confirmed will be *always* set to TRUE, even if the user cancelled the dialog. I have prepared a branch to fix this. == Impact == The Cancel buttons in shutdown/end session dialogs are not working, and do the same as OK buttons. This may lead to data loss due to unsaved documents/etc. == Test Case == * Log in to GNOME Flashback session. * Select Shutdown from indicator-session menu. * In the popped up dialog select Cancel. Expected result: the dialog will close, the machine won't shut down. == Development / Stable Fix == Please see the attached branches. == Regression Potential == The fix is part of 14.10 release and was confirmed to work fine. So no regression potential. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome-flashback/+bug/1363630/+subscriptions -- Mailing list: https://launchpad.net/~dx-packages Post to : dx-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~dx-packages More help : https://help.launchpad.net/ListHelp
[Dx-packages] [Bug 1363630] Re: Since revision 446.1.3, Zenity backend is broken
** Branch linked: lp:~mitya57/indicator-session/lp1363630_trusty -- You received this bug notification because you are a member of DX Packages, which is subscribed to indicator-session in Ubuntu. Matching subscriptions: dx-packages https://bugs.launchpad.net/bugs/1363630 Title: Since revision 446.1.3, Zenity backend is broken Status in Ubuntu GNOME Flashback: Fix Released Status in indicator-session package in Ubuntu: Fix Released Status in indicator-session source package in Trusty: In Progress Bug description: Currently the code in zenity_question() looks like: if (!g_spawn_check_exit_status (exit_status, error)) confirmed = TRUE; else confirmed = exit_status == 0; However !g_spawn_check_exit_status() call is mostly equivalent to exit_status != 0. Thus, confirmed will be *always* set to TRUE, even if the user cancelled the dialog. I have prepared a branch to fix this. == Impact == The Cancel buttons in shutdown/end session dialogs are not working, and do the same as OK buttons. This may lead to data loss due to unsaved documents/etc. == Test Case == * Log in to GNOME Flashback session. * Select Shutdown from indicator-session menu. * In the popped up dialog select Cancel. Expected result: the dialog will close, the machine won't shut down. == Development / Stable Fix == Please see the attached branches. == Regression Potential == The fix is part of 14.10 release and was confirmed to work fine. So no regression potential. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome-flashback/+bug/1363630/+subscriptions -- Mailing list: https://launchpad.net/~dx-packages Post to : dx-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~dx-packages More help : https://help.launchpad.net/ListHelp
[Dx-packages] [Bug 1363630] Re: Since revision 446.1.3, Zenity backend is broken
** Description changed: Currently the code in zenity_question() looks like: if (!g_spawn_check_exit_status (exit_status, error)) - confirmed = TRUE; + confirmed = TRUE; else - confirmed = exit_status == 0; + confirmed = exit_status == 0; However !g_spawn_check_exit_status() call is mostly equivalent to exit_status != 0. Thus, confirmed will be *always* set to TRUE, even if the user cancelled the dialog. I have prepared a branch to fix this. + + == Impact == + The Cancel buttons in shutdown/end session dialogs are not working, and do the same as OK buttons. This may lead to data loss due to unsaved documents/etc. + + == Test Case == + * Log in to GNOME Flashback session. + * Select Shutdown from indicator-session menu. + * In the popped up dialog select Cancel. + + Expected result: the dialog will close, the machine won't shut down. + + == Development / Stable Fix == + Please see the attached branches. + + == Regression Potential == + The fix is part of 14.10 release and was confirmed to work fine. So no regression potential. -- You received this bug notification because you are a member of DX Packages, which is subscribed to indicator-session in Ubuntu. Matching subscriptions: dx-packages https://bugs.launchpad.net/bugs/1363630 Title: Since revision 446.1.3, Zenity backend is broken Status in Ubuntu GNOME Flashback: Fix Released Status in indicator-session package in Ubuntu: Fix Released Status in indicator-session source package in Trusty: In Progress Bug description: Currently the code in zenity_question() looks like: if (!g_spawn_check_exit_status (exit_status, error)) confirmed = TRUE; else confirmed = exit_status == 0; However !g_spawn_check_exit_status() call is mostly equivalent to exit_status != 0. Thus, confirmed will be *always* set to TRUE, even if the user cancelled the dialog. I have prepared a branch to fix this. == Impact == The Cancel buttons in shutdown/end session dialogs are not working, and do the same as OK buttons. This may lead to data loss due to unsaved documents/etc. == Test Case == * Log in to GNOME Flashback session. * Select Shutdown from indicator-session menu. * In the popped up dialog select Cancel. Expected result: the dialog will close, the machine won't shut down. == Development / Stable Fix == Please see the attached branches. == Regression Potential == The fix is part of 14.10 release and was confirmed to work fine. So no regression potential. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome-flashback/+bug/1363630/+subscriptions -- Mailing list: https://launchpad.net/~dx-packages Post to : dx-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~dx-packages More help : https://help.launchpad.net/ListHelp
[Dx-packages] [Bug 1363630] Re: Since revision 446.1.3, Zenity backend is broken
** Changed in: indicator-session (Ubuntu Trusty) Importance: Undecided = High ** Changed in: indicator-session (Ubuntu Trusty) Status: Confirmed = In Progress ** Changed in: indicator-session (Ubuntu Trusty) Assignee: (unassigned) = Dmitry Shachnev (mitya57) -- You received this bug notification because you are a member of DX Packages, which is subscribed to indicator-session in Ubuntu. Matching subscriptions: dx-packages https://bugs.launchpad.net/bugs/1363630 Title: Since revision 446.1.3, Zenity backend is broken Status in Ubuntu GNOME Flashback: Fix Released Status in indicator-session package in Ubuntu: Fix Released Status in indicator-session source package in Trusty: In Progress Bug description: Currently the code in zenity_question() looks like: if (!g_spawn_check_exit_status (exit_status, error)) confirmed = TRUE; else confirmed = exit_status == 0; However !g_spawn_check_exit_status() call is mostly equivalent to exit_status != 0. Thus, confirmed will be *always* set to TRUE, even if the user cancelled the dialog. I have prepared a branch to fix this. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome-flashback/+bug/1363630/+subscriptions -- Mailing list: https://launchpad.net/~dx-packages Post to : dx-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~dx-packages More help : https://help.launchpad.net/ListHelp
[Dx-packages] [Bug 1363630] Re: Since revision 446.1.3, Zenity backend is broken
I can reproduce this bug using gnome-flashback-compiz on up-to-date ubuntu 14.04.2, kernel 3.16.0-31 (latest hwe) -- You received this bug notification because you are a member of DX Packages, which is subscribed to indicator-session in Ubuntu. Matching subscriptions: dx-packages https://bugs.launchpad.net/bugs/1363630 Title: Since revision 446.1.3, Zenity backend is broken Status in Ubuntu GNOME Flashback: Fix Released Status in indicator-session package in Ubuntu: Fix Released Status in indicator-session source package in Trusty: Confirmed Bug description: Currently the code in zenity_question() looks like: if (!g_spawn_check_exit_status (exit_status, error)) confirmed = TRUE; else confirmed = exit_status == 0; However !g_spawn_check_exit_status() call is mostly equivalent to exit_status != 0. Thus, confirmed will be *always* set to TRUE, even if the user cancelled the dialog. I have prepared a branch to fix this. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome-flashback/+bug/1363630/+subscriptions -- Mailing list: https://launchpad.net/~dx-packages Post to : dx-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~dx-packages More help : https://help.launchpad.net/ListHelp
[Dx-packages] [Bug 1363630] Re: Since revision 446.1.3, Zenity backend is broken
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: indicator-session (Ubuntu Trusty) Status: New = Confirmed -- You received this bug notification because you are a member of DX Packages, which is subscribed to indicator-session in Ubuntu. Matching subscriptions: dx-packages https://bugs.launchpad.net/bugs/1363630 Title: Since revision 446.1.3, Zenity backend is broken Status in Ubuntu GNOME Flashback: Fix Released Status in indicator-session package in Ubuntu: Fix Released Status in indicator-session source package in Trusty: Confirmed Bug description: Currently the code in zenity_question() looks like: if (!g_spawn_check_exit_status (exit_status, error)) confirmed = TRUE; else confirmed = exit_status == 0; However !g_spawn_check_exit_status() call is mostly equivalent to exit_status != 0. Thus, confirmed will be *always* set to TRUE, even if the user cancelled the dialog. I have prepared a branch to fix this. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome-flashback/+bug/1363630/+subscriptions -- Mailing list: https://launchpad.net/~dx-packages Post to : dx-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~dx-packages More help : https://help.launchpad.net/ListHelp
[Dx-packages] [Bug 1363630] Re: Since revision 446.1.3, Zenity backend is broken
** Also affects: indicator-session (Ubuntu Trusty) Importance: Undecided Status: New -- You received this bug notification because you are a member of DX Packages, which is subscribed to indicator-session in Ubuntu. Matching subscriptions: dx-packages https://bugs.launchpad.net/bugs/1363630 Title: Since revision 446.1.3, Zenity backend is broken Status in Ubuntu GNOME Flashback: Fix Released Status in indicator-session package in Ubuntu: Fix Released Status in indicator-session source package in Trusty: New Bug description: Currently the code in zenity_question() looks like: if (!g_spawn_check_exit_status (exit_status, error)) confirmed = TRUE; else confirmed = exit_status == 0; However !g_spawn_check_exit_status() call is mostly equivalent to exit_status != 0. Thus, confirmed will be *always* set to TRUE, even if the user cancelled the dialog. I have prepared a branch to fix this. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome-flashback/+bug/1363630/+subscriptions -- Mailing list: https://launchpad.net/~dx-packages Post to : dx-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~dx-packages More help : https://help.launchpad.net/ListHelp
[Dx-packages] [Bug 1363630] Re: Since revision 446.1.3, Zenity backend is broken
This bug still affects me, I've updated the latest packages and indicator-session is at the version: 12.10.5+14.04.20140925-0ubuntu1 -- You received this bug notification because you are a member of DX Packages, which is subscribed to indicator-session in Ubuntu. Matching subscriptions: dx-packages https://bugs.launchpad.net/bugs/1363630 Title: Since revision 446.1.3, Zenity backend is broken Status in Ubuntu GNOME Flashback: Fix Released Status in indicator-session package in Ubuntu: Fix Released Bug description: Currently the code in zenity_question() looks like: if (!g_spawn_check_exit_status (exit_status, error)) confirmed = TRUE; else confirmed = exit_status == 0; However !g_spawn_check_exit_status() call is mostly equivalent to exit_status != 0. Thus, confirmed will be *always* set to TRUE, even if the user cancelled the dialog. I have prepared a branch to fix this. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome-flashback/+bug/1363630/+subscriptions -- Mailing list: https://launchpad.net/~dx-packages Post to : dx-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~dx-packages More help : https://help.launchpad.net/ListHelp
[Dx-packages] [Bug 1363630] Re: Since revision 446.1.3, Zenity backend is broken
** Changed in: ubuntu-gnome-flashback Status: New = Fix Released -- You received this bug notification because you are a member of DX Packages, which is subscribed to indicator-session in Ubuntu. Matching subscriptions: dx-packages https://bugs.launchpad.net/bugs/1363630 Title: Since revision 446.1.3, Zenity backend is broken Status in Ubuntu GNOME Flashback: Fix Released Status in “indicator-session” package in Ubuntu: Fix Released Bug description: Currently the code in zenity_question() looks like: if (!g_spawn_check_exit_status (exit_status, error)) confirmed = TRUE; else confirmed = exit_status == 0; However !g_spawn_check_exit_status() call is mostly equivalent to exit_status != 0. Thus, confirmed will be *always* set to TRUE, even if the user cancelled the dialog. I have prepared a branch to fix this. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome-flashback/+bug/1363630/+subscriptions -- Mailing list: https://launchpad.net/~dx-packages Post to : dx-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~dx-packages More help : https://help.launchpad.net/ListHelp
[Dx-packages] [Bug 1363630] Re: Since revision 446.1.3, Zenity backend is broken
** Branch linked: lp:ubuntu/utopic-proposed/indicator-session -- You received this bug notification because you are a member of DX Packages, which is subscribed to indicator-session in Ubuntu. Matching subscriptions: dx-packages https://bugs.launchpad.net/bugs/1363630 Title: Since revision 446.1.3, Zenity backend is broken Status in Ubuntu GNOME Flashback: New Status in “indicator-session” package in Ubuntu: In Progress Bug description: Currently the code in zenity_question() looks like: if (!g_spawn_check_exit_status (exit_status, error)) confirmed = TRUE; else confirmed = exit_status == 0; However !g_spawn_check_exit_status() call is mostly equivalent to exit_status != 0. Thus, confirmed will be *always* set to TRUE, even if the user cancelled the dialog. I have prepared a branch to fix this. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome-flashback/+bug/1363630/+subscriptions -- Mailing list: https://launchpad.net/~dx-packages Post to : dx-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~dx-packages More help : https://help.launchpad.net/ListHelp
[Dx-packages] [Bug 1363630] Re: Since revision 446.1.3, Zenity backend is broken
This bug was fixed in the package indicator-session - 12.10.5+14.10.20140919-0ubuntu1 --- indicator-session (12.10.5+14.10.20140919-0ubuntu1) utopic; urgency=low [ Dmitry Shachnev ] * Make Cancel button in Zenity backend work again (LP: #1363630) -- Ubuntu daily release ps-jenk...@lists.canonical.com Fri, 19 Sep 2014 13:48:47 + ** Changed in: indicator-session (Ubuntu) Status: In Progress = Fix Released -- You received this bug notification because you are a member of DX Packages, which is subscribed to indicator-session in Ubuntu. Matching subscriptions: dx-packages https://bugs.launchpad.net/bugs/1363630 Title: Since revision 446.1.3, Zenity backend is broken Status in Ubuntu GNOME Flashback: New Status in “indicator-session” package in Ubuntu: Fix Released Bug description: Currently the code in zenity_question() looks like: if (!g_spawn_check_exit_status (exit_status, error)) confirmed = TRUE; else confirmed = exit_status == 0; However !g_spawn_check_exit_status() call is mostly equivalent to exit_status != 0. Thus, confirmed will be *always* set to TRUE, even if the user cancelled the dialog. I have prepared a branch to fix this. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome-flashback/+bug/1363630/+subscriptions -- Mailing list: https://launchpad.net/~dx-packages Post to : dx-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~dx-packages More help : https://help.launchpad.net/ListHelp
