[Dx-packages] [Bug 2024560] Re: Check if 0010-set-language needs to be update for the new languages property

2023-08-28 Thread Sebastien Bacher
We didn't get any other reports about it so I guess it's fine now, let's
close

** Changed in: accountsservice (Ubuntu)
   Status: Incomplete => Fix Released

-- 
You received this bug notification because you are a member of DX
Packages, which is subscribed to accountsservice in Ubuntu.
Matching subscriptions: dx-packages
https://bugs.launchpad.net/bugs/2024560

Title:
  Check if 0010-set-language needs to be update for the new languages
  property

Status in accountsservice package in Ubuntu:
  Fix Released

Bug description:
  Upstream did changes to add a languages properties

  
https://gitlab.freedesktop.org/accountsservice/accountsservice/-/commit/881e0ea7

  I've rebased 0010-set-language to apply correctly but we should review
  if we need to adapt the patch to apply a similar logic to the new
  languages property that it's doing for old language one

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/accountsservice/+bug/2024560/+subscriptions


-- 
Mailing list: https://launchpad.net/~dx-packages
Post to : dx-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~dx-packages
More help   : https://help.launchpad.net/ListHelp


[Dx-packages] [Bug 2024560] Re: Check if 0010-set-language needs to be update for the new languages property

2023-08-28 Thread Gunnar Hjalmarsson
@Sebastien: Is this bug ready to be closed again?

-- 
You received this bug notification because you are a member of DX
Packages, which is subscribed to accountsservice in Ubuntu.
Matching subscriptions: dx-packages
https://bugs.launchpad.net/bugs/2024560

Title:
  Check if 0010-set-language needs to be update for the new languages
  property

Status in accountsservice package in Ubuntu:
  Incomplete

Bug description:
  Upstream did changes to add a languages properties

  
https://gitlab.freedesktop.org/accountsservice/accountsservice/-/commit/881e0ea7

  I've rebased 0010-set-language to apply correctly but we should review
  if we need to adapt the patch to apply a similar logic to the new
  languages property that it's doing for old language one

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/accountsservice/+bug/2024560/+subscriptions


-- 
Mailing list: https://launchpad.net/~dx-packages
Post to : dx-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~dx-packages
More help   : https://help.launchpad.net/ListHelp


[Dx-packages] [Bug 2024560] Re: Check if 0010-set-language needs to be update for the new languages property

2023-06-28 Thread Gunnar Hjalmarsson
It's probably because you still have that colon separated list in your
keyfile in /var/lib/AccountsService/users after having played with
version 23.13.9-1ubuntu1.

* Go to Settings -> Region & Language (it will complain there too)

* Change the language to French, which alters the applicable keyfile
entry to "Languages=fr;"

Does that fix it?

** Changed in: accountsservice (Ubuntu)
   Status: Confirmed => Incomplete

-- 
You received this bug notification because you are a member of DX
Packages, which is subscribed to accountsservice in Ubuntu.
Matching subscriptions: dx-packages
https://bugs.launchpad.net/bugs/2024560

Title:
  Check if 0010-set-language needs to be update for the new languages
  property

Status in accountsservice package in Ubuntu:
  Incomplete

Bug description:
  Upstream did changes to add a languages properties

  
https://gitlab.freedesktop.org/accountsservice/accountsservice/-/commit/881e0ea7

  I've rebased 0010-set-language to apply correctly but we should review
  if we need to adapt the patch to apply a similar logic to the new
  languages property that it's doing for old language one

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/accountsservice/+bug/2024560/+subscriptions


-- 
Mailing list: https://launchpad.net/~dx-packages
Post to : dx-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~dx-packages
More help   : https://help.launchpad.net/ListHelp


[Dx-packages] [Bug 2024560] Re: Check if 0010-set-language needs to be update for the new languages property

2023-06-28 Thread Sebastien Bacher
I'm reopening because I think there is still work to be done there,
opening the users panel in setting leads to those warnings

10:11:00.4223   **[19511]: WARNING: Couldn't get locale for 
language: fr_FR:en
10:11:00.4224 GnomeDesktop[19511]:CRITICAL: 
gnome_get_language_from_locale: assertion '*locale != '\0'' failed

ii  accountsservice23.13.9-2ubuntu1
amd64query and manipulate user account information


** Changed in: accountsservice (Ubuntu)
   Status: Fix Released => Confirmed

-- 
You received this bug notification because you are a member of DX
Packages, which is subscribed to accountsservice in Ubuntu.
Matching subscriptions: dx-packages
https://bugs.launchpad.net/bugs/2024560

Title:
  Check if 0010-set-language needs to be update for the new languages
  property

Status in accountsservice package in Ubuntu:
  Confirmed

Bug description:
  Upstream did changes to add a languages properties

  
https://gitlab.freedesktop.org/accountsservice/accountsservice/-/commit/881e0ea7

  I've rebased 0010-set-language to apply correctly but we should review
  if we need to adapt the patch to apply a similar logic to the new
  languages property that it's doing for old language one

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/accountsservice/+bug/2024560/+subscriptions


-- 
Mailing list: https://launchpad.net/~dx-packages
Post to : dx-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~dx-packages
More help   : https://help.launchpad.net/ListHelp


[Dx-packages] [Bug 2024560] Re: Check if 0010-set-language needs to be update for the new languages property

2023-06-28 Thread Launchpad Bug Tracker
This bug was fixed in the package accountsservice - 23.13.9-2ubuntu1

---
accountsservice (23.13.9-2ubuntu1) mantic; urgency=medium

  * Includes some extra upstream bugfixes

accountsservice (23.13.9-2) unstable; urgency=medium

  * debian/patches/git_user_manager.patch:
- Disconnect from manager signals when freeing a request and resolve
  indicator-messages crashing on logout (lp: #2015962)
  * debian/patches/git_default_gdm.patch:
- default to gdm if there display-manager.service isn't a known target,
  which is the case for our gdm called gdm3, fixes the service
  crashing when trying to toggle autologin (lp: #2024870)

 -- Sebastien Bacher   Mon, 26 Jun 2023 16:25:07
+0200

** Changed in: accountsservice (Ubuntu)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of DX
Packages, which is subscribed to accountsservice in Ubuntu.
Matching subscriptions: dx-packages
https://bugs.launchpad.net/bugs/2024560

Title:
  Check if 0010-set-language needs to be update for the new languages
  property

Status in accountsservice package in Ubuntu:
  Fix Released

Bug description:
  Upstream did changes to add a languages properties

  
https://gitlab.freedesktop.org/accountsservice/accountsservice/-/commit/881e0ea7

  I've rebased 0010-set-language to apply correctly but we should review
  if we need to adapt the patch to apply a similar logic to the new
  languages property that it's doing for old language one

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/accountsservice/+bug/2024560/+subscriptions


-- 
Mailing list: https://launchpad.net/~dx-packages
Post to : dx-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~dx-packages
More help   : https://help.launchpad.net/ListHelp


[Dx-packages] [Bug 2024560] Re: Check if 0010-set-language needs to be update for the new languages property

2023-06-24 Thread Gunnar Hjalmarsson
I did some tests and identified a problem. If I use language-selector-
gnome to change from English (US) to Swedish, it looks like this:

$ sudo cat /var/lib/AccountsService/users/gunnar | grep Lang
Languages=sv:en_US:en;

Next:
* Relogin
* Open g-c-c from terminal and switch to Region & Language

Then you see this error message:

00:59:54.0364   **[11007]: WARNING: Couldn't get locale for 
language: sv:en_US:en
00:59:54.0366 GnomeDesktop[11007]:CRITICAL: 
gnome_get_language_from_locale: assertion '*locale != '\0'' failed

This can be dealt with in different ways, but for now I think it's
better to change 0010-set-language.patch so it does not write the colon
separated language list into the accountsservice keyfile. That way the
language selector in lightdm-gtk-greeter keeps working as well.

So I have uploaded a change, which also allowed me to drop language-not-
xpg.patch.

Not sure if the upstream project is at all useful for us. In any case I
kind of fear the it will cause more issues...

** Changed in: accountsservice (Ubuntu)
   Status: New => Fix Committed

** Changed in: accountsservice (Ubuntu)
 Assignee: (unassigned) => Gunnar Hjalmarsson (gunnarhj)

-- 
You received this bug notification because you are a member of DX
Packages, which is subscribed to accountsservice in Ubuntu.
Matching subscriptions: dx-packages
https://bugs.launchpad.net/bugs/2024560

Title:
  Check if 0010-set-language needs to be update for the new languages
  property

Status in accountsservice package in Ubuntu:
  Fix Committed

Bug description:
  Upstream did changes to add a languages properties

  
https://gitlab.freedesktop.org/accountsservice/accountsservice/-/commit/881e0ea7

  I've rebased 0010-set-language to apply correctly but we should review
  if we need to adapt the patch to apply a similar logic to the new
  languages property that it's doing for old language one

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/accountsservice/+bug/2024560/+subscriptions


-- 
Mailing list: https://launchpad.net/~dx-packages
Post to : dx-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~dx-packages
More help   : https://help.launchpad.net/ListHelp


[Dx-packages] [Bug 2024560] Re: Check if 0010-set-language needs to be update for the new languages property

2023-06-22 Thread Gunnar Hjalmarsson
@Sebastien: The new "Languages" property is described as an optional
one, but it still looks like language changes are now stored in the
"Languages" property instead of "Language".

The backend patches in accountsservice, g-c-c, etc. (which I'm guilty
of)

1. serve the purpose of keeping language-selector-gnome useful for both
Ubuntu and all the flavors (except for Kubuntu, which relies on KDE
stuff), and

2. make the language selection control in language-selector-gnome play
well with the equivalent in Region & Language.

I'll try to find out if GetLanguage and SetLanguage still works as
intended for us at this point.

If a UI control for maintaining "Languages" directly is added to g-c-c,
I imagine that we need to re-evaluate our approch more thoroghly. Do you
know if there is such a plan?

As regards disabling of that test, I wouldn't worry too much. Our code
does the right thing when a string like "fr_FR:en" is passed to
SetLanguage, and makes sure that only a valid locale name of a locale
which has actually been generated on the system is assigned to LANG via
~/.pam_environment.

-- 
You received this bug notification because you are a member of DX
Packages, which is subscribed to accountsservice in Ubuntu.
Matching subscriptions: dx-packages
https://bugs.launchpad.net/bugs/2024560

Title:
  Check if 0010-set-language needs to be update for the new languages
  property

Status in accountsservice package in Ubuntu:
  New

Bug description:
  Upstream did changes to add a languages properties

  
https://gitlab.freedesktop.org/accountsservice/accountsservice/-/commit/881e0ea7

  I've rebased 0010-set-language to apply correctly but we should review
  if we need to adapt the patch to apply a similar logic to the new
  languages property that it's doing for old language one

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/accountsservice/+bug/2024560/+subscriptions


-- 
Mailing list: https://launchpad.net/~dx-packages
Post to : dx-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~dx-packages
More help   : https://help.launchpad.net/ListHelp


[Dx-packages] [Bug 2024560] Re: Check if 0010-set-language needs to be update for the new languages property

2023-06-21 Thread Gunnar Hjalmarsson
I'll comment on this in a bit. Busy with another thing ATM.

-- 
You received this bug notification because you are a member of DX
Packages, which is subscribed to accountsservice in Ubuntu.
Matching subscriptions: dx-packages
https://bugs.launchpad.net/bugs/2024560

Title:
  Check if 0010-set-language needs to be update for the new languages
  property

Status in accountsservice package in Ubuntu:
  New

Bug description:
  Upstream did changes to add a languages properties

  
https://gitlab.freedesktop.org/accountsservice/accountsservice/-/commit/881e0ea7

  I've rebased 0010-set-language to apply correctly but we should review
  if we need to adapt the patch to apply a similar logic to the new
  languages property that it's doing for old language one

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/accountsservice/+bug/2024560/+subscriptions


-- 
Mailing list: https://launchpad.net/~dx-packages
Post to : dx-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~dx-packages
More help   : https://help.launchpad.net/ListHelp


[Dx-packages] [Bug 2024560] Re: Check if 0010-set-language needs to be update for the new languages property

2023-06-21 Thread Sebastien Bacher
I also had to revert
https://gitlab.freedesktop.org/accountsservice/accountsservice/-/commit/bed11bbe
(language-not-xpg.patch in the new upload)

otherwise trying to move french over the top english entry in gnome-
language-selector would error out

> dbus.exceptions.DBusException: org.freedesktop.DBus.Error.InvalidArgs:
Locale 'fr_FR:en' is not a valid XPG-formatted locale

-- 
You received this bug notification because you are a member of DX
Packages, which is subscribed to accountsservice in Ubuntu.
Matching subscriptions: dx-packages
https://bugs.launchpad.net/bugs/2024560

Title:
  Check if 0010-set-language needs to be update for the new languages
  property

Status in accountsservice package in Ubuntu:
  New

Bug description:
  Upstream did changes to add a languages properties

  
https://gitlab.freedesktop.org/accountsservice/accountsservice/-/commit/881e0ea7

  I've rebased 0010-set-language to apply correctly but we should review
  if we need to adapt the patch to apply a similar logic to the new
  languages property that it's doing for old language one

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/accountsservice/+bug/2024560/+subscriptions


-- 
Mailing list: https://launchpad.net/~dx-packages
Post to : dx-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~dx-packages
More help   : https://help.launchpad.net/ListHelp


[Dx-packages] [Bug 2024560] Re: Check if 0010-set-language needs to be update for the new languages property

2023-06-21 Thread Sebastien Bacher
** Changed in: accountsservice (Ubuntu)
   Importance: Undecided => High

-- 
You received this bug notification because you are a member of DX
Packages, which is subscribed to accountsservice in Ubuntu.
Matching subscriptions: dx-packages
https://bugs.launchpad.net/bugs/2024560

Title:
  Check if 0010-set-language needs to be update for the new languages
  property

Status in accountsservice package in Ubuntu:
  New

Bug description:
  Upstream did changes to add a languages properties

  
https://gitlab.freedesktop.org/accountsservice/accountsservice/-/commit/881e0ea7

  I've rebased 0010-set-language to apply correctly but we should review
  if we need to adapt the patch to apply a similar logic to the new
  languages property that it's doing for old language one

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/accountsservice/+bug/2024560/+subscriptions


-- 
Mailing list: https://launchpad.net/~dx-packages
Post to : dx-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~dx-packages
More help   : https://help.launchpad.net/ListHelp


[Dx-packages] [Bug 2024560] Re: Check if 0010-set-language needs to be update for the new languages property

2023-06-21 Thread Sebastien Bacher
** Tags added: udeng-833

-- 
You received this bug notification because you are a member of DX
Packages, which is subscribed to accountsservice in Ubuntu.
Matching subscriptions: dx-packages
https://bugs.launchpad.net/bugs/2024560

Title:
  Check if 0010-set-language needs to be update for the new languages
  property

Status in accountsservice package in Ubuntu:
  New

Bug description:
  Upstream did changes to add a languages properties

  
https://gitlab.freedesktop.org/accountsservice/accountsservice/-/commit/881e0ea7

  I've rebased 0010-set-language to apply correctly but we should review
  if we need to adapt the patch to apply a similar logic to the new
  languages property that it's doing for old language one

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/accountsservice/+bug/2024560/+subscriptions


-- 
Mailing list: https://launchpad.net/~dx-packages
Post to : dx-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~dx-packages
More help   : https://help.launchpad.net/ListHelp