-Original Message-
From: David Miller [mailto:da...@davemloft.net]
Sent: Thursday, June 07, 2012 6:12 PM
To: joe@oracle.com
Cc: e1000-devel@lists.sourceforge.net; guru.anbalag...@oracle.com;
Allan, Bruce W; Brandeburg, Jesse; adnan.mishe...@oracle.com; Ronciak,
John; net...@vger.kernel.org; linux-ker...@vger.kernel.org
Subject: Re: [E1000-devel] [PATCH] e1000e: disable rxhash when try to
enable jumbo frame also rxhash and rxcsum have enabled
From: Joe Jin joe@oracle.com
Date: Fri, 08 Jun 2012 09:06:40 +0800
Upstream commit 70495a5 check if both rxhash and rxcsum enabled when
enabling
jumbo frames and disallowed all of them enabled at the same time.
Since jumbo frame widely be used in real world, so when try to
enable jumbo
frames but rxhash and rxcsum have enabled, change the default
behavior to
disable receive hashing.
Signed-off-by: Joe Jin joe@oracle.com
Signed-off-by: Guru Anbalagane guru.anbalag...@oracle.com
Acked-by: Adnan Misherfi adnan.mishe...@oracle.com
If I were the Intel developers I would not apply this patch, it sets
a very bad precedence.
The tool tells you that the combination you're attempting to use is
invalid, and the kernel log message tells you exactly why.
The driver should never automatically change configuration settings
not actually requested by the user.
I've been working on another patch that removes the issue with disabling
one feature over another altogether, so this patch would be moot. It will
be pushed to our internal testing organization in the next day or two.
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel#174; Ethernet, visit
http://communities.intel.com/community/wired
