Re: [E3-hacking] Anyone know the Pinout of the Amstrad E3 Videophone Mailboard

2019-08-22 Thread Ralph Corderoy
Hi Nick,

> I plugged it into my PC just to see if it works ,I need it to work on
> Andriod, is there a way of mapping the keys on that, its Android
> 4.4.4…?

That's more of an Android question, you may be better off asking
somewhere else.  Google suggests things like
https://pyra-handheld.com/boards/threads/tutorial-how-to-remap-android-hardware-keys.69593/
so it looks possible.

-- 
Cheers, Ralph.

___
e3-hacking mailing list
e3-hacking@earth.li
https://www.earth.li/mailman/listinfo/e3-hacking


Re: [E3-hacking] Config / content filesystem

2019-04-24 Thread Ralph Corderoy
Hi Nick,

> Starting restore.. This might take a while...
> found /media/sda1/e3-nand.0
> erasing 224 on /dev/mtd0
> Erase Total 224 Units
> Performing Flash Erase of length 16384 at offset 0x37c000 done offset 0x1f8000
> writing flash
> Input file is not page aligned

That's nandwrite detecting the file's length means it doesn't contain a
whole number of what it expects.

> Data did not fit into device, due to bad blocks

That's just a secondary error caused by the first that can be ignored;
a bug in nandwrite.

https://github.com/vamanea/mtd-utils/blob/master/nandwrite.c#L46 says -o
means image contains OOB data, but we've stripped it out so the
nandwrite -on $dev $f
you have needs to be
nandwrite -n $dev $f

That's assuming it's okay to write the data without the OOB part;
I don't know about mtd but that's the implication I picked up from
earlier in this thread.

-- 
Cheers, Ralph.

___
e3-hacking mailing list
e3-hacking@earth.li
https://www.earth.li/mailman/listinfo/e3-hacking


Re: [E3-hacking] Config / content filesystem

2019-04-23 Thread Ralph Corderoy
Hi Nick,

> its just a command line version because the E3 is not powerful to run
> proper Linux.

Linux as you know it is three main parts.  There's the kernel, that's
what Linux really is, and it talks to the hardware.  Atop of that are
the user-space programs, like the shell, ls(1), etc.  They give you the
command line that many of us appreciate.  And then a bunch of user-space
programs can together provide a graphical environment with windows,
menus, etc.;  a `desktop', like Gnome, or XFCE.  Linux distributions
bundle those all up together.

So the E3 is powerful enough to run a Linux kernel, but doesn't have
enough memory to run a modern version, just as Intel 386 processors are
no longer supported.

> If I can’t put the original firmware back

That should be possible as you have the files, now without their
16 bytes per 512 bytes overhead.  You need to work out how many blocks
to erase based on the size of each file you're trying to put back.
IIRC I pointed out a block is the unit of erasure and it's 16 KiB.

-- 
Cheers, Ralph.

___
e3-hacking mailing list
e3-hacking@earth.li
https://www.earth.li/mailman/listinfo/e3-hacking


Re: [E3-hacking] Config / content filesystem

2019-04-23 Thread Ralph Corderoy
Hi Nick,

> Does anyone want the E3 adverts, they are not big, there are 7 of them
> in gif format they are the same size as the screen on the E3 is
> 480x320, I can upload them

Yes, do that, e.g. to Dropbox like with the other files.  I expect I'm
not the only one to squirrel stuff away so copies live on.

-- 
Cheers, Ralph.

___
e3-hacking mailing list
e3-hacking@earth.li
https://www.earth.li/mailman/listinfo/e3-hacking


Re: [E3-hacking] Config / content filesystem

2019-04-22 Thread Ralph Corderoy
Hi Jonathan,

> So, the MTD partitions do not directly map to a kernel or a Linux
> filesystem. The "Q;Q;" blocks are an Amstrad specific way of putting
> data into those partitions, with a type + description associated with
> each one. For example the kernel lives in a Q;Q; block in mtd3 called
> "LINUX". mtd3 also has Q;Q; blocks for LDR (the second stage boot
> loader), and PARMS (the kernel boot parameters).

Agreed.  I guessed a 32-byte struct based on various `Q;Q;'s seen.

$ qq() {
> LC_ALL=C perl -0777ne 'print $& while /Q;Q;.{0,32}/g' "$@" |
> hexdump -ve '36/1 "%_p" "\n"';
> }
$
$ qq e3-nand-backup.3
Q;Q;...@MEM.
Q;Q;PARMS...
Q;Q;Hf..LDR.
Q;Q;.x..LINUX...
$

> The CRAMFS filesystem is in mtd4; Q;Q; block name "LNXFSYS". There are
> 2 of them (I imagine to allow for an active + fallback).

$ qq e3-nand-backup.4 | grep LNXFSYS
Q;Q;LNXFSYS.
Q;Q;...6LNXFSYS.
$

> There are various other bits of content in mtd4 too - you can see them
> by doing:
>
>  hexdump -C e3-nand-backup.4 | grep -A 1 "Q;Q;"

That's where my 32-byte-long guess comes unstuck.  A Q;Q; appears within
the structs around LIBC's.

$ qq e3-nand-backup.4 | fgrep -3 .LIBC
Q;Q;..^.. ..WTL_MAILCON.
Q;Q;. ..WTL_RES.
Q;Q;..M.  Q;Q;. 
Q;Q;. ..LIBC
Q;Q;. Q;Q;...Q. 
..WTL_WAV.Q;Q;. 
..WTL_CHUNK...Q;Q;..$.. 
$

And so it's out of step for a while.  Perhaps there's Q;Q;-formatted
data inside a Q;Q; block, or the last struct in the initial `list' is
shorter and its struct's content indicate that.

$ qq e3-nand-backup.4 | grep -1 ^Q | grep -3 ^-
Q;Q;. ..LIBC
Q;Q;. Q;Q;...Q. 
..WTL_WAV.Q;Q;. 
--
..M_USERPREF..Q;Q;.V
Q;Q;.1..M_WTL_WTAI..
Q;Q;.A..M_VPARSE
$

I expect a bit of peering at the words in each struct would spot a
length or similar of each `file's data to save searching through for the
next Q;Q;.

-- 
Cheers, Ralph.

___
e3-hacking mailing list
e3-hacking@earth.li
https://www.earth.li/mailman/listinfo/e3-hacking


Re: [E3-hacking] Config / content filesystem

2019-04-20 Thread Ralph Corderoy
Hi Nick,

> sudo nand-oob-strip.py e3-nand-backup.0 e3-nand.0: No such file or
> directory

Two things.  You probably don't need sudo as your ordinary user should
be able to read e3-nand-backup.0 and write e3-nand.0.  You have to
specify a path to the nand-oob-strip.py script for the shell to find it.
Since it's in the current directory, that's just `.', i.e.

./nand-oob-strip.py in.0 out.0

If that complains, then it's because ./nand-oob-strip.py lacks the
`execute' permission for you.  Either add it with chmod(1), or run the
Python interpreter directly:

python3 nand-oob-strip.py in.0 out.0

Alternatively, to modify the file in place, so ensure they're not your
only copies, you can do

LC_ALL=C perl -i -0777pe 's/(.{512})(.{16})/$1/gs' \
e3-nand-backup.{0..5}

which substitutes every 512 bytes followed by 16 bytes with just the
512.

-- 
Cheers, Ralph.

___
e3-hacking mailing list
e3-hacking@earth.li
https://www.earth.li/mailman/listinfo/e3-hacking


Re: [E3-hacking] Trying to Flashing the backup of the Original Firmware Again

2019-04-18 Thread Ralph Corderoy
Hi Nick,

> looks like it has bad blocks too and they and made the files bigger in
> size than the partition..???

No, I don't think so.

> Image 3784704 bytes, NAND page 512 bytes, OOB area 512 bytes, device size 
> 3670016 bytes
...
> Image 270336 bytes, NAND page 512 bytes, OOB area 512 bytes, device size 
> 262144 bytes
...
> Image 270336 bytes, NAND page 512 bytes, OOB area 512 bytes, device size 
> 262144 bytes
...
> Image 29196288 bytes, NAND page 512 bytes, OOB area 512 bytes, device size 
> 28311552 bytes

3784704 - 3670016 = 114,688
114,688 / 1024 = 112
3670016 / 1024 / 32 = 112
3784704 / 3670016 = 1.03125

270336 - 262144 = 8,192
8,192 / 1024 = 8
262144 / 1024 / 32 = 8
270336 / 262144 = 1.03125

29196288 - 28311552 = 884,736
884,736 / 1024 = 864
28311552 / 1024 / 32 = 864
29196288 / 28311552 = 1.03125

1 / (1.03125 - 1) = 32

The image is always the same factor bigger than the device size, 1/32th,
suggesting a consistent overhead in the data format.

-- 
Cheers, Ralph.

___
e3-hacking mailing list
e3-hacking@earth.li
https://www.earth.li/mailman/listinfo/e3-hacking


Re: [E3-hacking] Is it possible to install a Desktop Environment into E3 Linux

2019-04-15 Thread Ralph Corderoy
Hi Nick,

> Has anyone got any ideas on how to show a gif on the E3 screen..?

If you have a working framebuffer then fbvis is a image viewer by
Ali Gholami Rudi who no longer uses X11.  See his `FRAMEBUFFER' section.
http://litcave.rudi.ir/

-- 
Cheers, Ralph.

___
e3-hacking mailing list
e3-hacking@earth.li
https://www.earth.li/mailman/listinfo/e3-hacking


Re: [E3-hacking] Understanding the E3s Partitions

2019-04-14 Thread Ralph Corderoy
Hi Nick,

> On Putty it just comes up with this and that's it..
> “Amstrad Delta - PBL V4.9 Build:1311 Assert Debug ICE
> PBL 32MB NAND
> 0MB.-->MEMv01.00.002,CopyLim=0022h,CodeEnd=0140h-->PBL..1MB...2MB*”
> Dam have to buy another one now.

I agree with David; PBL survives, by design, and you can try again.

You later write:
> Its lights flash when you plug it in and thats it pbltool says
> probbing and nothing else...?

You'd need to look into what pbltool is seeking and not finding.
But as long as you're still getting PBL printing out its banner, it's
there and willing to alter the main flash memory for you.

-- 
Cheers, Ralph.

___
e3-hacking mailing list
e3-hacking@earth.li
https://www.earth.li/mailman/listinfo/e3-hacking


Re: [E3-hacking] Understanding the E3s Partitions

2019-04-14 Thread Ralph Corderoy
Hi Nick,

> root@amsdelta:~# cat /proc/mtd
> dev:  size erasesize  name
> mtd0: 0038 4000 "Kernel"
> mtd1: 0004 4000 "u-boot"
> mtd2: 0004 4000 "u-boot params"
> mtd3: 0004 4000 "Amstrad LDR"
> mtd4: 01b0 4000 "File system"
> mtd5: 000c 4000 "PBL reserved"
> Just realised there are all the same Block size, look at the erasesize.

Yes, all 16 KiB.

> “flash_erase /dev/mtd0 0 16” whats the 16 for at the end of the line,
> is it what block size to  erase, ( can’t work out what number to put
> there)could I just erase the whole partition(mtd0) with “flash_erase
> /dev/mtd0 0 0”..? I don’t want to made a mistake..??

See https://github.com/vamanea/mtd-utils/blob/master/flash_erase.c#L60

-- 
Cheers, Ralph.

___
e3-hacking mailing list
e3-hacking@earth.li
https://www.earth.li/mailman/listinfo/e3-hacking


Re: [E3-hacking] Understanding the E3s Partitions

2019-04-13 Thread Ralph Corderoy
Hi Nick,

> if [ -e /media/sda1/e3-nand-backup.0 ]; then
>  echo Found e3-nand-backup.0
>  echo "  Erasing /dev/mtd0"
>  flash_erase /dev/mtd0 0 16
>  echo "  Writing e3-nand-backup.0 to /dev/mtd0"
>  nandwrite -on /dev/mtd0 /media/sda1/e3-nand-backup.0
> fi

Parameterise the code to extract the error-prone repetition,
and avoid the reader having lots of versions to compare.

perhaps_write_flash()
{
p=${1?} erase=${2?}
f=/media/sda1/e3-nand-backup.$p
dev=/dev/mtd$p

test -e $f || return

echo found $f
echo erasing $erase on $dev
flash_erase $dev 0 $erase
echo writing flash
nandwrite -on $dev $f
}

perhaps_write_flash 0 16
perhaps_write_flash 1 ...

Untested, obviously.

-- 
Cheers, Ralph.

___
e3-hacking mailing list
e3-hacking@earth.li
https://www.earth.li/mailman/listinfo/e3-hacking


Re: [E3-hacking] Understanding the E3s Partitions

2019-04-13 Thread Ralph Corderoy
Hi Nick,

> Mtd0,2,3,4,5 Size 16384,Page Size 512, 00B Size 16
> only need to restore mtd0,1,3 and 4 so ones with a * on.
> mtd0: Dumping Data Starting at 0x and ending at 0x0030*
> mtd1: Dumping Data Starting at 0x and ending at 0x0004*
> mtd2: Dumping Data Starting at 0x and ending at 0x0004
> mtd3: Dumping Data Starting at 0x and ending at 0x0004*
> mtd4: Dumping Data Starting at 0x and ending at 0x01b0*
> mtd5: Dumping Data Starting at 0x and ending at 0x000c
>
> I don’t know how much of the Nand you would need to erase for each
> partition..?

I don't quite understand the question.  Those `ending' values suggest
the size of each partition given all the `starting' are zero?  You need
to find out what that first line of information means.  I suspect `Size'
is the number of pages and `Page Size' is in bytes.  That would mean
8 MiB in total.

Depending on the flash device, the smallest erasable amount might be a
block of pages.

-- 
Cheers, Ralph.

___
e3-hacking mailing list
e3-hacking@earth.li
https://www.earth.li/mailman/listinfo/e3-hacking


Re: [E3-hacking] Understanding the E3s Partitions

2019-04-13 Thread Ralph Corderoy
Hi Nick,

> mtd0 - kernel
> mtd1 - PBL ( Maybe, I say this because Uboot is flashed there.)

Aren't PBL and Uboot two distinct separate things?  PBL was written by
Clive at Amstrad.  On the E2, it's the sole occupant of the small 64 KiB
flash so it isn't at risk of corruption when it writes to the main 8 MiB
flash.
https://inputplus.co.uk/ralph/emailer/emailerplus.html#hardware-ics

> What are mtd2 and mtd5 used for..??
> Trying to find out what each Partition is used for?

If you have extracted the contents of those partitions then start poking
around their contents.  file(1), hexdump(1), etc.  And Google some
resources on reverse-engineering flash blobs to identify their contents.

> One of the problem with the E2 is it don’t run Linux
...
> The E3 had a different CPU because it need a MMU for the Colour LCD
> screen so need to be more powerful than the E1,E2.

I think Clive wanted to take advantage of Linux for the E3, given its
higher, more complex, workload and thus needed the MMU.

-- 
Cheers, Ralph.

___
e3-hacking mailing list
e3-hacking@earth.li
https://www.earth.li/mailman/listinfo/e3-hacking


Re: [E3-hacking] Fw: I found Cliff Lawson old website about Amstrad

2019-04-07 Thread Ralph Corderoy
Hi Nick,

>read   
>   Reads data from RAM into the specified file
>readflash   
>   Reads data from the NAND flash (very, very slowly)

Is it the distinction between RAM and NAND flash that's confusing you?
Otherwise, they're pretty similar.

> Not beaning funny but posting on here is hard, I have never used email
> so much,well I don’t use email

It's always a good time to learn to use email properly.  It's the core
of many projects' communications.  Lots of data can flow into email,
e.g. RSS feed readers, and cron-job output.  And there are many programs
that can read it, search it, and store it as a text file per email for
access by the normal Unix text processing tools.  Email is king.  :-)

-- 
Cheers, Ralph.

___
e3-hacking mailing list
e3-hacking@earth.li
https://www.earth.li/mailman/listinfo/e3-hacking


Re: [E3-hacking] Fw: I found Cliff Lawson old website about Amstrad

2019-04-07 Thread Ralph Corderoy
Hi Nick,

> Can someone who knows Cliff contact him to ask how the Amstrad Emailer
> deactivates itself or locks its features please…? I don’t see why you
> wouldn’t tell us now the device is obsolete

I expect he's probably divulged everything he can recall after quite a
few contacts over the years.

> I need to know how it locks and how it does it, if we know then we
> might be able to find a way to activate, unlock them.

Isn't it the lack of being able to `phone home' that causes it to
deactivate after a while?  I seem to recall discussion on this list
about hooking up a modem in place of the phone line to `take' the call.
`AT+VTS' generates a dial tone?  These days, perhaps a
Asterisk/PoTS/VoIP bit of hardware could do similar.

> Has anyone managed to backed up there NAND from the E3,if so did you
> backup it when the Emailer was activated, if yes to both please can
> you shear it

Good idea.

The older firmware, before it got encrypted, could be disassembled and
studied some more, probably easier now than then with tool advancements,
and the phone-call code found so it can be stubbed out and the firmware
re-programmed.

-- 
Cheers, Ralph.

___
e3-hacking mailing list
e3-hacking@earth.li
https://www.earth.li/mailman/listinfo/e3-hacking


Re: [E3-hacking] About connecting to the serial on the E3

2019-04-03 Thread Ralph Corderoy
Hi,

> Oh yeah, there's more information here.
> http://www.earth.li/~noodles/hardware-e3.html

And there might still be some useful information amongst my old pages.
https://inputplus.co.uk/ralph/emailer/

-- 
Cheers, Ralph.

___
e3-hacking mailing list
e3-hacking@earth.li
https://www.earth.li/mailman/listinfo/e3-hacking


Re: [E3-hacking] E3 with Linux, login and p/word required please?

2017-04-12 Thread Ralph Corderoy
Hi Paul,

> I have found an E3 with a Linux kernel installed. After it has booted
> up it is asking for an Amsdelta login and password. Does anyone know
> what the login and password are please?

Can you tell what the bootloader is?  Does it give the ability to modify
the kernel's parameters?  You should be able to gain root access with
`single' or `init=/bin/sh' in the normal, non-Amstrad, manner.

-- 
Cheers, Ralph.
https://plus.google.com/+RalphCorderoy

___
e3-hacking mailing list
e3-hacking@earth.li
https://www.earth.li/mailman/listinfo/e3-hacking


Re: [E3-hacking] em2001uk

2012-10-28 Thread Ralph Corderoy
Hi Anthony,

 All I want is to use it as an ordinary phone.

If Linux isn't an aim then I'll email you the contact details of the
Emailer's designer off-list;  perhaps he can help if you contact him
directly.

Cheers, Ralph.

___
e3-hacking mailing list
e3-hacking@earth.li
http://www.earth.li/cgi-bin/mailman/listinfo/e3-hacking


Re: [E3-hacking] Just got an e3 - where do I start

2012-10-17 Thread Ralph Corderoy
Hi Edward,

Thanks for coming back to us with the info from Cliff.

 If I understand correctly with PBL5.1 the machine wont accept an image
 over serial though, so this would have to be done by dialling in to
 another modem?

Is that true?  IIRC, years ago Cliff suggested one way Amstrad could
meet my interpretation of their GPL2 requirements having implemented
signing was for me to send him my image for him to sign as part of the
build process.  His implication being that I could then upload it over
serial as before?

It could be 5.1's modem-only has been established as fact and I've
forgotten.

Cheers, Ralph.

___
e3-hacking mailing list
e3-hacking@earth.li
http://www.earth.li/cgi-bin/mailman/listinfo/e3-hacking


Re: [E3-hacking] Just got an e3 - where do I start

2012-07-27 Thread Ralph Corderoy
Hi Edward,

  Is it correct that no revenue is now made from the Emailer family;
  that the premium rate numbers have been closed, etc., and whoever
  bought the relevant part of Amstrad has no interest in operating it
  any more?  If so, could an approach to them to make available, e.g.
  signing key, for the benefit of those that want to tinker?  No skin
  off their nose now and if the right person is reached it may work,
  what with the increased prominence of the Maker movement, etc.
 
 This might work, though in my experience they may be prevented from
 helping simply by company policy or because the people with the
 relevant knowledge have moved on or are too busy to spend time on
 something that will generate no revenue. On the other hand it can't
 hurt to try... any idea what the best line of contact might be? Or how
 I should frame the question?

Cliff Lawson, the creator of the Emailer family, might know who owns the
rights and how to go about contacting them.  I'll send you his email
address off-list.  If they are effectively bricks without the Amstrad
infrastructure support then he may like to see them getting some use by
being opened up more.

Cheers, Ralph.

___
e3-hacking mailing list
e3-hacking@earth.li
http://www.earth.li/cgi-bin/mailman/listinfo/e3-hacking


[E3-hacking] Cliff Lawson?

2011-04-07 Thread Ralph Corderoy

Hi,

Sorry for the noise but does anyone have up to date contact details for
Cliff Lawson?  He's the E3's designer and has a long history at Amstrad.
He used to provide unofficial support for old machines by email and I'm
still getting the odd query sent to me after someone's done some
Googling but can no longer direct them to someone who may be able to
help.

Cheers,
Ralph.


___
e3-hacking mailing list
e3-hacking@earth.li
http://www.earth.li/cgi-bin/mailman/listinfo/e3-hacking


Re: [E3-hacking] Cliff Lawson?

2011-04-07 Thread Ralph Corderoy

Hi Matt,

 I assume his old Amstrad email address does not work?

Not when I last tried it some months/years ago.  He used to have a site
with details of old Amstrad equipment on but that too seems to have gone
now.  http://web.ukonline.co.uk/cliff.lawson/contact.htm

http://www.our-cottage.co.uk/html/finch.htm is also one of his but
there's no contact info there and WHOIS doesn't give an email address.

Perhaps he reads this list's digest and will pop up at the end of the
week.  :-)

Cheers,
Ralph.


___
e3-hacking mailing list
e3-hacking@earth.li
http://www.earth.li/cgi-bin/mailman/listinfo/e3-hacking


Re: [E3-hacking] Cliff Lawson?

2011-04-07 Thread Ralph Corderoy

Hi Piotr,

 I think he still posts on AVR Freaks

Thanks.  I've registered and PM'd clawson there.

Cheers,
Ralph.


___
e3-hacking mailing list
e3-hacking@earth.li
http://www.earth.li/cgi-bin/mailman/listinfo/e3-hacking


Re: [E3-hacking] [PATCH v2] LEDS: Add output invertion option to backlight trigger

2010-10-04 Thread Ralph Corderoy

Hi Janusz,

 struct led_classdev *led = n-led;
 struct fb_event *fb_event = data;
 int *blank = fb_event-data;
 int new_status = *blank ? BLANK : UNBLANK;
   
 switch (event) {
 case FB_EVENT_BLANK :
 if (new_status == n-old_status)
 break;
   
 if ((n-old_status == UNBLANK) ^ n-invert) {
 n-brightness = led-brightness;
 led_set_brightness(led, LED_OFF);
 } else {
 led_set_brightness(led, n-brightness);
 }
   
 n-old_status = new_status;
   
 break;
 }
   
 return 0;

This is a general question rather than a comment on the patch.  My gcc
for x86 with -O3 produces code that sets up led, blank, and new_status
before testing if event == FB_EVENT_BLANK.  Clearly, none of that work
is needed if the condition is false.

Is it assumed in kernel coding that the compiler is clever enough not to
do this, or that the extra work doesn't matter?

Cheers,
Ralph.


___
e3-hacking mailing list
e3-hacking@earth.li
http://www.earth.li/cgi-bin/mailman/listinfo/e3-hacking


Re: [E3-hacking] [PATCH v2 1/6] SoC Camera: add driver for OMAP1 camera interface

2010-09-21 Thread Ralph Corderoy

Hi Janusz,

   + 0x%0x\n, __func__, it_status);
   + 0x%0x\n, __func__, it_status);
   + dev_warn(dev, %s: format %#x not found\n, __func__,
   + dev_warn(icd-dev.parent, Format %#x not found\n,
 
  Two bytes could be saved with consistent use of %#x.  :-) 

 ...

 In the first two cases, I intended to keep the 0x prepended even if
 0. Am I missing something?

No, I didn't realise that was the intent.  I agree, if you want zero to
come out as 0x0 then you have to supply your own 0x.

 In next iteration, I'll probably use 0x%.8x when printing 32-bit
 register values. What do you think?

I'm probably more used to seeing 0x%08x, which is what I used to use
myself, but either gives the same result.  I stopped using it because I
found that the shape of the word is as relevant with hex as it is with
English.

0 0x80 0x800080
0x 0x0080 0x00800080

With the first line I can instantly see it's

Zero.
128 with the top-three bytes all zero.
Three bytes with the top byte zero.

With the second line I have to scan the 0 digits carefully, looking for
non-zeroes.

Cheers,
Ralph.


___
e3-hacking mailing list
e3-hacking@earth.li
http://www.earth.li/cgi-bin/mailman/listinfo/e3-hacking


Re: [E3-hacking] [PATCH v2 1/6] SoC Camera: add driver for OMAP1 camera interface

2010-09-19 Thread Ralph Corderoy

Hi Janusz,

 This is a V4L2 driver for TI OMAP1 SoC camera interface.

 + 0x%0x\n, __func__, it_status);
 + 0x%0x\n, __func__, it_status);
 + dev_warn(dev, %s: format %#x not found\n, __func__,
 + dev_warn(icd-dev.parent, Format %#x not found\n,

Two bytes could be saved with consistent use of %#x.  :-)  Does it make
sense to say `%0x' without giving a field width to pad to?  That's
another two bytes saved.  A veritable word!

Cheers,
Ralph.


___
e3-hacking mailing list
e3-hacking@earth.li
http://www.earth.li/cgi-bin/mailman/listinfo/e3-hacking