[edk2] [patch] MdeModulePkg/UsbMass: Revert changes of removing retry logic

2016-11-06 Thread Feng Tian
This patch is used to revert changes done in commit 17f3e942
bc527fbd75068d2d5752b6af54917487 - "MdeModulePkg/UsbMass: Not
retry if usb bot transfer execution fail"

It's because Usb Floppy will report DEVICE_ERROR for the first
several cmds when it need spin up. so retry logic makes sense.

Cc: Star Zeng 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Feng Tian 
---
 MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.c | 7 +--
 MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBot.c  | 8 ++--
 2 files changed, 3 insertions(+), 12 deletions(-)

diff --git a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.c 
b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.c
index d5de1ac..0c46f88 100644
--- a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.c
+++ b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.c
@@ -189,11 +189,6 @@ UsbBootExecCmd (
 return EFI_TIMEOUT;
   }
 
-  if (Status == EFI_DEVICE_ERROR) {
-DEBUG ((EFI_D_ERROR, "UsbBootExecCmd: Device Error to Exec 0x%x Cmd\n", 
*(UINT8 *)Cmd));
-return EFI_DEVICE_ERROR;
-  }
-
   //
   // If ExecCommand() returns no error and CmdResult is success,
   // then the commnad transfer is successful.
@@ -276,7 +271,7 @@ UsbBootExecCmdWithRetry (
DataLen,
Timeout
);
-if (Status == EFI_SUCCESS || Status == EFI_MEDIA_CHANGED || Status == 
EFI_NO_MEDIA || Status == EFI_DEVICE_ERROR) {
+if (Status == EFI_SUCCESS || Status == EFI_MEDIA_CHANGED || Status == 
EFI_NO_MEDIA) {
   break;
 }
 //
diff --git a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBot.c 
b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBot.c
index 4c29b61..4bb7222 100644
--- a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBot.c
+++ b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBot.c
@@ -2,7 +2,7 @@
   Implementation of the USB mass storage Bulk-Only Transport protocol,
   according to USB Mass Storage Class Bulk-Only Transport, Revision 1.0.
 
-Copyright (c) 2007 - 2016, Intel Corporation. All rights reserved.
+Copyright (c) 2007 - 2011, Intel Corporation. All rights reserved.
 This program and the accompanying materials
 are licensed and made available under the terms and conditions of the BSD 
License
 which accompanies this distribution.  The full text of the license may be 
found at
@@ -432,11 +432,7 @@ UsbBotExecCommand (
   // whether it succeeds or fails.
   //
   TransLen = (UINTN) DataLen;
-  Status   = UsbBotDataTransfer (UsbBot, DataDir, Data, , Timeout);
-  if (Status == EFI_DEVICE_ERROR) {
-DEBUG ((EFI_D_ERROR, "UsbBotExecCommand: UsbBotDataTransfer (%r)\n", 
Status));
-return Status;
-  }
+  UsbBotDataTransfer (UsbBot, DataDir, Data, , Timeout);
 
   //
   // Get the status, if that succeeds, interpret the result
-- 
2.7.1.windows.2

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


Re: [edk2] Unit tests and the EDK2

2016-11-06 Thread Matt Lazarowitz
I decided to give embUnit a try since it offers basic functionality without
the C standard libraries. I have my work available on github at
https://github.com/mattlazarowitz/UnitTestNoStdLibPkg

The embUnitSamples folder may give you an idea of what I am trying. I
create a new folder in the package and set up a new component in the
package. I'll add the library with a function I want to unit test and
create the tests. The inf is set up to build an application so it stands
alone and doe not necessarily need to be run on the target platform.
Drivers will potentially be more difficult to create unit tests for. Either
I need to be able to incorporate the obj files into an application in my
unit test package, or a unit test inf and associated C files that live next
to the driver would work but make for a messier file structure.
An engineer could architect a driver in such a way that most of it is built
as a library and pulled into a driver framework as another alternative.
If all the test can live in the package it should be somewhat easy for a
build automation system to gather and deploy the unit tests automatically.
A simulated environment would be great as a place to execute the tests for
fast feedback.

Hardware level tests will always be needed. Unit testing is just part of
the test pyramid which also has system level and integration tests. The
unit tests I have in mind are meant to provide rapid feedback to a
programmer before sinking time into longer tests.

I don't have any test doubles or any way to get inversion of control yet. I
hope a unit test package will be able to borrow from SCT as much as
possible.


A Microsoft authored unit test harness was mentioned earlier in this thread
which might be worth investigating as well. I took a quick look and it
seems very similar to what I was able to accomplish with embUnit. I'll have
to take a longer look to really compare it. One advantage of embUnit is
that is is fairly well documented and is stable code even if it doesn't
conform the the EDK2 coding standard.

I would also like to evaluate the StdLib package and see how well it will
work with some of the more advanced embUnit features that require the C
standard libraries.
I'm glad to hear I'm not the only one thinking about this.

Matt

On Sun, Nov 6, 2016 at 1:06 PM, Kinney, Michael D <
michael.d.kin...@intel.com> wrote:

> Marvin,
>
> UEFI environment.
>
> Emulated environments are great for some types of testing.
>
> OVMF is also interesting for something that is a bit closer to
> real HW without requiring the real hardware.
>
> And types of testing always requires a real HW target.
>
>
> Mike
>
> > -Original Message-
> > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Marvin H?user
> > Sent: Sunday, November 6, 2016 11:58 AM
> > To: edk2-devel@lists.01.org
> > Cc: Kinney, Michael D 
> > Subject: Re: [edk2] Unit tests and the EDK2
> >
> > Hey Mike,
> >
> > Is the framework you plan to RFC a framework within the UEFI environment
> (UEFI Shell)
> > or within the OS?
> > Using the OS implementations of UEFI (Nt32 & Emulator) to run Unit Tests
> without the
> > need for a separate UEFI device or a reboot sounds pretty compelling to
> me, to be
> > honest.
> >
> > Thank you very much!
> >
> > Regards,
> > Marvin.
> >
> > > -Original Message-
> > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> > > Kinney, Michael D
> > > Sent: Sunday, November 6, 2016 8:04 PM
> > > To: Blibbet ; edk2-devel@lists.01.org; Kinney,
> Michael
> > > D 
> > > Subject: Re: [edk2] Unit tests and the EDK2
> > >
> > > Hi,
> > >
> > > A test framework for EDK2 is one of my highest priorities to complete
> before
> > > the end of the year.
> > >
> > > I am evaluating a number of options and hope to put together a complete
> > > proposal as an RFC for consideration in the next few weeks.
> > >
> > > Thanks,
> > >
> > > Mike
> > >
> > >
> > > > -Original Message-
> > > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf
> Of
> > > > Blibbet
> > > > Sent: Sunday, November 6, 2016 9:26 AM
> > > > To: edk2-devel@lists.01.org
> > > > Subject: Re: [edk2] Unit tests and the EDK2
> > > >
> > > > On 11/06/2016 01:57 AM, Matt Lazarowitz wrote:
> > > > > I would like to find out if anyone has experience with an off the
> > > > > shelf unit test framework in the EDK2.[...]
> > > >
> > > > If you haven't looked at it, two months ago Microsoft open-sourced
> > > > some EDK2-centric unit tests.
> > > >
> > > > https://firmwaresecurity.com/2016/09/23/microsoft-uefi-unit-tests/
> > > >
> > > > Lee Fisher
> > > >
> > > >
> > > > ___
> > > > edk2-devel mailing list
> > > > edk2-devel@lists.01.org
> > > > https://lists.01.org/mailman/listinfo/edk2-devel
> > > ___
> > > edk2-devel mailing list
> > > 

Re: [edk2] [PATCH 0/4] Defer 3rd party images loading to after EndOfDxe

2016-11-06 Thread Ni, Ruiyu


Thanks/Ray

> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Saturday, November 5, 2016 12:48 AM
> To: Ni, Ruiyu ; Gao, Liming ;
> edk2-devel@lists.01.org 
> Subject: Re: [edk2] [PATCH 0/4] Defer 3rd party images loading to after
> EndOfDxe
> 
> On 11/04/16 07:09, Ni, Ruiyu wrote:
> > No.
> > The open source platform patch will be sent out later.
> 
> What are the deferred / 3rd party images? Do Driver and SysPrep
> qualify?

The images which are not from FV are treated as 3rd party images. And they will 
be
deferred to dispatch when they are dispatched before EndOfDxe event.
It's a new feature in the BS.LoadImage() path which can disallow executing
3rd party images before EndOfDxe and re-execute them after EndOfDxe.


> 
> Or, is this related to value 3 ("Defer execution when there is security
> violation") of:
> - PcdOptionRomImageVerificationPolicy,
> - PcdRemovableMediaImageVerificationPolicy,
> - PcdFixedMediaImageVerificationPolicy?

No.

> 
> Is the deferral documented somewhere in the UEFI spec, or do we have a
> Mantis ticket / ECR about it?
No.

> 
> Can we improve the commit messages please? From them, I have no idea
> how the deferral is supposed to work. (I.e., what the agents are, and how
> they interact.)
Yes. I will embed my first paragraph of reply in the commit message.

> 
> Thanks
> Laszlo
> 
> > From: Gao, Liming
> > Sent: Friday, November 4, 2016 1:14 PM
> > To: Ni, Ruiyu ; edk2-devel@lists.01.org
> > Subject: RE: [edk2] [PATCH 0/4] Defer 3rd party images loading to
> > after EndOfDxe
> >
> > Ray:
> >   Seemly, PlatformBdsLib library instance should call
> EfiBootManagerDispatchDeferredImages(), right? Are there patches to
> update PlatformBdsLib library instance?
> >
> > Thanks
> > Liming
> >> -Original Message-
> >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf
> >> Of Ruiyu Ni
> >> Sent: Friday, November 04, 2016 9:00 AM
> >> To: edk2-devel@lists.01.org
> >> Subject: [edk2] [PATCH 0/4] Defer 3rd party images loading to after
> >> EndOfDxe
> >>
> >> The patches change the default image loading policy by deferring 3rd
> >> party images loading to after EndOfDxe and add a new BDS API to
> >> dispatch the deferred images.
> >>
> >> Platform needs to call the new BDS API
> >> EfiBootManagerDispatchDeferredImages after EndOfDxe to ensure that
> >> any deferred images are loaded.
> >>
> >> Ruiyu Ni (4):
> >>   MdeModulePkg/SecurityStubDxe: Defer 3rd party image before
> EndOfDxe
> >>   MdeModulePkg/UefiBootManager: Add
> >> EfiBootManagerDispatchDeferredImages
> >>   MdeModulePkg/BdsDxe: Check deferred images before booting to OS
> >>   MdeModulePkg/SecurityStubDxe: Report failure if image is load
> >> earlier
> >>
> >>  MdeModulePkg/Include/Library/UefiBootManagerLib.h  |  13 +
> >>  MdeModulePkg/Library/UefiBootManagerLib/BmMisc.c   | 113 ++
> >>  .../Library/UefiBootManagerLib/InternalBm.h|   1 +
> >>  .../UefiBootManagerLib/UefiBootManagerLib.inf  |   1 +
> >>  MdeModulePkg/Universal/BdsDxe/Bds.h|   4 +-
> >>  MdeModulePkg/Universal/BdsDxe/BdsDxe.inf   |   2 +
> >>  MdeModulePkg/Universal/BdsDxe/BdsEntry.c   |  89 +
> >>  .../SecurityStubDxe/Defer3rdPartyImageLoad.c   | 413
> >> +
> >>  .../SecurityStubDxe/Defer3rdPartyImageLoad.h   |  95 +
> >>  .../Universal/SecurityStubDxe/SecurityStub.c   |  14 +-
> >>  .../Universal/SecurityStubDxe/SecurityStubDxe.inf  |  11 +-
> >>  11 files changed, 753 insertions(+), 3 deletions(-)  create mode
> >> 100644
> >> MdeModulePkg/Universal/SecurityStubDxe/Defer3rdPartyImageLoad.c
> >>  create mode 100644
> >> MdeModulePkg/Universal/SecurityStubDxe/Defer3rdPartyImageLoad.h
> >>
> >> --
> >> 2.9.0.windows.1
> >>
> >> ___
> >> edk2-devel mailing list
> >> edk2-devel@lists.01.org
> >> https://lists.01.org/mailman/listinfo/edk2-devel
> > ___
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
> >

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


Re: [edk2] [PATCH v2 1/2] MdeModulePkg: Do not free memory during ExitBootServices ().

2016-11-06 Thread Tian, Feng
Marvin,

The commit log is a little confusing. Please update the commit title to clarify 
it's only for Iscsi.

And I will leave this RB to network owner.

Thanks
Feng

-Original Message-
From: Marvin Häuser [mailto:marvin.haeu...@outlook.com] 
Sent: Friday, November 4, 2016 7:10 AM
To: edk2-devel@lists.01.org
Cc: Tian, Feng ; Zeng, Star 
Subject: [PATCH v2 1/2] MdeModulePkg: Do not free memory during 
ExitBootServices ().

During exiting Boot Services, there should be no changes made to the Memory 
Map. This patch eliminates explicit and implicit calls to the Memory Allocation 
Services and, where applicable, zeros the memory instead.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Marvin Haeuser 
---
 MdeModulePkg/Universal/Network/IScsiDxe/IScsiMisc.c | 11 +--
 MdeModulePkg/Universal/Network/SnpDxe/Snp.c | 12 
 2 files changed, 21 insertions(+), 2 deletions(-)

diff --git a/MdeModulePkg/Universal/Network/IScsiDxe/IScsiMisc.c 
b/MdeModulePkg/Universal/Network/IScsiDxe/IScsiMisc.c
index ae202c3fe24a..b5e36b8bec06 100644
--- a/MdeModulePkg/Universal/Network/IScsiDxe/IScsiMisc.c
+++ b/MdeModulePkg/Universal/Network/IScsiDxe/IScsiMisc.c
@@ -872,9 +872,16 @@ IScsiOnExitBootService (
   ISCSI_DRIVER_DATA *Private;
 
   Private = (ISCSI_DRIVER_DATA *) Context;
-  gBS->CloseEvent (Private->ExitBootServiceEvent);
 
-  IScsiSessionAbort (>Session);
+  if (Private->Session.Signature != 0) {
+IScsiSessionAbort (>Session);
+
+//
+// Empty Session as it will not be freed.
+// This will also prevent this code from being re-run.
+//
+ZeroMem (>Session, sizeof (Private->Session));  }
 }
 
 /**
diff --git a/MdeModulePkg/Universal/Network/SnpDxe/Snp.c 
b/MdeModulePkg/Universal/Network/SnpDxe/Snp.c
index 9f61aee05773..e15e79c7065f 100644
--- a/MdeModulePkg/Universal/Network/SnpDxe/Snp.c
+++ b/MdeModulePkg/Universal/Network/SnpDxe/Snp.c
@@ -32,6 +32,18 @@ SnpNotifyExitBootServices (
 
   Snp  = (SNP_DRIVER *)Context;
 
+  if (Snp->TxRxBuffer != NULL) {
+//
+// Empty TxRxBuffer as it will not be freed.
+//
+ZeroMem (Snp->TxRxBuffer, Snp->TxRxBufferSize);
+
+//
+// Set TxRxBuffer to NULL so FreeBuffer () will not be called.
+//
+Snp->TxRxBuffer = NULL;
+  }
+
   //
   // Shutdown and stop UNDI driver
   //
-- 
2.10.1.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


Re: [edk2] Unit tests and the EDK2

2016-11-06 Thread Kinney, Michael D
Marvin,

UEFI environment.

Emulated environments are great for some types of testing.

OVMF is also interesting for something that is a bit closer to 
real HW without requiring the real hardware.

And types of testing always requires a real HW target.


Mike

> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Marvin 
> H?user
> Sent: Sunday, November 6, 2016 11:58 AM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D 
> Subject: Re: [edk2] Unit tests and the EDK2
> 
> Hey Mike,
> 
> Is the framework you plan to RFC a framework within the UEFI environment 
> (UEFI Shell)
> or within the OS?
> Using the OS implementations of UEFI (Nt32 & Emulator) to run Unit Tests 
> without the
> need for a separate UEFI device or a reboot sounds pretty compelling to me, 
> to be
> honest.
> 
> Thank you very much!
> 
> Regards,
> Marvin.
> 
> > -Original Message-
> > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> > Kinney, Michael D
> > Sent: Sunday, November 6, 2016 8:04 PM
> > To: Blibbet ; edk2-devel@lists.01.org; Kinney, Michael
> > D 
> > Subject: Re: [edk2] Unit tests and the EDK2
> >
> > Hi,
> >
> > A test framework for EDK2 is one of my highest priorities to complete before
> > the end of the year.
> >
> > I am evaluating a number of options and hope to put together a complete
> > proposal as an RFC for consideration in the next few weeks.
> >
> > Thanks,
> >
> > Mike
> >
> >
> > > -Original Message-
> > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> > > Blibbet
> > > Sent: Sunday, November 6, 2016 9:26 AM
> > > To: edk2-devel@lists.01.org
> > > Subject: Re: [edk2] Unit tests and the EDK2
> > >
> > > On 11/06/2016 01:57 AM, Matt Lazarowitz wrote:
> > > > I would like to find out if anyone has experience with an off the
> > > > shelf unit test framework in the EDK2.[...]
> > >
> > > If you haven't looked at it, two months ago Microsoft open-sourced
> > > some EDK2-centric unit tests.
> > >
> > > https://firmwaresecurity.com/2016/09/23/microsoft-uefi-unit-tests/
> > >
> > > Lee Fisher
> > >
> > >
> > > ___
> > > edk2-devel mailing list
> > > edk2-devel@lists.01.org
> > > https://lists.01.org/mailman/listinfo/edk2-devel
> > ___
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
> ___
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


Re: [edk2] Unit tests and the EDK2

2016-11-06 Thread Blibbet
> I am evaluating a number of options and hope to put together
> a complete proposal as an RFC for consideration in the next
> few weeks.

For your evaluation, please also check out the U-Boot and coreboot
projects, they both have some built-in tests.

Thanks,
Lee Fisher


___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


Re: [edk2] Unit tests and the EDK2

2016-11-06 Thread Marvin H?user
Hey Mike,

Is the framework you plan to RFC a framework within the UEFI environment (UEFI 
Shell) or within the OS?
Using the OS implementations of UEFI (Nt32 & Emulator) to run Unit Tests 
without the need for a separate UEFI device or a reboot sounds pretty 
compelling to me, to be honest.

Thank you very much!

Regards,
Marvin.

> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Kinney, Michael D
> Sent: Sunday, November 6, 2016 8:04 PM
> To: Blibbet ; edk2-devel@lists.01.org; Kinney, Michael
> D 
> Subject: Re: [edk2] Unit tests and the EDK2
> 
> Hi,
> 
> A test framework for EDK2 is one of my highest priorities to complete before
> the end of the year.
> 
> I am evaluating a number of options and hope to put together a complete
> proposal as an RFC for consideration in the next few weeks.
> 
> Thanks,
> 
> Mike
> 
> 
> > -Original Message-
> > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> > Blibbet
> > Sent: Sunday, November 6, 2016 9:26 AM
> > To: edk2-devel@lists.01.org
> > Subject: Re: [edk2] Unit tests and the EDK2
> >
> > On 11/06/2016 01:57 AM, Matt Lazarowitz wrote:
> > > I would like to find out if anyone has experience with an off the
> > > shelf unit test framework in the EDK2.[...]
> >
> > If you haven't looked at it, two months ago Microsoft open-sourced
> > some EDK2-centric unit tests.
> >
> > https://firmwaresecurity.com/2016/09/23/microsoft-uefi-unit-tests/
> >
> > Lee Fisher
> >
> >
> > ___
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
> ___
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


Re: [edk2] Unit tests and the EDK2

2016-11-06 Thread Kinney, Michael D
Hi,

A test framework for EDK2 is one of my highest priorities to
complete before the end of the year.

I am evaluating a number of options and hope to put together 
a complete proposal as an RFC for consideration in the next 
few weeks.

Thanks,

Mike


> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Blibbet
> Sent: Sunday, November 6, 2016 9:26 AM
> To: edk2-devel@lists.01.org
> Subject: Re: [edk2] Unit tests and the EDK2
> 
> On 11/06/2016 01:57 AM, Matt Lazarowitz wrote:
> > I would like to find out if anyone has experience with an off the shelf
> > unit test framework in the EDK2.[...]
> 
> If you haven't looked at it, two months ago Microsoft open-sourced some
> EDK2-centric unit tests.
> 
> https://firmwaresecurity.com/2016/09/23/microsoft-uefi-unit-tests/
> 
> Lee Fisher
> 
> 
> ___
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


[edk2] Unit tests and the EDK2

2016-11-06 Thread Matt Lazarowitz
I would like to find out if anyone has experience with an off the shelf
unit test framework in the EDK2.
I'm currently experimenting with embUnit and have some of the project's
sample code running without using the StdLib package. My eventual goal is
to see if this can be used as an automated unit test system similar to what
is used in other areas of software development.

I'm at a point where I believe I could write some basic tests for library
function calls, but before I continue, I wanted to check if anyone else has
done any development with the same goal in mind.

Matt
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel