Re: [edk2] [PATCH] IntelFsp2Pkg: Remove unused keyword in new PPI header
Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chasel, Chiu Sent: Monday, January 21, 2019 1:56 PM To: edk2-devel@lists.01.org Cc: Zeng, Star Subject: [edk2] [PATCH] IntelFsp2Pkg: Remove unused keyword in new PPI header REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1477 There was unused keyword added in FspmArchConfigPpi.h header block and should be removed. Cc: Nate DeSimone Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chasel Chiu --- IntelFsp2Pkg/Include/Ppi/FspmArchConfigPpi.h | 1 - 1 file changed, 1 deletion(-) diff --git a/IntelFsp2Pkg/Include/Ppi/FspmArchConfigPpi.h b/IntelFsp2Pkg/Include/Ppi/FspmArchConfigPpi.h index 5bedb95aa7..0268f43b1e 100644 --- a/IntelFsp2Pkg/Include/Ppi/FspmArchConfigPpi.h +++ b/IntelFsp2Pkg/Include/Ppi/FspmArchConfigPpi.h @@ -1,7 +1,6 @@ /** @file Header file for FSP-M Arch Config PPI for Dispatch mode - @copyright Copyright (c) 2019, Intel Corporation. All rights reserved. This program and the accompanying materials are licensed and made available under -- 2.13.3.windows.1 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] [PATCH] IntelFsp2Pkg: Remove unused keyword in new PPI header
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1477 There was unused keyword added in FspmArchConfigPpi.h header block and should be removed. Cc: Nate DeSimone Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chasel Chiu --- IntelFsp2Pkg/Include/Ppi/FspmArchConfigPpi.h | 1 - 1 file changed, 1 deletion(-) diff --git a/IntelFsp2Pkg/Include/Ppi/FspmArchConfigPpi.h b/IntelFsp2Pkg/Include/Ppi/FspmArchConfigPpi.h index 5bedb95aa7..0268f43b1e 100644 --- a/IntelFsp2Pkg/Include/Ppi/FspmArchConfigPpi.h +++ b/IntelFsp2Pkg/Include/Ppi/FspmArchConfigPpi.h @@ -1,7 +1,6 @@ /** @file Header file for FSP-M Arch Config PPI for Dispatch mode - @copyright Copyright (c) 2019, Intel Corporation. All rights reserved. This program and the accompanying materials are licensed and made available under -- 2.13.3.windows.1 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] Unable to boot Linux with master EDK2
Hi Julien Grall I have committed the fix patch. https://github.com/tianocore/edk2/commit/eb76b76218d5bac867414e2ff6dd09c6e7c700dd Please trying the latest EDK2 master. Thanks, Dandan > -Original Message- > From: Julien Grall [mailto:julien.gr...@arm.com] > Sent: Saturday, January 19, 2019 2:30 AM > To: edk2-devel-01 ; Bi, Dandan > ; Gao, Liming > Cc: Leif Lindholm ; Ard Biesheuvel > ; Laszlo Ersek ; Kinney, > Michael D ; xen-devel de...@lists.xenproject.org> > Subject: Unable to boot Linux with master EDK2 > > Hi all, > > I am trying to boot a Xen guest using the latest EDK2 master (cce9d76358 > "BaseTools: Allow empty value for HiiPcd in Dsc"), GRUB and Linux 5.0-rc2. > > The last code executed by Linux is when installing the virtual address map in > the EFI stub and then it seems to get stuck. I don't have much information > from the console: > > InstallProtocolInterface: 5B1B31A1-9562-11D2-8E3F-00A0C969723B 7E041040 > Loading driver at 0x00068C7 EntryPoint=0x00069D65664 Loading driver at > 0x00068C7 EntryPoint=0x00069D65664 > InstallProtocolInterface: BC62157E-3E33-4FEC-9920-2D3B36D750DF 7DF6AB18 > ProtectUefiImageCommon - 0x7E041040 > - 0x68C7 - 0x02006000 > SetUefiImageMemoryAttributes - 0x68C7 - > 0x1000 (0x4008) SetUefiImageMemoryAttributes > - 0x68C71000 - 0x011CD000 (0x00020008) > SetUefiImageMemoryAttributes - 0x69E3E000 - > 0x00E38000 (0x4008) EFI stub: Booting Linux Kernel... > EFI stub: Using DTB from configuration table EFI stub: Exiting boot services > and installing virtual address map... > XenBus: Set state to 5 > XenBus: Set state to 5, done > XenPvBlk: waiting backend state 5, current: 4 > XenStore: Watch event 7E957398 > XenBus: Set state to 6 > XenBus: Set state to 6, done > XenPvBlk: waiting backend state 6, current: 5 > XenStore: Watch event 7E957398 > XenBus: Set state to 1 > XenBus: Set state to 1, done > Xen GrantTable, removing 38003 > Xen GrantTable, removing 38002 > Xen GrantTable, removing 38001 > Xen GrantTable, removing 38000 > SetUefiImageMemoryAttributes - 0x7F36 - > 0x0004 (0x0008) SetUefiImageMemoryAttributes > - 0x7BFF - 0x0004 (0x0008) > SetUefiImageMemoryAttributes - 0x7BFA - > 0x0004 (0x0008) SetUefiImageMemoryAttributes > - 0x7BF0 - 0x0004 (0x0008) > SetUefiImageMemoryAttributes - 0x7BE6 - > 0x0004 (0x0008) SetUefiImageMemoryAttributes > - 0x7BDC - 0x0004 (0x0008) > > The bisector pointed to the following commit: > > commit 2f4a5a9f4c17ed88aaa3114d1e161e42cb80a9bf > Author: Dandan Bi > Date: Thu Jan 3 15:31:23 2019 +0800 > > MdePkg/BasePeCoffLib: Add more check for relocation data > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1426 > > V2: > (1) Add NULL pointer check for the input parameters > (2) Add check for the "Adjust" value before applying fix ups. > > In function PeCoffLoaderRelocateImageForRuntime, it doesn't > do much check when do relocation. For API level consideration, > it's not safe enough. > So this patch is to replace the same code logic with function > PeCoffLoaderImageAddress which will cover more validation. > > Cc: Michael D Kinney > Cc: Liming Gao > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Dandan Bi > Reviewed-by: Liming Gao > > Any ideas what could have gone wrong? > > Best regards, > > -- > Julien Grall ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [patch] MdePkg/BasePeCoffLib: Correct the address of RelocBaseEnd
Reviewed-by: Liming Gao
>-Original Message-
>From: Bi, Dandan
>Sent: Friday, January 18, 2019 4:09 PM
>To: edk2-devel@lists.01.org
>Cc: Kinney, Michael D ; Gao, Liming
>
>Subject: [patch] MdePkg/BasePeCoffLib: Correct the address of RelocBaseEnd
>
>REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1426
>
>When calculating the address of RelocBaseEnd,
>the RelocBase address is ImageBase + RelocDir->VirtualAddress,
>the size of RelocDir is RelocDir->Size.
>So the RelocBaseEnd address is:
>ImageBase + RelocDir->VirtualAddress + RelocDir->Size - 1
>not
>ImageBase + RelocDir->VirtualAddress + RelocDir->Size
>
>This patch is to fix this issue when call PeCoffLoaderImageAddress
>function to calculate the address of RelocBaseEnd.
>
>Cc: Michael D Kinney
>Cc: Liming Gao
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Dandan Bi
>---
> MdePkg/Library/BasePeCoffLib/BasePeCoff.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/MdePkg/Library/BasePeCoffLib/BasePeCoff.c
>b/MdePkg/Library/BasePeCoffLib/BasePeCoff.c
>index d9c94b89bd..1bd079ad6a 100644
>--- a/MdePkg/Library/BasePeCoffLib/BasePeCoff.c
>+++ b/MdePkg/Library/BasePeCoffLib/BasePeCoff.c
>@@ -1741,11 +1741,11 @@ PeCoffLoaderRelocateImageForRuntime (
> //
> if (NumberOfRvaAndSizes > EFI_IMAGE_DIRECTORY_ENTRY_BASERELOC) {
> RelocDir = DataDirectory + EFI_IMAGE_DIRECTORY_ENTRY_BASERELOC;
> RelocBase = (EFI_IMAGE_BASE_RELOCATION *)
>PeCoffLoaderImageAddress (, RelocDir->VirtualAddress, 0);
> RelocBaseEnd = (EFI_IMAGE_BASE_RELOCATION *)
>PeCoffLoaderImageAddress (,
>-
>RelocDir->VirtualAddress + RelocDir-
>>Size,
>+
>RelocDir->VirtualAddress + RelocDir-
>>Size - 1,
> 0
> );
> } else {
> //
> // Cannot find relocations, cannot continue to relocate the image, ASSERT
>for this invalid image.
>--
>2.18.0.windows.1
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH v2 1/3] MdeModulePkg/Dhcp4Dxe: Remove unnecessary NULL pointer check.
> >> This is my idea to avoid the duplicated mail. I also include Ard and > >> Laszlo to > collect the feedback on how to handle the partial update in the patchset. > >> > > > > Laszlo may disagree with me, but I think that it is not always > > necessary to resend the entire series when only a single patch > > changes. It does depend on the situation, though: if it is a trivial > > patch in a more complicated series then it might make little sense. In > > other case, just resending the whole thing is probably better. > > I think resending one patch can be acceptable, but the subject line > (patch nr) and the threading have to be correct. Also, I don't think > this approach scales beyond exactly one patch-update; it's easy to lose > track of version numbers etc. So "use sparingly" I guess? :) > Thanks all of your comments, to avoid the missing version track, I have resent the whole patch to version 3:). Best Regard! Jiaxin ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [staging/UEFI_Redfish][PATCH v1] Announce to create "UEFI_Redfish" branch in edk2-staging.
Good suggestion. Thanks Leif. Already resubmit as version 2. > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Friday, January 18, 2019 9:19 PM > To: Wu, Jiaxin > Cc: edk2-devel@lists.01.org; Wang, Fan ; Ye, Ting > ; Li, Ruth ; Kinney, Michael D > ; Fu, Siyuan > Subject: Re: [edk2] [staging/UEFI_Redfish][PATCH v1] Announce to create > "UEFI_Redfish" branch in edk2-staging. > > Hi Jiaxin, > > I am happy to see the creation of this branch. However, Could you > possibly resubmit this as a diff adding a Readme.md rather than > modifying it? > > The diff against edk2/Readme.md is not really relevant, and confuses review. > > (For example, in your branch, *delete* the existing Readme.md in a > separate commit, and then in the commit next *add* the one for the > branch. Only the *add* patch needs to be reviewed.) > > Best Regards, > > Leif > > On Fri, Jan 18, 2019 at 05:42:40PM +0800, Jiaxin Wu wrote: > > UEFI_Redfish branch is to develop the UEFI Redfish feature. The code base > > of development is based on the release of edk2-stable201811 tag. Please > > refer to the patch of Readme.md to get the detailed feature introduction. > > > > Note: The branch will be created by the end of Jan 28th if no objection. > > > > Cc: Rothman Michael A > > Cc: Kinney Michael D > > Cc: Li Ruth > > Cc: Ye Ting > > Cc: Fu Siyuan > > Cc: Wang Fan > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Wu Jiaxin > > --- > > Readme.md | 114 > -- > > 1 file changed, 85 insertions(+), 29 deletions(-) > > > > diff --git a/Readme.md b/Readme.md > > index 1ef0780ee0..b9b5ab38e2 100644 > > --- a/Readme.md > > +++ b/Readme.md > > @@ -1,29 +1,85 @@ > > -# EDK II Project > > - > > -A modern, feature-rich, cross-platform firmware development environment > > -for the UEFI and PI specifications from www.uefi.org. > > - > > -Contributions to the EDK II open source project are covered by the > > -[TianoCore Contribution Agreement 1.1](Contributions.txt) > > - > > -The majority of the content in the EDK II open source project uses a > > -[BSD 2-Clause License](License.txt). The EDK II open source project > > contains > > -the following components that are covered by additional licenses: > > -* [AppPkg/Applications/Python/Python- > 2.7.2/Tools/pybench](AppPkg/Applications/Python/Python- > 2.7.2/Tools/pybench/LICENSE) > > -* [AppPkg/Applications/Python/Python- > 2.7.2](AppPkg/Applications/Python/Python-2.7.2/LICENSE) > > -* [AppPkg/Applications/Python/Python- > 2.7.10](AppPkg/Applications/Python/Python-2.7.10/LICENSE) > > -* > [BaseTools/Source/C/BrotliCompress](BaseTools/Source/C/BrotliCompress/LIC > ENSE) > > -* > [MdeModulePkg/Library/BrotliCustomDecompressLib](MdeModulePkg/Library/ > BrotliCustomDecompressLib/LICENSE) > > -* [OvmfPkg](OvmfPkg/License.txt) > > -* > [CryptoPkg/Library/OpensslLib/openssl](CryptoPkg/Library/OpensslLib/openssl/ > LICENSE) > > - > > -The EDK II Project is composed of packages. The maintainers for each > package > > -are listed in [Maintainers.txt](Maintainers.txt). > > - > > -# Resources > > -* [TianoCore](http://www.tianocore.org) > > -* [EDK II](https://github.com/tianocore/tianocore.github.io/wiki/EDK-II) > > -* [Getting Started with EDK > II](https://github.com/tianocore/tianocore.github.io/wiki/Getting-Started-with- > EDK-II) > > -* [Mailing > Lists](https://github.com/tianocore/tianocore.github.io/wiki/Mailing-Lists) > > -* [TianoCore Bugzilla](https://bugzilla.tianocore.org) > > -* [How To > Contribute](https://github.com/tianocore/tianocore.github.io/wiki/How-To- > Contribute) > > +This branch is used to develop the **UEFI Redfish Feature**. The code base > of development is based on the release of **edk2-stable201811** tag. > > + > > +The branch owner: > > +Fu Siyuan , Ye Ting , Wang Fan > , Wu Jiaxin > > + > > +## Introduction > > +UEFI Redfish is an efficient and secure solution for end users to remote > control and configure UEFI pre-OS environment by leveraging the RESTful API. > It's simple for end users to access the data from UEFI firmware defined in > JSON > format. > > + > > +One of the design goals for UEFI Redfish solution is to provide a scalable > implementation which allow users to easily add/remove/modify each > independent Redfish configure features (RedfishBiosDxe & RedfishBootInfoDxe). > This is done by extracting the generic logic to a single UEFI driver model > driver > (RedfishConfigDxe), and several library instances (DxeRedfishLib & > BaseJsonLib). > > + > > + Supported Features > > + * Protocols > > +* EFI RestEx Service Binding Protocol > > +* EFI RestEx Protocol > > +* Redfish ConfigHandler Protocol > > +* Redfish Credential Protocol > > + > > + * Configuration Items via UEFI Redfish > > +* [ISCSI Boot Keywords](http://www.uefi.org/confignamespace). > > +* HII Opcodes/Questions marked with REST_SYTLE
[edk2] [staging/UEFI_Redfish][PATCH v2] Announce to create "UEFI_Redfish" branch in edk2-staging.
v2: Resend the patch as diff adding instead of modifying. UEFI_Redfish branch is to develop the UEFI Redfish feature. The code base of development is based on the release of edk2-stable201811 tag. Please refer to the patch of Readme.md to get the detailed feature introduction. Note: The branch will be created by the end of Jan 28th if no objection. Cc: Leif Lindholm Cc: Rothman Michael A Cc: Kinney Michael D Cc: Li Ruth Cc: Ye Ting Cc: Fu Siyuan Cc: Wang Fan Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Wu Jiaxin --- Readme.md | 85 +++ 1 file changed, 85 insertions(+) create mode 100644 Readme.md diff --git a/Readme.md b/Readme.md new file mode 100644 index 00..b9b5ab38e2 --- /dev/null +++ b/Readme.md @@ -0,0 +1,85 @@ +This branch is used to develop the **UEFI Redfish Feature**. The code base of development is based on the release of **edk2-stable201811** tag. + +The branch owner: +Fu Siyuan , Ye Ting , Wang Fan , Wu Jiaxin + +## Introduction +UEFI Redfish is an efficient and secure solution for end users to remote control and configure UEFI pre-OS environment by leveraging the RESTful API. It's simple for end users to access the data from UEFI firmware defined in JSON format. + +One of the design goals for UEFI Redfish solution is to provide a scalable implementation which allow users to easily add/remove/modify each independent Redfish configure features (RedfishBiosDxe & RedfishBootInfoDxe). This is done by extracting the generic logic to a single UEFI driver model driver (RedfishConfigDxe), and several library instances (DxeRedfishLib & BaseJsonLib). + + Supported Features + * Protocols +* EFI RestEx Service Binding Protocol +* EFI RestEx Protocol +* Redfish ConfigHandler Protocol +* Redfish Credential Protocol + + * Configuration Items via UEFI Redfish +* [ISCSI Boot Keywords](http://www.uefi.org/confignamespace). +* HII Opcodes/Questions marked with REST_SYTLE flag or in REST_SYTLE formset. +* BootOrder/BootNext variables. + + * Redfish Schemas +* [AttributeRegistry](https://redfish.dmtf.org/schemas/v1/AttributeRegistry.v1_1_0.json) +* [ComputerSystemCollection](https://redfish.dmtf.org/schemas/ComputerSystemCollection.json) +* [ComputerSystem](https://redfish.dmtf.org/schemas/v1/ComputerSystem.v1_5_0.json) +* [Bios](https://redfish.dmtf.org/schemas/v1/Bios.v1_0_2.json) +* [BootOptionCollection](https://redfish.dmtf.org/schemas/BootOptionCollection.json) +* [BootOption](https://redfish.dmtf.org/schemas/BootOption.v1_0_0.json) + +If any additional Redfish Schema or a new version of above Schemas are required to be supported, please send the email to edk2-devel mailing list by following [edk2-satging process](https://github.com/tianocore/edk2-staging). + + Related Modules + The following modules are related to UEFI Redfish solution, **RedfishPkg** is the new package to support UEFI Redfish solution: + * **RedfishPkg\RestExDxe\RestExDxe.inf** - UEFI driver to enable standardized RESTful access to resources from UEFI environment. + + * **RedfishPkg\Library\DxeRedfishLib** - Library to Create/Read/Update/Delete (CRUD) resources and provide basic query abilities by using [URI/RedPath](https://github.com/DMTF/libredfish). + + * **RedfishPkg\Library\BaseJsonLib** - Library to encode/decode JSON data. + + * **RedfishPkg\RedfishConfigDxe\RedfishConfigDxe.inf** - UEFI driver to execute registered Redfish Configuration Handlers: + +* **RedfishPkg\Features\RedfishBiosDxe\RedfishBiosDxe.inf** - DXE driver to register Redfish configuration handler to process "Bios" schema and "AttributeRegistry" schema. + +* **RedfishPkg\Features\Features\RedfishBootInfoDxe\RedfishBootInfoDxe.inf** - DXE driver to register Redfish configuration handler to process Boot property defined in "ComputerSystem" schema. + + * Platform Components for NT32: +* **Nt32Pkg\RedfishPlatformDxe\RedfishPlatformDxe.inf** - UEFI sample platform driver for NT32 to fill the SMBIOS table 42 and publish Redfish Credential info. + +* **Nt32Pkg\Application\RedfishPlatformConfig\RedfishPlatformConfig.inf** - UEFI application for NT32 to publish Redfish Host Interface Record. + + * Misc + * BaseTools - VfrCompile changes to support Rest Style Formset/Flag. + + * MdePkg - Headers related to Rest Style Formset/Flag. + + * MdeModulePkg - Extract more general APIs in UefiHiiLib & DxeHttpLib & DxeNetLib. + + * NetworkPkg - 1) UefiPxeBcDxe & HttpBootDxe: Consume new APIs defined in DxeHttpLib & DxeNetLib. 2) HttpDxe: Cross-Subnet support. 3) IScsiDxe: REST Style FORMSET support. + + * Nt32Pkg - 1) Enable UEFI Redfish feature in NT32 platform. 2) Fix TLS build error with CryptoPkg from edk2-stable201811 tag. + + +## Promote to edk2 Trunk +If a subset feature or a bug fix in this staging branch could meet below requirement, it could
