Re: [edk2] [PATCH] [edk2 EmbeddedPkg]:Adding secure boot and HTTP image download (Disaster recovery image) Applications for Linux based platforms

[Kalyan Nagabhirava]

sure Leif , we will address your review comments and send updated patches.

Regards,
kalyan.

On 4 December 2017 at 21:03, Leif Lindholm  wrote:

> Hi Kalyan,
>
> Am I right in assuming that since this is the output of your team, you
> have some time to look into reworking based on feedback (unlike the
> HiKey support)?
>
> A few high-level comments:
> 1) Please generate your patches with --stat=1000 --stat-graph-width=20
>as per https://github.com/tianocore/tianocore.github.io/wiki/
> Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers
> 2) I see at least 3 separate patches below:
>- Application/Dri
>- Application/DriSecureBoot
>- RdkBootManagerLib
> 3) List.h looks mostly to be reimplementing functionality that already
>exists in BaseLib.h.
>
> If you could address these three things and send out as a v2, then we
> would be in a much better position to review the contribution
> properly.
>
> Best Regards,
>
> Leif
>
> On Tue, Nov 28, 2017 at 12:57:58PM +0530, kalyan-nagabhirava wrote:
> > Linaro and RDK are  working on standardizing the boot process for RDK
> STB boxes using Uefi.
> > Added applications are reference implementation of RDK STB boot process
> on Arm platforms
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: kalyan-nagabhirava 
> > ---
> >  EmbeddedPkg/Application/Dri/Dri.c  |  26 +
> >  EmbeddedPkg/Application/Dri/Dri.inf|  56 ++
> >  .../Application/DriSecureBoot/DriSecureBoot.c  |  32 ++
> >  .../Application/DriSecureBoot/DriSecureBoot.inf|  57 ++
> >  EmbeddedPkg/Application/SecureBoot/SecureBoot.c|  30 ++
> >  EmbeddedPkg/Application/SecureBoot/SecureBoot.inf  |  57 ++
> >  EmbeddedPkg/Drivers/RdkDxe/RdkDxe.c|  97 
> >  EmbeddedPkg/Drivers/RdkDxe/RdkDxe.h|  14 +
> >  EmbeddedPkg/Drivers/RdkDxe/RdkDxe.inf  |  45 ++
> >  EmbeddedPkg/Library/RdkBootManagerLib/DiskIo.c | 536
> +++
> >  EmbeddedPkg/Library/RdkBootManagerLib/HttpBoot.c   | 315 +++
> >  .../Library/RdkBootManagerLib/Include/DiskIo.h |  20 +
> >  .../Library/RdkBootManagerLib/Include/HttpBoot.h   |   7 +
> >  .../Library/RdkBootManagerLib/Include/List.h   | 136 +
> >  .../RdkBootManagerLib/Include/RdkBootManagerLib.h  |  31 ++
> >  .../Library/RdkBootManagerLib/Include/RdkFile.h|  20 +
> >  .../Library/RdkBootManagerLib/Include/SecureBoot.h |  40 ++
> >  .../RdkBootManagerLib/RdkBootManagerLib.dec|  52 ++
> >  .../RdkBootManagerLib/RdkBootManagerLib.inf|  81 +++
> >  EmbeddedPkg/Library/RdkBootManagerLib/RdkFile.c| 259 +
> >  EmbeddedPkg/Library/RdkBootManagerLib/SecureBoot.c | 577
> +
> >  21 files changed, 2488 insertions(+)
> >  create mode 100644 EmbeddedPkg/Application/Dri/Dri.c
> >  create mode 100644 EmbeddedPkg/Application/Dri/Dri.inf
> >  create mode 100644 EmbeddedPkg/Application/
> DriSecureBoot/DriSecureBoot.c
> >  create mode 100644 EmbeddedPkg/Application/DriSecureBoot/DriSecureBoot.
> inf
> >  create mode 100644 EmbeddedPkg/Application/SecureBoot/SecureBoot.c
> >  create mode 100644 EmbeddedPkg/Application/SecureBoot/SecureBoot.inf
> >  create mode 100644 EmbeddedPkg/Drivers/RdkDxe/RdkDxe.c
> >  create mode 100644 EmbeddedPkg/Drivers/RdkDxe/RdkDxe.h
> >  create mode 100644 EmbeddedPkg/Drivers/RdkDxe/RdkDxe.inf
> >  create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/DiskIo.c
> >  create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/HttpBoot.c
> >  create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/Include/
> DiskIo.h
> >  create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/Include/
> HttpBoot.h
> >  create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/Include/List.h
> >  create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/Include/
> RdkBootManagerLib.h
> >  create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/Include/
> RdkFile.h
> >  create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/Include/
> SecureBoot.h
> >  create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/
> RdkBootManagerLib.dec
> >  create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/
> RdkBootManagerLib.inf
> >  create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/RdkFile.c
> >  create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/SecureBoot.c
>



-- 
regards,
kalyan.
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] [edk2 EmbeddedPkg]:Adding secure boot and HTTP image download (Disaster recovery image) Applications for Linux based platforms

[Leif Lindholm]

Hi Kalyan,

Am I right in assuming that since this is the output of your team, you
have some time to look into reworking based on feedback (unlike the
HiKey support)?

A few high-level comments:
1) Please generate your patches with --stat=1000 --stat-graph-width=20
   as per 
https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers
2) I see at least 3 separate patches below:
   - Application/Dri
   - Application/DriSecureBoot
   - RdkBootManagerLib
3) List.h looks mostly to be reimplementing functionality that already
   exists in BaseLib.h.

If you could address these three things and send out as a v2, then we
would be in a much better position to review the contribution
properly.

Best Regards,

Leif

On Tue, Nov 28, 2017 at 12:57:58PM +0530, kalyan-nagabhirava wrote:
> Linaro and RDK are  working on standardizing the boot process for RDK  STB 
> boxes using Uefi.
> Added applications are reference implementation of RDK STB boot process on 
> Arm platforms
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: kalyan-nagabhirava 
> ---
>  EmbeddedPkg/Application/Dri/Dri.c  |  26 +
>  EmbeddedPkg/Application/Dri/Dri.inf|  56 ++
>  .../Application/DriSecureBoot/DriSecureBoot.c  |  32 ++
>  .../Application/DriSecureBoot/DriSecureBoot.inf|  57 ++
>  EmbeddedPkg/Application/SecureBoot/SecureBoot.c|  30 ++
>  EmbeddedPkg/Application/SecureBoot/SecureBoot.inf  |  57 ++
>  EmbeddedPkg/Drivers/RdkDxe/RdkDxe.c|  97 
>  EmbeddedPkg/Drivers/RdkDxe/RdkDxe.h|  14 +
>  EmbeddedPkg/Drivers/RdkDxe/RdkDxe.inf  |  45 ++
>  EmbeddedPkg/Library/RdkBootManagerLib/DiskIo.c | 536 +++
>  EmbeddedPkg/Library/RdkBootManagerLib/HttpBoot.c   | 315 +++
>  .../Library/RdkBootManagerLib/Include/DiskIo.h |  20 +
>  .../Library/RdkBootManagerLib/Include/HttpBoot.h   |   7 +
>  .../Library/RdkBootManagerLib/Include/List.h   | 136 +
>  .../RdkBootManagerLib/Include/RdkBootManagerLib.h  |  31 ++
>  .../Library/RdkBootManagerLib/Include/RdkFile.h|  20 +
>  .../Library/RdkBootManagerLib/Include/SecureBoot.h |  40 ++
>  .../RdkBootManagerLib/RdkBootManagerLib.dec|  52 ++
>  .../RdkBootManagerLib/RdkBootManagerLib.inf|  81 +++
>  EmbeddedPkg/Library/RdkBootManagerLib/RdkFile.c| 259 +
>  EmbeddedPkg/Library/RdkBootManagerLib/SecureBoot.c | 577 
> +
>  21 files changed, 2488 insertions(+)
>  create mode 100644 EmbeddedPkg/Application/Dri/Dri.c
>  create mode 100644 EmbeddedPkg/Application/Dri/Dri.inf
>  create mode 100644 EmbeddedPkg/Application/DriSecureBoot/DriSecureBoot.c
>  create mode 100644 EmbeddedPkg/Application/DriSecureBoot/DriSecureBoot.inf
>  create mode 100644 EmbeddedPkg/Application/SecureBoot/SecureBoot.c
>  create mode 100644 EmbeddedPkg/Application/SecureBoot/SecureBoot.inf
>  create mode 100644 EmbeddedPkg/Drivers/RdkDxe/RdkDxe.c
>  create mode 100644 EmbeddedPkg/Drivers/RdkDxe/RdkDxe.h
>  create mode 100644 EmbeddedPkg/Drivers/RdkDxe/RdkDxe.inf
>  create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/DiskIo.c
>  create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/HttpBoot.c
>  create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/Include/DiskIo.h
>  create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/Include/HttpBoot.h
>  create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/Include/List.h
>  create mode 100644 
> EmbeddedPkg/Library/RdkBootManagerLib/Include/RdkBootManagerLib.h
>  create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/Include/RdkFile.h
>  create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/Include/SecureBoot.h
>  create mode 100644 
> EmbeddedPkg/Library/RdkBootManagerLib/RdkBootManagerLib.dec
>  create mode 100644 
> EmbeddedPkg/Library/RdkBootManagerLib/RdkBootManagerLib.inf
>  create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/RdkFile.c
>  create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/SecureBoot.c
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH] [edk2 EmbeddedPkg]:Adding secure boot and HTTP image download (Disaster recovery image) Applications for Linux based platforms

[kalyan-nagabhirava]

Linaro and RDK are  working on standardizing the boot process for RDK  STB 
boxes using Uefi.
Added applications are reference implementation of RDK STB boot process on Arm 
platforms

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: kalyan-nagabhirava 
---
 EmbeddedPkg/Application/Dri/Dri.c  |  26 +
 EmbeddedPkg/Application/Dri/Dri.inf|  56 ++
 .../Application/DriSecureBoot/DriSecureBoot.c  |  32 ++
 .../Application/DriSecureBoot/DriSecureBoot.inf|  57 ++
 EmbeddedPkg/Application/SecureBoot/SecureBoot.c|  30 ++
 EmbeddedPkg/Application/SecureBoot/SecureBoot.inf  |  57 ++
 EmbeddedPkg/Drivers/RdkDxe/RdkDxe.c|  97 
 EmbeddedPkg/Drivers/RdkDxe/RdkDxe.h|  14 +
 EmbeddedPkg/Drivers/RdkDxe/RdkDxe.inf  |  45 ++
 EmbeddedPkg/Library/RdkBootManagerLib/DiskIo.c | 536 +++
 EmbeddedPkg/Library/RdkBootManagerLib/HttpBoot.c   | 315 +++
 .../Library/RdkBootManagerLib/Include/DiskIo.h |  20 +
 .../Library/RdkBootManagerLib/Include/HttpBoot.h   |   7 +
 .../Library/RdkBootManagerLib/Include/List.h   | 136 +
 .../RdkBootManagerLib/Include/RdkBootManagerLib.h  |  31 ++
 .../Library/RdkBootManagerLib/Include/RdkFile.h|  20 +
 .../Library/RdkBootManagerLib/Include/SecureBoot.h |  40 ++
 .../RdkBootManagerLib/RdkBootManagerLib.dec|  52 ++
 .../RdkBootManagerLib/RdkBootManagerLib.inf|  81 +++
 EmbeddedPkg/Library/RdkBootManagerLib/RdkFile.c| 259 +
 EmbeddedPkg/Library/RdkBootManagerLib/SecureBoot.c | 577 +
 21 files changed, 2488 insertions(+)
 create mode 100644 EmbeddedPkg/Application/Dri/Dri.c
 create mode 100644 EmbeddedPkg/Application/Dri/Dri.inf
 create mode 100644 EmbeddedPkg/Application/DriSecureBoot/DriSecureBoot.c
 create mode 100644 EmbeddedPkg/Application/DriSecureBoot/DriSecureBoot.inf
 create mode 100644 EmbeddedPkg/Application/SecureBoot/SecureBoot.c
 create mode 100644 EmbeddedPkg/Application/SecureBoot/SecureBoot.inf
 create mode 100644 EmbeddedPkg/Drivers/RdkDxe/RdkDxe.c
 create mode 100644 EmbeddedPkg/Drivers/RdkDxe/RdkDxe.h
 create mode 100644 EmbeddedPkg/Drivers/RdkDxe/RdkDxe.inf
 create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/DiskIo.c
 create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/HttpBoot.c
 create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/Include/DiskIo.h
 create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/Include/HttpBoot.h
 create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/Include/List.h
 create mode 100644 
EmbeddedPkg/Library/RdkBootManagerLib/Include/RdkBootManagerLib.h
 create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/Include/RdkFile.h
 create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/Include/SecureBoot.h
 create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/RdkBootManagerLib.dec
 create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/RdkBootManagerLib.inf
 create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/RdkFile.c
 create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/SecureBoot.c

diff --git a/EmbeddedPkg/Application/Dri/Dri.c 
b/EmbeddedPkg/Application/Dri/Dri.c
new file mode 100644
index 00..affbac08b6
--- /dev/null
+++ b/EmbeddedPkg/Application/Dri/Dri.c
@@ -0,0 +1,26 @@
+/*
+#  Copyright (c) 2016-2017, Linaro Limited. All rights reserved.
+#
+#  This program and the accompanying materials
+#  are licensed and made available under the terms and conditions of the BSD 
License
+#  which accompanies this distribution.  The full text of the license may be 
found at
+#  http://opensource.org/licenses/bsd-license.php
+#
+#  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+#  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR 
IMPLIED.
+#
+ */
+#include 
+
+EFI_STATUS
+EFIAPI
+DriEntryPoint (
+  IN EFI_HANDLEImageHandle,
+  IN EFI_SYSTEM_TABLE  *SystemTable
+  )
+{
+  EFI_STATUS Status;
+
+  Status = RdkHttpBoot ();
+  return Status;
+}
diff --git a/EmbeddedPkg/Application/Dri/Dri.inf 
b/EmbeddedPkg/Application/Dri/Dri.inf
new file mode 100644
index 00..d6f24b48a6
--- /dev/null
+++ b/EmbeddedPkg/Application/Dri/Dri.inf
@@ -0,0 +1,56 @@
+#
+#  Copyright (c) 2016-2017, Linaro Limited. All rights reserved.
+#  Copyright (c) 2016-2017, comcast . All rights reserved.
+#
+#  This program and the accompanying materials
+#  are licensed and made available under the terms and conditions of the BSD 
License
+#  which accompanies this distribution.  The full text of the license may be 
found at
+#  http://opensource.org/licenses/bsd-license.php
+#
+#  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+#  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR 
IMPLIED.
+#
+
+
+#
+# Defines Section - statements that will be