Re: [edk2] [PATCH] ArmPkg: fix compilation error in ArmDmaLib

2016-12-01 Thread Leif Lindholm 
On Thu, Dec 01, 2016 at 05:00:19PM +, Ard Biesheuvel wrote:
> On 1 December 2016 at 16:45, Leif Lindholm  wrote:
> > Commit 0a99a65d2c8a ("fix incorrect device address of double buffer")
> > retained an explicit cast on the variable "Buffer" which became
> > incorrect with the other changes, leading to compilation failures
> > with some toolchains. Drop the cast.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Reported-by: Sudeep Holla 
> > Signed-off-by: Leif Lindholm 
> 
> Reviewed-by: Ard Biesheuvel 

Get back on holiday!

Thanks :)

Pushed as 018c3c0, thanks.

/
Leif

> > ---
> >
> > Mike, Andrew - since Ard is on holiday and the fix is trivial,
> > could either of you give me a Reviewed-by: on this one?
> >
> >  ArmPkg/Library/ArmDmaLib/ArmDmaLib.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/ArmPkg/Library/ArmDmaLib/ArmDmaLib.c 
> > b/ArmPkg/Library/ArmDmaLib/ArmDmaLib.c
> > index acc106b..f4ee9e4 100644
> > --- a/ArmPkg/Library/ArmDmaLib/ArmDmaLib.c
> > +++ b/ArmPkg/Library/ArmDmaLib/ArmDmaLib.c
> > @@ -142,7 +142,7 @@ DmaMap (
> >  CopyMem (Buffer, HostAddress, *NumberOfBytes);
> >}
> >
> > -  *DeviceAddress = HostToDeviceAddress (ConvertToPhysicalAddress 
> > ((UINTN)Buffer));
> > +  *DeviceAddress = HostToDeviceAddress (ConvertToPhysicalAddress 
> > (Buffer));
> >Map->BufferAddress = Buffer;
> >  } else {
> >Map->DoubleBuffer  = FALSE;
> > --
> > 2.10.2
> >
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] ArmPkg: fix compilation error in ArmDmaLib

2016-12-01 Thread Ard Biesheuvel 
On 1 December 2016 at 16:45, Leif Lindholm  wrote:
> Commit 0a99a65d2c8a ("fix incorrect device address of double buffer")
> retained an explicit cast on the variable "Buffer" which became
> incorrect with the other changes, leading to compilation failures
> with some toolchains. Drop the cast.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Reported-by: Sudeep Holla 
> Signed-off-by: Leif Lindholm 

Reviewed-by: Ard Biesheuvel 

> ---
>
> Mike, Andrew - since Ard is on holiday and the fix is trivial,
> could either of you give me a Reviewed-by: on this one?
>
>  ArmPkg/Library/ArmDmaLib/ArmDmaLib.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ArmPkg/Library/ArmDmaLib/ArmDmaLib.c 
> b/ArmPkg/Library/ArmDmaLib/ArmDmaLib.c
> index acc106b..f4ee9e4 100644
> --- a/ArmPkg/Library/ArmDmaLib/ArmDmaLib.c
> +++ b/ArmPkg/Library/ArmDmaLib/ArmDmaLib.c
> @@ -142,7 +142,7 @@ DmaMap (
>  CopyMem (Buffer, HostAddress, *NumberOfBytes);
>}
>
> -  *DeviceAddress = HostToDeviceAddress (ConvertToPhysicalAddress 
> ((UINTN)Buffer));
> +  *DeviceAddress = HostToDeviceAddress (ConvertToPhysicalAddress 
> (Buffer));
>Map->BufferAddress = Buffer;
>  } else {
>Map->DoubleBuffer  = FALSE;
> --
> 2.10.2
>
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] ArmPkg: fix compilation error in ArmDmaLib

2016-12-01 Thread Sudeep Holla 



On 01/12/16 16:45, Leif Lindholm wrote:

Commit 0a99a65d2c8a ("fix incorrect device address of double buffer")
retained an explicit cast on the variable "Buffer" which became
incorrect with the other changes, leading to compilation failures
with some toolchains. Drop the cast.

Contributed-under: TianoCore Contribution Agreement 1.0
Reported-by: Sudeep Holla 


It fixes the build for me.

Tested-by: Sudeep Holla 

--
Regards,
Sudeep
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH] ArmPkg: fix compilation error in ArmDmaLib

2016-12-01 Thread Leif Lindholm 
Commit 0a99a65d2c8a ("fix incorrect device address of double buffer")
retained an explicit cast on the variable "Buffer" which became
incorrect with the other changes, leading to compilation failures
with some toolchains. Drop the cast.

Contributed-under: TianoCore Contribution Agreement 1.0
Reported-by: Sudeep Holla 
Signed-off-by: Leif Lindholm 
---

Mike, Andrew - since Ard is on holiday and the fix is trivial,
could either of you give me a Reviewed-by: on this one?

 ArmPkg/Library/ArmDmaLib/ArmDmaLib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ArmPkg/Library/ArmDmaLib/ArmDmaLib.c 
b/ArmPkg/Library/ArmDmaLib/ArmDmaLib.c
index acc106b..f4ee9e4 100644
--- a/ArmPkg/Library/ArmDmaLib/ArmDmaLib.c
+++ b/ArmPkg/Library/ArmDmaLib/ArmDmaLib.c
@@ -142,7 +142,7 @@ DmaMap (
 CopyMem (Buffer, HostAddress, *NumberOfBytes);
   }
 
-  *DeviceAddress = HostToDeviceAddress (ConvertToPhysicalAddress 
((UINTN)Buffer));
+  *DeviceAddress = HostToDeviceAddress (ConvertToPhysicalAddress (Buffer));
   Map->BufferAddress = Buffer;
 } else {
   Map->DoubleBuffer  = FALSE;
-- 
2.10.2

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel