Re: [edk2] [PATCH] BaseTools/WorkspaceCommon: Import used BuildToolError messages.

2018-06-18 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu  

Best Regards,
Zhu Yonghong


-Original Message-
From: Marvin Häuser [mailto:marvin.haeu...@outlook.com] 
Sent: Sunday, June 17, 2018 12:16 AM
To: edk2-devel@lists.01.org
Cc: Gao, Liming ; Zhu, Yonghong 
Subject: [PATCH] BaseTools/WorkspaceCommon: Import used BuildToolError messages.

Commit c14b58614ffb992dfc668966a19becb86614aafc added a few build error message 
display calls to WorkspaceCommon.py without importing the message resources 
explicitely. This commit adds imports the missing directives.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marvin Haeuser 
---
 BaseTools/Source/Python/Workspace/WorkspaceCommon.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/BaseTools/Source/Python/Workspace/WorkspaceCommon.py 
b/BaseTools/Source/Python/Workspace/WorkspaceCommon.py
index a28fbdf03021..713c1ddbddc9 100644
--- a/BaseTools/Source/Python/Workspace/WorkspaceCommon.py
+++ b/BaseTools/Source/Python/Workspace/WorkspaceCommon.py
@@ -16,6 +16,9 @@ from Common.DataType import SUP_MODULE_USER_DEFINED  from 
BuildClassObject import LibraryClassObject  import Common.GlobalData as 
GlobalData  from Workspace.BuildClassObject import StructurePcd
+from Common.BuildToolError import RESOURCE_NOT_AVAILABLE from 
+Common.BuildToolError import OPTION_MISSING from Common.BuildToolError 
+import BUILD_ERROR
 
 class OrderedListDict(OrderedDict, defaultdict):
 def __init__(self, *args, **kwargs):
--
2.17.1.windows.2

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


[edk2] [PATCH] BaseTools/WorkspaceCommon: Import used BuildToolError messages.

2018-06-16 Thread Marvin Häuser
Commit c14b58614ffb992dfc668966a19becb86614aafc added a few build
error message display calls to WorkspaceCommon.py without importing
the message resources explicitely. This commit adds imports the
missing directives.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marvin Haeuser 
---
 BaseTools/Source/Python/Workspace/WorkspaceCommon.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/BaseTools/Source/Python/Workspace/WorkspaceCommon.py 
b/BaseTools/Source/Python/Workspace/WorkspaceCommon.py
index a28fbdf03021..713c1ddbddc9 100644
--- a/BaseTools/Source/Python/Workspace/WorkspaceCommon.py
+++ b/BaseTools/Source/Python/Workspace/WorkspaceCommon.py
@@ -16,6 +16,9 @@ from Common.DataType import SUP_MODULE_USER_DEFINED
 from BuildClassObject import LibraryClassObject
 import Common.GlobalData as GlobalData
 from Workspace.BuildClassObject import StructurePcd
+from Common.BuildToolError import RESOURCE_NOT_AVAILABLE
+from Common.BuildToolError import OPTION_MISSING
+from Common.BuildToolError import BUILD_ERROR
 
 class OrderedListDict(OrderedDict, defaultdict):
 def __init__(self, *args, **kwargs):
-- 
2.17.1.windows.2

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel