Re: [edk2] [PATCH] ShellPkg/TftpDynamicCommand: Return proper status

2019-01-25 Thread Carsey, Jaben 
Reviewed-by: Jaben Carsey 

And pushed with the BZ added to commit REF.



> -Original Message-
> From: Li, Songpeng
> Sent: Thursday, January 24, 2019 9:08 PM
> To: Vladimir Olovyannikov ; edk2-
> de...@lists.01.org
> Cc: Carsey, Jaben ; Ni, Ray 
> Subject: RE: [edk2] [PATCH] ShellPkg/TftpDynamicCommand: Return proper
> status
> Importance: High
> 
> Reviewed-by: Songpeng Li 
> 
> Sorry, the previous email did not include edk2 mailing list.
> 
> Best,
> Songpeng
> 
> 
> > -Original Message-
> > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> > Vladimir Olovyannikov via edk2-devel
> > Sent: Thursday, January 24, 2019 2:26 AM
> > To: Carsey, Jaben ; Ni, Ray ;
> > edk2-devel@lists.01.org
> > Cc: Vladimir Olovyannikov 
> > Subject: [edk2] [PATCH] ShellPkg/TftpDynamicCommand: Return proper
> > status
> >
> > Tftp command always returned "SHELL_NOT_FOUND" which is treated as
> an
> > error by callers. Add missing line to clean the ShellStatus on
> > successful operation. If operation has failed, return the error status
> > if available.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Vladimir Olovyannikov
> > 
> > ---
> >  ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c | 6 ++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c
> > b/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c
> > index ba753a279b00..88e3988a554e 100644
> > --- a/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c
> > +++ b/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c
> > @@ -548,6 +548,8 @@ RunTftp (
> >goto NextHandle;
> >  }
> >
> > +ShellStatus = SHELL_SUCCESS;
> > +
> >  NextHandle:
> >
> >  CloseProtocolAndDestroyServiceChild (
> > @@ -575,6 +577,10 @@ RunTftp (
> >  FreePool (Handles);
> >}
> >
> > +  if ((ShellStatus != SHELL_SUCCESS) && (EFI_ERROR(Status))) {
> > +ShellStatus = Status & ~MAX_BIT;
> > +  }
> > +
> >return ShellStatus;
> >  }
> >
> > --
> > 2.20.1
> >
> > ___
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] ShellPkg/TftpDynamicCommand: Return proper status

2019-01-24 Thread Li, Songpeng 
Reviewed-by: Songpeng Li 

Sorry, the previous email did not include edk2 mailing list.

Best,
Songpeng


> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Vladimir Olovyannikov via edk2-devel
> Sent: Thursday, January 24, 2019 2:26 AM
> To: Carsey, Jaben ; Ni, Ray ;
> edk2-devel@lists.01.org
> Cc: Vladimir Olovyannikov 
> Subject: [edk2] [PATCH] ShellPkg/TftpDynamicCommand: Return proper
> status
> 
> Tftp command always returned "SHELL_NOT_FOUND" which is treated as an
> error by callers. Add missing line to clean the ShellStatus on
> successful operation. If operation has failed, return the error status
> if available.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Vladimir Olovyannikov
> 
> ---
>  ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c | 6 ++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c
> b/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c
> index ba753a279b00..88e3988a554e 100644
> --- a/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c
> +++ b/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c
> @@ -548,6 +548,8 @@ RunTftp (
>goto NextHandle;
>  }
> 
> +ShellStatus = SHELL_SUCCESS;
> +
>  NextHandle:
> 
>  CloseProtocolAndDestroyServiceChild (
> @@ -575,6 +577,10 @@ RunTftp (
>  FreePool (Handles);
>}
> 
> +  if ((ShellStatus != SHELL_SUCCESS) && (EFI_ERROR(Status))) {
> +ShellStatus = Status & ~MAX_BIT;
> +  }
> +
>return ShellStatus;
>  }
> 
> --
> 2.20.1
> 
> ___
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH] ShellPkg/TftpDynamicCommand: Return proper status

2019-01-23 Thread Vladimir Olovyannikov via edk2-devel 
Tftp command always returned "SHELL_NOT_FOUND" which is treated as an
error by callers. Add missing line to clean the ShellStatus on
successful operation. If operation has failed, return the error status
if available.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Vladimir Olovyannikov 
---
 ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c 
b/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c
index ba753a279b00..88e3988a554e 100644
--- a/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c
+++ b/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c
@@ -548,6 +548,8 @@ RunTftp (
   goto NextHandle;
 }
 
+ShellStatus = SHELL_SUCCESS;
+
 NextHandle:
 
 CloseProtocolAndDestroyServiceChild (
@@ -575,6 +577,10 @@ RunTftp (
 FreePool (Handles);
   }
 
+  if ((ShellStatus != SHELL_SUCCESS) && (EFI_ERROR(Status))) {
+ShellStatus = Status & ~MAX_BIT;
+  }
+
   return ShellStatus;
 }
 
-- 
2.20.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel