Re: [edk2] [PATCH] ShellPkg/dh: Fix wrong output when dumping PciRootBridgeIo

[Carsey, Jaben]

Reviewed-by: Jaben Carsey <jaben.car...@intel.com>

> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Ruiyu Ni
> Sent: Monday, November 06, 2017 11:35 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.car...@intel.com>
> Subject: [edk2] [PATCH] ShellPkg/dh: Fix wrong output when dumping
> PciRootBridgeIo
> Importance: High
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ruiyu Ni <ruiyu...@intel.com>
> Cc: Jaben Carsey <jaben.car...@intel.com>
> ---
>  ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> index d343f3352e..b7b0246ac9 100644
> --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> @@ -682,7 +682,7 @@ PciRootBridgeIoDumpInformation(
>  break;
>}
>if (Temp != NULL) {
> -Temp2 = CatSPrint(RetVal, L"%s", Temp);
> +Temp2 = CatSPrint(RetVal, L"\r\n%s", Temp);
>  FreePool(Temp);
>  FreePool(RetVal);
>  RetVal = Temp2;
> @@ -690,7 +690,7 @@ PciRootBridgeIoDumpInformation(
>}
> 
>Temp2 = CatSPrint(RetVal,
> -L"\r\n%%H%02x%016lx  %016lx  %02x%%N",
> +L"%%H%02x%016lx  %016lx  %02x%%N",
>  Configuration->SpecificFlag,
>  Configuration->AddrRangeMin,
>  Configuration->AddrRangeMax,
> --
> 2.12.2.windows.2
> 
> ___
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH] ShellPkg/dh: Fix wrong output when dumping PciRootBridgeIo

[Ruiyu Ni]

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni 
Cc: Jaben Carsey 
---
 ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c 
b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
index d343f3352e..b7b0246ac9 100644
--- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
+++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
@@ -682,7 +682,7 @@ PciRootBridgeIoDumpInformation(
 break;
   }
   if (Temp != NULL) {
-Temp2 = CatSPrint(RetVal, L"%s", Temp);
+Temp2 = CatSPrint(RetVal, L"\r\n%s", Temp);
 FreePool(Temp);
 FreePool(RetVal);
 RetVal = Temp2;
@@ -690,7 +690,7 @@ PciRootBridgeIoDumpInformation(
   }
 
   Temp2 = CatSPrint(RetVal,
-L"\r\n%%H%02x%016lx  %016lx  %02x%%N",
+L"%%H%02x%016lx  %016lx  %02x%%N",
 Configuration->SpecificFlag,
 Configuration->AddrRangeMin,
 Configuration->AddrRangeMax,
-- 
2.12.2.windows.2

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel