Re: [edk2] [PATCH 0/2] Follow PI1.4a to fix artificial limitation of PCD SkuId range
Reviewed-by: Liming Gao <liming@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Star Zeng > Sent: Friday, September 02, 2016 7:59 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star <star.z...@intel.com> > Subject: [edk2] [PATCH 0/2] Follow PI1.4a to fix artificial limitation of PCD > SkuId range > > Current BaseTools follow previous PI spec to use UINT8 for SkuId, to > follow PI1.4a, BaseTools need to be updated to fix artificial limitation > of PCD SkuId range. > > BaseTools is updated to use UINT64 for SkuId, since the PCD database > structure needs to be naturally aligned, the PCD database structure > layout is adjusted to keep the natural alignment and version > is updated to 6. > > The structure definition in MdeModulePkg/Include/Guid/ > PcdDataBaseSignatureGuid.h and PCD drivers are also updated to match > BaseTools. > > Note: The source code and BaseTools need to be upgraded at the same time, > and if they are not upgraded at the same time, build error like below will > be triggered to help user identify the problem. > > "Please make sure the version of PCD PEIM Service and the generated > PCD PEI Database match." > > Star Zeng (1): > MdeModulePkg PCD: Update PCD database structure definition to match > BaseTools > > Yonghong Zhu (1): > BaseTools: Follow PI1.4a to fix artificial limitation of PCD SkuId > range > > BaseTools/Source/Python/AutoGen/GenPcdDb.py| 91 > ++ > .../Include/Guid/PcdDataBaseSignatureGuid.h| 14 ++-- > MdeModulePkg/Universal/PCD/Dxe/Pcd.c | 2 +- > MdeModulePkg/Universal/PCD/Dxe/Service.c | 2 +- > MdeModulePkg/Universal/PCD/Dxe/Service.h | 4 +- > MdeModulePkg/Universal/PCD/Pei/Pcd.c | 2 +- > MdeModulePkg/Universal/PCD/Pei/Service.c | 4 +- > MdeModulePkg/Universal/PCD/Pei/Service.h | 4 +- > 8 files changed, 73 insertions(+), 50 deletions(-) > > -- > 2.7.0.windows.1 > > ___ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] [PATCH 0/2] Follow PI1.4a to fix artificial limitation of PCD SkuId range
Current BaseTools follow previous PI spec to use UINT8 for SkuId, to follow PI1.4a, BaseTools need to be updated to fix artificial limitation of PCD SkuId range. BaseTools is updated to use UINT64 for SkuId, since the PCD database structure needs to be naturally aligned, the PCD database structure layout is adjusted to keep the natural alignment and version is updated to 6. The structure definition in MdeModulePkg/Include/Guid/ PcdDataBaseSignatureGuid.h and PCD drivers are also updated to match BaseTools. Note: The source code and BaseTools need to be upgraded at the same time, and if they are not upgraded at the same time, build error like below will be triggered to help user identify the problem. "Please make sure the version of PCD PEIM Service and the generated PCD PEI Database match." Star Zeng (1): MdeModulePkg PCD: Update PCD database structure definition to match BaseTools Yonghong Zhu (1): BaseTools: Follow PI1.4a to fix artificial limitation of PCD SkuId range BaseTools/Source/Python/AutoGen/GenPcdDb.py| 91 ++ .../Include/Guid/PcdDataBaseSignatureGuid.h| 14 ++-- MdeModulePkg/Universal/PCD/Dxe/Pcd.c | 2 +- MdeModulePkg/Universal/PCD/Dxe/Service.c | 2 +- MdeModulePkg/Universal/PCD/Dxe/Service.h | 4 +- MdeModulePkg/Universal/PCD/Pei/Pcd.c | 2 +- MdeModulePkg/Universal/PCD/Pei/Service.c | 4 +- MdeModulePkg/Universal/PCD/Pei/Service.h | 4 +- 8 files changed, 73 insertions(+), 50 deletions(-) -- 2.7.0.windows.1 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 0/2] Follow PI1.4a to fix artificial limitation of PCD SkuId range
Reviewed-by: Liming Gao <liming@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Star Zeng > Sent: Friday, May 20, 2016 2:49 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH 0/2] Follow PI1.4a to fix artificial limitation of PCD > SkuId range > > There is absolutely no reason to artificially limit the SKU range to 1-255. > PI1.4a spec fixed the artificial limitation. > > The patches are to follow PI1.4a spec to remove the sentence > "The valid SkuId range is 1 to 255." from SetSku function comments, > PCD_MAX_SKU_ID definition, the check to PCD_MAX_SKU_ID and the > comments > describes the limitation. > > Star Zeng (2): > MdeModulePkg PCD: Follow PI1.4a to fix artificial limitation of SkuId > range > MdePkg: Follow PI1.4a to fix artificial limitation of SkuId range > > MdeModulePkg/Universal/PCD/Dxe/Pcd.c | 6 +++--- > MdeModulePkg/Universal/PCD/Pei/Pcd.c | 4 ++-- > MdePkg/Include/Library/PcdLib.h| 7 +-- > MdePkg/Library/BasePcdLibNull/PcdLib.c | 6 +- > MdePkg/Library/DxePcdLib/DxePcdLib.c | 14 ++ > MdePkg/Library/PeiPcdLib/PeiPcdLib.c | 15 ++- > 6 files changed, 11 insertions(+), 41 deletions(-) > > -- > 2.7.0.windows.1 > > ___ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] [PATCH 0/2] Follow PI1.4a to fix artificial limitation of PCD SkuId range
There is absolutely no reason to artificially limit the SKU range to 1-255. PI1.4a spec fixed the artificial limitation. The patches are to follow PI1.4a spec to remove the sentence "The valid SkuId range is 1 to 255." from SetSku function comments, PCD_MAX_SKU_ID definition, the check to PCD_MAX_SKU_ID and the comments describes the limitation. Star Zeng (2): MdeModulePkg PCD: Follow PI1.4a to fix artificial limitation of SkuId range MdePkg: Follow PI1.4a to fix artificial limitation of SkuId range MdeModulePkg/Universal/PCD/Dxe/Pcd.c | 6 +++--- MdeModulePkg/Universal/PCD/Pei/Pcd.c | 4 ++-- MdePkg/Include/Library/PcdLib.h| 7 +-- MdePkg/Library/BasePcdLibNull/PcdLib.c | 6 +- MdePkg/Library/DxePcdLib/DxePcdLib.c | 14 ++ MdePkg/Library/PeiPcdLib/PeiPcdLib.c | 15 ++- 6 files changed, 11 insertions(+), 41 deletions(-) -- 2.7.0.windows.1 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
