Re: [edk2] [PATCH 0/4] Add PEI Stack Guard feature
On 09/03/18 05:15, Jian J Wang wrote: > This patch series try to add PEI Stack Guard feature. Please refer to > following trackers for details. > > The machanism behind this feature is the same as Stack Guard for UEFI > drivers, and similiar implementation is also employed. > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1126 > https://bugzilla.tianocore.org/show_bug.cgi?id=1137 > > Jian J Wang (4): > MdeModulePkg/DxeIpl: disable paging before creating new page table > UefiCpuPkg/CpuExceptionHandlerLib: support stack switch for PEI > exceptions > UefiCpuPkg/MpInitLib: fix register restore issue in AP wakeup > UefiCpuPkg/CpuMpPei: support stack guard feature > > MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c| 10 + > UefiCpuPkg/CpuMpPei/CpuMpPei.c | 269 - > UefiCpuPkg/CpuMpPei/CpuMpPei.h | 14 + > UefiCpuPkg/CpuMpPei/CpuMpPei.inf | 11 +- > UefiCpuPkg/CpuMpPei/CpuPaging.c| 637 > + > .../CpuExceptionHandlerLib/PeiCpuException.c | 27 +- > .../PeiCpuExceptionHandlerLib.inf | 4 + > UefiCpuPkg/Library/MpInitLib/MpLib.c | 8 +- > 8 files changed, 962 insertions(+), 18 deletions(-) > create mode 100644 UefiCpuPkg/CpuMpPei/CpuPaging.c > Regression-tested-by: Laszlo Ersek ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 0/4] Add PEI Stack Guard feature
Here're the tests I've done: * Emulate stack overflow by calling a function recursively, for all BSP and APs, and check the RSP and CR2 to see if they're close in exception message. * OS boot (x64): Fedora 26, Ubuntu 18.04, Windows 10, Windows 7 (Platform: OVMF) Regards, Jian From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yao, Jiewen Sent: Monday, September 03, 2018 12:15 PM To: edk2-devel ; edk2-devel@lists.01.org Subject: Re: [edk2] [PATCH 0/4] Add PEI Stack Guard feature Hi Would you please add more description on what test has been done for this patch? Thank you Yao Jiewen > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] > Sent: Monday, September 3, 2018 11:16 AM > To: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org> > Subject: [edk2] [PATCH 0/4] Add PEI Stack Guard feature > > This patch series try to add PEI Stack Guard feature. Please refer to > following trackers for details. > > The machanism behind this feature is the same as Stack Guard for UEFI > drivers, and similiar implementation is also employed. > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1126 > https://bugzilla.tianocore.org/show_bug.cgi?id=1137 > > Jian J Wang (4): > MdeModulePkg/DxeIpl: disable paging before creating new page table > UefiCpuPkg/CpuExceptionHandlerLib: support stack switch for PEI > exceptions > UefiCpuPkg/MpInitLib: fix register restore issue in AP wakeup > UefiCpuPkg/CpuMpPei: support stack guard feature > > MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c| 10 + > UefiCpuPkg/CpuMpPei/CpuMpPei.c | 269 - > UefiCpuPkg/CpuMpPei/CpuMpPei.h | 14 + > UefiCpuPkg/CpuMpPei/CpuMpPei.inf | 11 +- > UefiCpuPkg/CpuMpPei/CpuPaging.c| 637 > + > .../CpuExceptionHandlerLib/PeiCpuException.c | 27 +- > .../PeiCpuExceptionHandlerLib.inf | 4 + > UefiCpuPkg/Library/MpInitLib/MpLib.c | 8 +- > 8 files changed, 962 insertions(+), 18 deletions(-) > create mode 100644 UefiCpuPkg/CpuMpPei/CpuPaging.c > > -- > 2.16.2.windows.1 > > ___ > edk2-devel mailing list > edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org> > https://lists.01.org/mailman/listinfo/edk2-devel ___ edk2-devel mailing list edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org> https://lists.01.org/mailman/listinfo/edk2-devel ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 0/4] Add PEI Stack Guard feature
Hi Would you please add more description on what test has been done for this patch? Thank you Yao Jiewen > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] > Sent: Monday, September 3, 2018 11:16 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH 0/4] Add PEI Stack Guard feature > > This patch series try to add PEI Stack Guard feature. Please refer to > following trackers for details. > > The machanism behind this feature is the same as Stack Guard for UEFI > drivers, and similiar implementation is also employed. > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1126 > https://bugzilla.tianocore.org/show_bug.cgi?id=1137 > > Jian J Wang (4): > MdeModulePkg/DxeIpl: disable paging before creating new page table > UefiCpuPkg/CpuExceptionHandlerLib: support stack switch for PEI > exceptions > UefiCpuPkg/MpInitLib: fix register restore issue in AP wakeup > UefiCpuPkg/CpuMpPei: support stack guard feature > > MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c| 10 + > UefiCpuPkg/CpuMpPei/CpuMpPei.c | 269 - > UefiCpuPkg/CpuMpPei/CpuMpPei.h | 14 + > UefiCpuPkg/CpuMpPei/CpuMpPei.inf | 11 +- > UefiCpuPkg/CpuMpPei/CpuPaging.c| 637 > + > .../CpuExceptionHandlerLib/PeiCpuException.c | 27 +- > .../PeiCpuExceptionHandlerLib.inf | 4 + > UefiCpuPkg/Library/MpInitLib/MpLib.c | 8 +- > 8 files changed, 962 insertions(+), 18 deletions(-) > create mode 100644 UefiCpuPkg/CpuMpPei/CpuPaging.c > > -- > 2.16.2.windows.1 > > ___ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] [PATCH 0/4] Add PEI Stack Guard feature
This patch series try to add PEI Stack Guard feature. Please refer to following trackers for details. The machanism behind this feature is the same as Stack Guard for UEFI drivers, and similiar implementation is also employed. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1126 https://bugzilla.tianocore.org/show_bug.cgi?id=1137 Jian J Wang (4): MdeModulePkg/DxeIpl: disable paging before creating new page table UefiCpuPkg/CpuExceptionHandlerLib: support stack switch for PEI exceptions UefiCpuPkg/MpInitLib: fix register restore issue in AP wakeup UefiCpuPkg/CpuMpPei: support stack guard feature MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c| 10 + UefiCpuPkg/CpuMpPei/CpuMpPei.c | 269 - UefiCpuPkg/CpuMpPei/CpuMpPei.h | 14 + UefiCpuPkg/CpuMpPei/CpuMpPei.inf | 11 +- UefiCpuPkg/CpuMpPei/CpuPaging.c| 637 + .../CpuExceptionHandlerLib/PeiCpuException.c | 27 +- .../PeiCpuExceptionHandlerLib.inf | 4 + UefiCpuPkg/Library/MpInitLib/MpLib.c | 8 +- 8 files changed, 962 insertions(+), 18 deletions(-) create mode 100644 UefiCpuPkg/CpuMpPei/CpuPaging.c -- 2.16.2.windows.1 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
