Re: [edk2] [PATCH 0/7] SdMmc fixes and SdMmcOverride extension
Hi Ard,
czw., 6 wrz 2018 o 16:12 Ard Biesheuvel napisał(a):
>
> On 3 September 2018 at 06:54, Marcin Wojtas wrote:
> > Hi,
> >
> > This patchset extends SdMmcOverride protocol with new callbacks:
> > * UhsSignaling - allow writing custom values to HostControl2 register
> > * SwitchClockFreqPost - perform additional opperations after clock switch
> > * BaseClockFreq - allow overriding base clock frequency
> > Also a couple of fixes for MMC, card detection and reset are submitted.
> > More details can be found in the commit messages.
> >
> > Patches are available in the github:
> > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/sdmmc-override-upstream-r20180902
> >
> > Please note that extending SdMmcOverride protocol was impacting
> > so far the only user of it (Synquacer controller). In paralel
> > edk2-platforms patchset, a patch can be found:
> > ("Silicon/SynQuacer/PlatformDxe: Modify initialization of SdMmcOverride")
> > which immunizes for above and future extensions of the protocol:
> > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/xenon-upstream-r20180902
> >
> > I'm looking forward to the comments and remarks.
> >
>
> Could we split this into a series of fixes/compliance tweaks, and a
> set of changes to the SD/MMC override protocol hooks that need to be
> added to accommodate Xenon?
>
> I suppose the former can be merged without much hassle, but the latter
> may provoke some fierce discussion, I'm afraid.
>
Ok. will split into two separate series. Anyway, I hope the override
protocol won't be that problematic - no functional change for
non-users, and the callbacks resemble the hooks that are provided by
drivers/mmc in Linux.
Marcin
>
>
> > Marcin Wojtas (3):
> > MdeModulePkg/SdMmcPciHcDxe: Fix HS200 operation
> > MdeModulePkg/SdMmcPciHcDxe: Adjust eMMC clock and bus width sequence
> > MdeModulePkg/SdMmcPciHcDxe: Execute card detect only for RemovableSlot
> >
> > Tomasz Michalec (4):
> > MdeModulePkg/SdMmcPciHcDxe: Add UhsSignaling to SdMmcOverride protocol
> > MdeModulePkg/SdMmcPciHcDxe: Add SwitchClockFreqPost to SdMmcOverride
> > MdeModulePkg/SdMmcPciHcDxe: Allow overriding base clock frequency
> > MdeModulePkg/SdMmcPciHcDxe: Fix SdMmcHcReset to set only necesery bits
> >
> > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 6 +
> > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h | 67 +-
> > MdeModulePkg/Include/Protocol/SdMmcOverride.h | 83 ++-
> > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c| 246
> > +---
> > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c | 55 -
> > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 37 ++-
> > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 102 ++--
> > 7 files changed, 467 insertions(+), 129 deletions(-)
> >
> > --
> > 2.7.4
> >
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 0/7] SdMmc fixes and SdMmcOverride extension
On 3 September 2018 at 06:54, Marcin Wojtas wrote:
> Hi,
>
> This patchset extends SdMmcOverride protocol with new callbacks:
> * UhsSignaling - allow writing custom values to HostControl2 register
> * SwitchClockFreqPost - perform additional opperations after clock switch
> * BaseClockFreq - allow overriding base clock frequency
> Also a couple of fixes for MMC, card detection and reset are submitted.
> More details can be found in the commit messages.
>
> Patches are available in the github:
> https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/sdmmc-override-upstream-r20180902
>
> Please note that extending SdMmcOverride protocol was impacting
> so far the only user of it (Synquacer controller). In paralel
> edk2-platforms patchset, a patch can be found:
> ("Silicon/SynQuacer/PlatformDxe: Modify initialization of SdMmcOverride")
> which immunizes for above and future extensions of the protocol:
> https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/xenon-upstream-r20180902
>
> I'm looking forward to the comments and remarks.
>
Could we split this into a series of fixes/compliance tweaks, and a
set of changes to the SD/MMC override protocol hooks that need to be
added to accommodate Xenon?
I suppose the former can be merged without much hassle, but the latter
may provoke some fierce discussion, I'm afraid.
> Marcin Wojtas (3):
> MdeModulePkg/SdMmcPciHcDxe: Fix HS200 operation
> MdeModulePkg/SdMmcPciHcDxe: Adjust eMMC clock and bus width sequence
> MdeModulePkg/SdMmcPciHcDxe: Execute card detect only for RemovableSlot
>
> Tomasz Michalec (4):
> MdeModulePkg/SdMmcPciHcDxe: Add UhsSignaling to SdMmcOverride protocol
> MdeModulePkg/SdMmcPciHcDxe: Add SwitchClockFreqPost to SdMmcOverride
> MdeModulePkg/SdMmcPciHcDxe: Allow overriding base clock frequency
> MdeModulePkg/SdMmcPciHcDxe: Fix SdMmcHcReset to set only necesery bits
>
> MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 6 +
> MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h | 67 +-
> MdeModulePkg/Include/Protocol/SdMmcOverride.h | 83 ++-
> MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c| 246 +---
> MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c | 55 -
> MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 37 ++-
> MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 102 ++--
> 7 files changed, 467 insertions(+), 129 deletions(-)
>
> --
> 2.7.4
>
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 0/7] SdMmc fixes and SdMmcOverride extension
Hi,
I will take a look into this series.
It might take me some time for the review, please help to ping this mail
thread if there is no response from me in 2 weeks. Sorry for the possible
delay.
Also, cc Ard in the list to see if he has any comment on this. As Ard is
the contributor of the SD/MMC override protocol.
Best Regards,
Hao Wu
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Marcin Wojtas
> Sent: Monday, September 03, 2018 12:54 PM
> To: edk2-devel@lists.01.org
> Cc: Tian, Feng; nad...@marvell.com; Gao, Liming; Kinney, Michael D
> Subject: [edk2] [PATCH 0/7] SdMmc fixes and SdMmcOverride extension
>
> Hi,
>
> This patchset extends SdMmcOverride protocol with new callbacks:
> * UhsSignaling - allow writing custom values to HostControl2 register
> * SwitchClockFreqPost - perform additional opperations after clock switch
> * BaseClockFreq - allow overriding base clock frequency
> Also a couple of fixes for MMC, card detection and reset are submitted.
> More details can be found in the commit messages.
>
> Patches are available in the github:
> https://github.com/MarvellEmbeddedProcessors/edk2-open-
> platform/commits/sdmmc-override-upstream-r20180902
>
> Please note that extending SdMmcOverride protocol was impacting
> so far the only user of it (Synquacer controller). In paralel
> edk2-platforms patchset, a patch can be found:
> ("Silicon/SynQuacer/PlatformDxe: Modify initialization of SdMmcOverride")
> which immunizes for above and future extensions of the protocol:
> https://github.com/MarvellEmbeddedProcessors/edk2-open-
> platform/commits/xenon-upstream-r20180902
>
> I'm looking forward to the comments and remarks.
>
> Best regards,
> Marcin
>
> Marcin Wojtas (3):
> MdeModulePkg/SdMmcPciHcDxe: Fix HS200 operation
> MdeModulePkg/SdMmcPciHcDxe: Adjust eMMC clock and bus width sequence
> MdeModulePkg/SdMmcPciHcDxe: Execute card detect only for RemovableSlot
>
> Tomasz Michalec (4):
> MdeModulePkg/SdMmcPciHcDxe: Add UhsSignaling to SdMmcOverride
> protocol
> MdeModulePkg/SdMmcPciHcDxe: Add SwitchClockFreqPost to SdMmcOverride
> MdeModulePkg/SdMmcPciHcDxe: Allow overriding base clock frequency
> MdeModulePkg/SdMmcPciHcDxe: Fix SdMmcHcReset to set only necesery bits
>
> MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 6 +
> MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h | 67 +-
> MdeModulePkg/Include/Protocol/SdMmcOverride.h | 83 ++-
> MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c| 246
> +---
> MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c | 55 -
> MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 37 ++-
> MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 102 ++--
> 7 files changed, 467 insertions(+), 129 deletions(-)
>
> --
> 2.7.4
>
> ___
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] [PATCH 0/7] SdMmc fixes and SdMmcOverride extension
Hi,
This patchset extends SdMmcOverride protocol with new callbacks:
* UhsSignaling - allow writing custom values to HostControl2 register
* SwitchClockFreqPost - perform additional opperations after clock switch
* BaseClockFreq - allow overriding base clock frequency
Also a couple of fixes for MMC, card detection and reset are submitted.
More details can be found in the commit messages.
Patches are available in the github:
https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/sdmmc-override-upstream-r20180902
Please note that extending SdMmcOverride protocol was impacting
so far the only user of it (Synquacer controller). In paralel
edk2-platforms patchset, a patch can be found:
("Silicon/SynQuacer/PlatformDxe: Modify initialization of SdMmcOverride")
which immunizes for above and future extensions of the protocol:
https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/xenon-upstream-r20180902
I'm looking forward to the comments and remarks.
Best regards,
Marcin
Marcin Wojtas (3):
MdeModulePkg/SdMmcPciHcDxe: Fix HS200 operation
MdeModulePkg/SdMmcPciHcDxe: Adjust eMMC clock and bus width sequence
MdeModulePkg/SdMmcPciHcDxe: Execute card detect only for RemovableSlot
Tomasz Michalec (4):
MdeModulePkg/SdMmcPciHcDxe: Add UhsSignaling to SdMmcOverride protocol
MdeModulePkg/SdMmcPciHcDxe: Add SwitchClockFreqPost to SdMmcOverride
MdeModulePkg/SdMmcPciHcDxe: Allow overriding base clock frequency
MdeModulePkg/SdMmcPciHcDxe: Fix SdMmcHcReset to set only necesery bits
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 6 +
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h | 67 +-
MdeModulePkg/Include/Protocol/SdMmcOverride.h | 83 ++-
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c| 246 +---
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c | 55 -
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 37 ++-
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 102 ++--
7 files changed, 467 insertions(+), 129 deletions(-)
--
2.7.4
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
